LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Bastien Nocera <hadess@hadess.net>
To: Hamza Mahfooz <someguy@effective-light.com>,
	linux-kernel@vger.kernel.org
Cc: "Filipe Laíns" <lains@riseup.net>,
	"Jiri Kosina" <jikos@kernel.org>,
	"Benjamin Tissoires" <benjamin.tissoires@redhat.com>,
	linux-input@vger.kernel.org
Subject: Re: [PATCH v3] HID: logitech-hidpp: battery: provide CAPACITY property for newer devices
Date: Fri, 23 Jul 2021 21:11:11 +0200	[thread overview]
Message-ID: <c09e3c193c62a0a85c552ebce85f858883996104.camel@hadess.net> (raw)
In-Reply-To: <20210723185720.29314-1-someguy@effective-light.com>

On Fri, 2021-07-23 at 14:57 -0400, Hamza Mahfooz wrote:
> For devices that only support the BATTERY_VOLTAGE (0x1001) feature,
> UPower
> requires the additional information provided by this patch, to set
> them up.
> 
> Signed-off-by: Hamza Mahfooz <someguy@effective-light.com>
> ---
> 
> v2: use ARRAY_SIZE() and set voltages[]'s size to 100
> 
> v3: add a check to ensure that exactly 100 elements are in voltages[]
> ---

> <snip>
> +       BUILD_BUG_ON(ARRAY_SIZE(voltages) != 100);

Sweet!

Reviewed-By: Bastien Nocera <hadess@hadess.net>


  reply	other threads:[~2021-07-23 19:11 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-23 18:57 Hamza Mahfooz
2021-07-23 19:11 ` Bastien Nocera [this message]
2021-07-23 19:42 ` Filipe Laíns
2021-07-23 21:39   ` Hamza Mahfooz
2021-07-31 22:08     ` Filipe Laíns

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c09e3c193c62a0a85c552ebce85f858883996104.camel@hadess.net \
    --to=hadess@hadess.net \
    --cc=benjamin.tissoires@redhat.com \
    --cc=jikos@kernel.org \
    --cc=lains@riseup.net \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=someguy@effective-light.com \
    --subject='Re: [PATCH v3] HID: logitech-hidpp: battery: provide CAPACITY property for newer devices' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).