LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Jarkko Sakkinen <jarkko@kernel.org>
To: Cai Huoqing <caihuoqing@baidu.com>, peterhuewe@gmx.de, jgg@ziepe.ca
Cc: linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tpm: tis: Kconfig: Add helper dependency on COMPILE_TEST
Date: Thu, 26 Aug 2021 01:20:18 +0300	[thread overview]
Message-ID: <c497b3055c49733a10a25e0356090d593874e2ea.camel@kernel.org> (raw)
In-Reply-To: <20210825062617.2435-1-caihuoqing@baidu.com>

On Wed, 2021-08-25 at 14:26 +0800, Cai Huoqing wrote:
> it's helpful for complie test in other platform(e.g.X86)

You need to write a proper long description, starting from that
sentences start with capital letter and end with a period.

What is "it"?


> Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
> ---
>  drivers/char/tpm/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/char/tpm/Kconfig b/drivers/char/tpm/Kconfig
> index d6ba644f6b00..4a5516406c22 100644
> --- a/drivers/char/tpm/Kconfig
> +++ b/drivers/char/tpm/Kconfig
> @@ -76,7 +76,7 @@ config TCG_TIS_SPI_CR50
>  
>  config TCG_TIS_SYNQUACER
>  	tristate "TPM Interface Specification 1.2 Interface / TPM 2.0 FIFO Interface (MMIO - SynQuacer)"
> -	depends on ARCH_SYNQUACER
> +	depends on ARCH_SYNQUACER || COMPILE_TEST
>  	select TCG_TIS_CORE
>  	help
>  	  If you have a TPM security chip that is compliant with the

/Jarkko


      reply	other threads:[~2021-08-25 22:20 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-25  6:26 Cai Huoqing
2021-08-25 22:20 ` Jarkko Sakkinen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c497b3055c49733a10a25e0356090d593874e2ea.camel@kernel.org \
    --to=jarkko@kernel.org \
    --cc=caihuoqing@baidu.com \
    --cc=jgg@ziepe.ca \
    --cc=linux-integrity@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peterhuewe@gmx.de \
    --subject='Re: [PATCH] tpm: tis: Kconfig: Add helper dependency on COMPILE_TEST' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).