From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S968139AbeEYUOi (ORCPT ); Fri, 25 May 2018 16:14:38 -0400 Received: from vern.gendns.com ([206.190.152.46]:50324 "EHLO vern.gendns.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S967951AbeEYUOg (ORCPT ); Fri, 25 May 2018 16:14:36 -0400 Subject: Re: [PATCH v2 3/4] dt-bindings: new binding for Ilitek ILI9341 display panels To: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org Cc: =?UTF-8?Q?Noralf_Tr=c3=b8nnes?= , Rob Herring , Mark Rutland , limor@ladyada.net, Nitin Patil , linux-kernel@vger.kernel.org References: <20180525193623.15533-1-david@lechnology.com> <20180525193623.15533-4-david@lechnology.com> From: David Lechner Message-ID: Date: Fri, 25 May 2018 15:14:33 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20180525193623.15533-4-david@lechnology.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - vern.gendns.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - lechnology.com X-Get-Message-Sender-Via: vern.gendns.com: authenticated_id: davidmain+lechnology.com/only user confirmed/virtual account not confirmed X-Authenticated-Sender: vern.gendns.com: davidmain@lechnology.com X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/25/2018 02:36 PM, David Lechner wrote: > This adds a new binding for Ilitek ILI9341 display panels. It includes > a compatible string for one display (more can be added in the future). > > The vendor prefix "noname" is used because the vendor is not known. Looks like I forgot to update "noname" to "adafruit" in the commit message. Patch is as intended though. > The YX240QV29-T panel[1] is found, for example, in an Adafruit breakout > board[2] and in Mindsensors' PiStorms[3]. > > [1]: https://cdn-learn.adafruit.com/assets/assets/000/046/879/original/SPEC-YX240QV29-T_Rev.A__1_.pdf > [2]: https://www.adafruit.com/product/2478 > [3]: http://www.mindsensors.com/stem-with-robotics/13-pistorms-v2-base-kit-raspberry-pi-brain-for-lego-robot > > Signed-off-by: David Lechner > --- > .../bindings/display/ilitek,ili9341.txt | 27 +++++++++++++++++++ > 1 file changed, 27 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/ilitek,ili9341.txt > > diff --git a/Documentation/devicetree/bindings/display/ilitek,ili9341.txt b/Documentation/devicetree/bindings/display/ilitek,ili9341.txt > new file mode 100644 > index 000000000000..169b32e4ee4e > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/ilitek,ili9341.txt > @@ -0,0 +1,27 @@ > +Ilitek ILI9341 display panels > + > +This binding is for display panels using an Ilitek ILI9341 controller in SPI > +mode. > + > +Required properties: > +- compatible: "adafruit,yx240qv29", "ilitek,ili9341" > +- dc-gpios: D/C pin > +- reset-gpios: Reset pin > + > +The node for this driver must be a child node of a SPI controller, hence > +all mandatory properties described in ../spi/spi-bus.txt must be specified. > + > +Optional properties: > +- rotation: panel rotation in degrees counter clockwise (0,90,180,270) > +- backlight: phandle of the backlight device attached to the panel > + > +Example: > + display@0{ > + compatible = "adafruit,yx240qv29", "ilitek,ili9341"; > + reg = <0>; > + spi-max-frequency = <32000000>; > + dc-gpios = <&gpio0 9 GPIO_ACTIVE_HIGH>; > + reset-gpios = <&gpio0 8 GPIO_ACTIVE_HIGH>; > + rotation = <270>; > + backlight = <&backlight>; > + }; >