LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Dirk van der Merwe <dirk.vandermerwe@netronome.com>
To: Baoquan He <bhe@redhat.com>, Dave Young <dyoung@redhat.com>,
j-nomura@ce.jp.nec.com
Cc: Borislav Petkov <bp@alien8.de>,
kasong@redhat.com, fanc.fnst@cn.fujitsu.com, x86@kernel.org,
kexec@lists.infradead.org, linux-kernel@vger.kernel.org,
hpa@zytor.com, tglx@linutronix.de
Subject: Re: [PATCH v6 1/2] x86/kexec: Build identity mapping for EFI systab and ACPI tables
Date: Tue, 21 May 2019 14:53:52 -0700 [thread overview]
Message-ID: <c640061a-a7c5-5bc3-87b6-0ee7af5a4b43@netronome.com> (raw)
In-Reply-To: <20190514033338.GA6612@MiWiFi-R3L-srv>
On 5/13/19 8:33 PM, Baoquan He wrote:
> On 05/14/19 at 11:22am, Dave Young wrote:
>> On 05/13/19 at 04:06pm, Baoquan He wrote:
>>> Hi Dave,
>>>
>>> On 05/13/19 at 09:50am, Borislav Petkov wrote:
>>>> On Mon, May 13, 2019 at 03:32:54PM +0800, Baoquan He wrote:
>>>>> This is a critical bug which breaks memory hotplug,
>>>> Please concentrate and stop the blabla:
>>>>
>>>> 36f0c423552d ("x86/boot: Disable RSDP parsing temporarily")
>>>>
>>>> already explains what the deal is. This code was *purposefully* disabled
>>>> because we ran out of time and it broke a couple of machines. Don't make
>>> I remember your machine is the one on whihc the issue is reported. Could
>>> you also test it and confirm if these all things found ealier are
>>> cleared out?
>>>
>> I did some tests on the laptop, thing is:
>> 1. apply the 3 patches (two you posted + Boris's revert commit 52b922c3d49c)
>> on latest Linus master branch, everything works fine.
>>
>> 2. build and test the tip/next-merge-window branch, kernel hangs early
>> without output, (both 1st boot and kexec boot)
> Thanks, Dave.
>
> Yeah, I also tested on a HP machine, problem reprodued on the current
> master branch when revert commit 52b922c3d49c.
>
> Then apply these two patches, problem solved.
>
> Tried boris's next-merge-window branch too, kexec works very well.
>
> Dirk, Junichi, feel free to add your test result if you have time.
I tested this with the patches (plus revert of the workaround) applied
against stable 5.1 and it works fine for me there. Thanks!
Where can I find the next-merge-window tree?
I can test against that too.
Best regards
Dirk
next prev parent reply other threads:[~2019-05-21 21:55 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-24 9:29 [PATCH v5 0/2] x86/boot: Use efi_setup_data for searching RSDP on kexec-ed kernel Baoquan He
2019-04-24 9:29 ` [PATCH v5 1/2] x86/kexec: Build identity mapping for EFI systab and ACPI tables Baoquan He
2019-04-27 16:11 ` Borislav Petkov
2019-04-28 5:41 ` Baoquan He
2019-04-29 12:50 ` Borislav Petkov
2019-04-29 0:23 ` [PATCH v6 " Baoquan He
2019-04-29 13:55 ` Borislav Petkov
2019-04-29 14:16 ` Baoquan He
2019-05-13 1:43 ` Baoquan He
2019-05-13 7:07 ` Borislav Petkov
2019-05-13 7:32 ` Baoquan He
2019-05-13 7:50 ` Borislav Petkov
2019-05-13 8:02 ` Baoquan He
2019-05-15 5:17 ` Junichi Nomura
2019-05-15 6:58 ` Borislav Petkov
2019-05-15 7:09 ` Junichi Nomura
2019-05-21 9:02 ` Kairui Song
2019-05-21 10:43 ` Junichi Nomura
2019-05-21 18:09 ` Borislav Petkov
2019-05-28 2:49 ` Kairui Song
2019-06-06 19:20 ` Borislav Petkov
2019-05-13 8:06 ` Baoquan He
2019-05-14 3:22 ` Dave Young
2019-05-14 3:33 ` Baoquan He
2019-05-21 21:53 ` Dirk van der Merwe [this message]
2019-05-21 23:04 ` Borislav Petkov
2019-05-14 8:48 ` Dave Young
2019-05-14 11:18 ` Kairui Song
2019-05-14 11:38 ` Peter Zijlstra
2019-05-14 12:58 ` Dave Young
2019-05-14 13:54 ` Peter Zijlstra
2019-05-14 14:09 ` Ingo Molnar
2019-05-15 1:08 ` Dave Young
2019-05-15 6:43 ` Junichi Nomura
2019-05-17 13:41 ` Borislav Petkov
2019-05-17 13:50 ` [PATCH] x86/boot: Call get_rsdp_addr() after console_init() Borislav Petkov
2019-05-21 9:28 ` Baoquan He
2019-06-06 19:22 ` [tip:x86/boot] x86/kexec: Add the EFI system tables and ACPI tables to the ident map tip-bot for Kairui Song
2019-04-24 9:29 ` [PATCH v5 2/2] x86/boot: Use efi_setup_data for searching RSDP on kexec-ed kernels Baoquan He
2019-04-24 9:33 ` Baoquan He
2019-04-24 9:38 ` [PATCH v5 0/2] x86/boot: Use efi_setup_data for searching RSDP on kexec-ed kernel Borislav Petkov
2019-04-24 10:00 ` Baoquan He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c640061a-a7c5-5bc3-87b6-0ee7af5a4b43@netronome.com \
--to=dirk.vandermerwe@netronome.com \
--cc=bhe@redhat.com \
--cc=bp@alien8.de \
--cc=dyoung@redhat.com \
--cc=fanc.fnst@cn.fujitsu.com \
--cc=hpa@zytor.com \
--cc=j-nomura@ce.jp.nec.com \
--cc=kasong@redhat.com \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--subject='Re: [PATCH v6 1/2] x86/kexec: Build identity mapping for EFI systab and ACPI tables' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).