LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Jongsung Kim <neidhard.kim@lge.com>
To: Guenter Roeck <linux@roeck-us.net>,
	Viresh Kumar <viresh.kumar@linaro.org>,
	Wim Van Sebroeck <wim@iguana.be>,
	linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Chanho Min <chanho.min@lge.com>
Subject: Re: [PATCH] watchdog: sp805: add restart handler
Date: Wed, 2 May 2018 16:55:06 +0900	[thread overview]
Message-ID: <c8502372-da23-f113-6cbc-78ef5683c28b@lge.com> (raw)
In-Reply-To: <452a2320-c297-2bd2-2e98-0b71a077c065@roeck-us.net>

On 04/30/2018 08:18 PM, Guenter Roeck wrote:
> On 04/29/2018 11:44 PM, Jongsung Kim wrote:
>> Add restart handler for SP805 watchdog so that the driver can be
>> used to reboot the system.
>>
>> Signed-off-by: Jongsung Kim <neidhard.kim@lge.com>
>> ---
>>   drivers/watchdog/sp805_wdt.c | 19 +++++++++++++++++++
>>   1 file changed, 19 insertions(+)
>>
>> diff --git a/drivers/watchdog/sp805_wdt.c b/drivers/watchdog/sp805_wdt.c
>> index 01d816251302..01f7b6c29f92 100644
>> --- a/drivers/watchdog/sp805_wdt.c
>> +++ b/drivers/watchdog/sp805_wdt.c
>> @@ -23,6 +23,7 @@
>>   #include <linux/module.h>
>>   #include <linux/moduleparam.h>
>>   #include <linux/pm.h>
>> +#include <linux/reboot.h>
>>   #include <linux/slab.h>
>>   #include <linux/spinlock.h>
>>   #include <linux/types.h>
>> @@ -67,6 +68,7 @@ struct sp805_wdt {
>>       struct clk            *clk;
>>       struct amba_device        *adev;
>>       unsigned int            load_val;
>> +    struct notifier_block        restart;
>>   };
>>     static bool nowayout = WATCHDOG_NOWAYOUT;
>> @@ -200,6 +202,18 @@ static const struct watchdog_ops wdt_ops = {
>>       .get_timeleft    = wdt_timeleft,
>>   };
>>   +static int
>> +wdt_restart(struct notifier_block *this, unsigned long mode, void *cmd)
>> +{
>> +    struct sp805_wdt *wdt = container_of(this, struct sp805_wdt, restart);
>> +
>> +    writel_relaxed(0, wdt->base + WDTCONTROL);
>> +    writel_relaxed(0, wdt->base + WDTLOAD);
>> +    writel_relaxed(INT_ENABLE | RESET_ENABLE, wdt->base + WDTCONTROL);
>> +
>> +    return 0;
>> +}
>> +
>>   static int
>>   sp805_wdt_probe(struct amba_device *adev, const struct amba_id *id)
>>   {
>> @@ -241,6 +255,10 @@ sp805_wdt_probe(struct amba_device *adev, const struct amba_id *id)
>>       }
>>       amba_set_drvdata(adev, wdt);
>>   +    wdt->restart.notifier_call = wdt_restart;
>> +    wdt->restart.priority = 128;
>> +    register_restart_handler(&wdt->restart);
>> +
>
> Why not use the watchdog core ?

Thank you for pointing this. I didn't noticed core changes about restart function because I'm still using old v4.4.xx..

>
> Guenter
>
>>       dev_info(&adev->dev, "registration successful\n");
>>       return 0;
>>   @@ -253,6 +271,7 @@ static int sp805_wdt_remove(struct amba_device *adev)
>>   {
>>       struct sp805_wdt *wdt = amba_get_drvdata(adev);
>>   +    unregister_restart_handler(&wdt->restart);
>>       watchdog_unregister_device(&wdt->wdd);
>>       watchdog_set_drvdata(&wdt->wdd, NULL);
>>  
>
>

      reply	other threads:[~2018-05-02  7:55 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-30  6:44 Jongsung Kim
2018-04-30 11:18 ` Guenter Roeck
2018-05-02  7:55   ` Jongsung Kim [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c8502372-da23-f113-6cbc-78ef5683c28b@lge.com \
    --to=neidhard.kim@lge.com \
    --cc=chanho.min@lge.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=viresh.kumar@linaro.org \
    --cc=wim@iguana.be \
    --subject='Re: [PATCH] watchdog: sp805: add restart handler' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).