From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20E29C48BE4 for ; Thu, 27 Jun 2019 19:19:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0619F208CB for ; Thu, 27 Jun 2019 19:19:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726574AbfF0TT5 (ORCPT ); Thu, 27 Jun 2019 15:19:57 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:34538 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726384AbfF0TT5 (ORCPT ); Thu, 27 Jun 2019 15:19:57 -0400 Received: from pps.filterd (m0098420.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x5RJHSXo191564 for ; Thu, 27 Jun 2019 15:19:55 -0400 Received: from e35.co.us.ibm.com (e35.co.us.ibm.com [32.97.110.153]) by mx0b-001b2d01.pphosted.com with ESMTP id 2td0ks12pc-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 27 Jun 2019 15:19:55 -0400 Received: from localhost by e35.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 27 Jun 2019 20:19:54 +0100 Received: from b03cxnp08027.gho.boulder.ibm.com (9.17.130.19) by e35.co.us.ibm.com (192.168.1.135) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Thu, 27 Jun 2019 20:19:50 +0100 Received: from b03ledav002.gho.boulder.ibm.com (b03ledav002.gho.boulder.ibm.com [9.17.130.233]) by b03cxnp08027.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x5RJJnLr61145392 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 27 Jun 2019 19:19:50 GMT Received: from b03ledav002.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id DB5A9136053; Thu, 27 Jun 2019 19:19:49 +0000 (GMT) Received: from b03ledav002.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id B900213604F; Thu, 27 Jun 2019 19:19:48 +0000 (GMT) Received: from [9.85.237.135] (unknown [9.85.237.135]) by b03ledav002.gho.boulder.ibm.com (Postfix) with ESMTP; Thu, 27 Jun 2019 19:19:48 +0000 (GMT) Subject: Re: [PATCH v3 1/8] dt-bindings: soc: Add Aspeed XDMA engine binding documentation To: Andrew Jeffery , linux-aspeed@lists.ozlabs.org Cc: linux-kernel@vger.kernel.org, Arnd Bergmann , Rob Herring , mark.rutland@arm.com, devicetree@vger.kernel.org, Joel Stanley References: <1559153408-31190-1-git-send-email-eajames@linux.ibm.com> <1559153408-31190-2-git-send-email-eajames@linux.ibm.com> <58b74556-cbf0-4da2-9392-4c4ac40ad760@www.fastmail.com> From: Eddie James Date: Thu, 27 Jun 2019 14:19:47 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <58b74556-cbf0-4da2-9392-4c4ac40ad760@www.fastmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-TM-AS-GCONF: 00 x-cbid: 19062719-0012-0000-0000-00001749ABD0 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00011342; HX=3.00000242; KW=3.00000007; PH=3.00000004; SC=3.00000286; SDB=6.01224131; UDB=6.00644264; IPR=6.01005319; MB=3.00027493; MTD=3.00000008; XFM=3.00000015; UTC=2019-06-27 19:19:53 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19062719-0013-0000-0000-000057DB5727 Message-Id: X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-06-27_13:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1906270220 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/30/19 12:30 AM, Andrew Jeffery wrote: > > On Thu, 30 May 2019, at 03:40, Eddie James wrote: >> Document the bindings. >> >> Signed-off-by: Eddie James >> --- >> .../devicetree/bindings/soc/aspeed/xdma.txt | 23 ++++++++++++++++++++++ >> 1 file changed, 23 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/soc/aspeed/xdma.txt >> >> diff --git a/Documentation/devicetree/bindings/soc/aspeed/xdma.txt >> b/Documentation/devicetree/bindings/soc/aspeed/xdma.txt >> new file mode 100644 >> index 0000000..85e82ea >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/soc/aspeed/xdma.txt >> @@ -0,0 +1,23 @@ >> +* Device tree bindings for the Aspeed XDMA Engine >> + >> +The XDMA Engine embedded in the AST2500 SOC can perform automatic DMA >> +operations over PCI between the AST2500 (acting as a BMC) and a host >> processor. >> + >> +Required properties: >> + >> + - compatible "aspeed,ast2500-xdma" >> + - reg contains the offset and length of the memory region >> + assigned to the XDMA registers >> + - resets reset specifier for the syscon reset associated with >> + the XDMA engine >> + - interrupts the interrupt associated with the XDMA engine on this >> + platform > The indentation is quite distracting. If you rev the series can you fix it? I think the diff is throwing it off; it all lines up when applied. Thanks, Eddie > > Otherwise, > > Reviewed-by: Andrew Jeffery > >> + >> +Example: >> + >> + xdma@1e6e7000 { >> + compatible = "aspeed,ast2500-xdma"; >> + reg = <0x1e6e7000 0x100>; >> + resets = <&syscon ASPEED_RESET_XDMA>; >> + interrupts = <6>; >> + }; >> -- >> 1.8.3.1 >> >>