LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Guru Das Srinagesh <gurus@codeaurora.org>
To: linux-pwm@vger.kernel.org
Cc: "Thierry Reding" <thierry.reding@gmail.com>,
	"Uwe Kleine-König" <uwe@kleine-koenig.org>,
	"Subbaraman Narayanamurthy" <subbaram@codeaurora.org>,
	linux-kernel@vger.kernel.org,
	"Guru Das Srinagesh" <gurus@codeaurora.org>
Subject: [PATCH v8 12/12] pwm: core: Convert period and duty cycle to u64
Date: Tue, 10 Mar 2020 18:41:21 -0700	[thread overview]
Message-ID: <cc930f5601d2ad3b42a8535548908a1499530e29.1583889178.git.gurus@codeaurora.org> (raw)
In-Reply-To: <cover.1583889178.git.gurus@codeaurora.org>
In-Reply-To: <cover.1583889178.git.gurus@codeaurora.org>

Because period and duty cycle are defined as ints with units of
nanoseconds, the maximum time duration that can be set is limited to
~2.147 seconds. Change their definitions to u64 in the structs of the
PWM framework so that higher durations may be set.

Signed-off-by: Guru Das Srinagesh <gurus@codeaurora.org>
---
 drivers/pwm/core.c  |  4 ++--
 drivers/pwm/sysfs.c |  8 ++++----
 include/linux/pwm.h | 12 ++++++------
 3 files changed, 12 insertions(+), 12 deletions(-)

diff --git a/drivers/pwm/core.c b/drivers/pwm/core.c
index 5a7f659..81aa3c2 100644
--- a/drivers/pwm/core.c
+++ b/drivers/pwm/core.c
@@ -1163,8 +1163,8 @@ static void pwm_dbg_show(struct pwm_chip *chip, struct seq_file *s)
 		if (state.enabled)
 			seq_puts(s, " enabled");
 
-		seq_printf(s, " period: %u ns", state.period);
-		seq_printf(s, " duty: %u ns", state.duty_cycle);
+		seq_printf(s, " period: %llu ns", state.period);
+		seq_printf(s, " duty: %llu ns", state.duty_cycle);
 		seq_printf(s, " polarity: %s",
 			   state.polarity ? "inverse" : "normal");
 
diff --git a/drivers/pwm/sysfs.c b/drivers/pwm/sysfs.c
index 2389b86..449dbc0 100644
--- a/drivers/pwm/sysfs.c
+++ b/drivers/pwm/sysfs.c
@@ -42,7 +42,7 @@ static ssize_t period_show(struct device *child,
 
 	pwm_get_state(pwm, &state);
 
-	return sprintf(buf, "%u\n", state.period);
+	return sprintf(buf, "%llu\n", state.period);
 }
 
 static ssize_t period_store(struct device *child,
@@ -52,10 +52,10 @@ static ssize_t period_store(struct device *child,
 	struct pwm_export *export = child_to_pwm_export(child);
 	struct pwm_device *pwm = export->pwm;
 	struct pwm_state state;
-	unsigned int val;
+	u64 val;
 	int ret;
 
-	ret = kstrtouint(buf, 0, &val);
+	ret = kstrtou64(buf, 0, &val);
 	if (ret)
 		return ret;
 
@@ -77,7 +77,7 @@ static ssize_t duty_cycle_show(struct device *child,
 
 	pwm_get_state(pwm, &state);
 
-	return sprintf(buf, "%u\n", state.duty_cycle);
+	return sprintf(buf, "%llu\n", state.duty_cycle);
 }
 
 static ssize_t duty_cycle_store(struct device *child,
diff --git a/include/linux/pwm.h b/include/linux/pwm.h
index 0ef808d..b53f13d 100644
--- a/include/linux/pwm.h
+++ b/include/linux/pwm.h
@@ -39,7 +39,7 @@ enum pwm_polarity {
  * current PWM hardware state.
  */
 struct pwm_args {
-	unsigned int period;
+	u64 period;
 	enum pwm_polarity polarity;
 };
 
@@ -56,8 +56,8 @@ enum {
  * @enabled: PWM enabled status
  */
 struct pwm_state {
-	unsigned int period;
-	unsigned int duty_cycle;
+	u64 period;
+	u64 duty_cycle;
 	enum pwm_polarity polarity;
 	bool enabled;
 };
@@ -105,13 +105,13 @@ static inline bool pwm_is_enabled(const struct pwm_device *pwm)
 	return state.enabled;
 }
 
-static inline void pwm_set_period(struct pwm_device *pwm, unsigned int period)
+static inline void pwm_set_period(struct pwm_device *pwm, u64 period)
 {
 	if (pwm)
 		pwm->state.period = period;
 }
 
-static inline unsigned int pwm_get_period(const struct pwm_device *pwm)
+static inline u64 pwm_get_period(const struct pwm_device *pwm)
 {
 	struct pwm_state state;
 
@@ -126,7 +126,7 @@ static inline void pwm_set_duty_cycle(struct pwm_device *pwm, unsigned int duty)
 		pwm->state.duty_cycle = duty;
 }
 
-static inline unsigned int pwm_get_duty_cycle(const struct pwm_device *pwm)
+static inline u64 pwm_get_duty_cycle(const struct pwm_device *pwm)
 {
 	struct pwm_state state;
 
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project


      parent reply	other threads:[~2020-03-11  1:41 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <cover.1583889178.git.gurus@codeaurora.org>
2020-03-11  1:41 ` [PATCH v8 01/12] clk: pwm: Use 64-bit division function Guru Das Srinagesh
2020-03-11 16:58   ` David Laight
2020-03-12  2:09     ` Guru Das Srinagesh
2020-03-12  9:14       ` David Laight
2020-03-12 19:09         ` Guru Das Srinagesh
2020-03-19 20:53           ` Guru Das Srinagesh
2020-04-09  2:40         ` Guru Das Srinagesh
2020-03-11  1:41 ` [PATCH v8 02/12] drm/i915: Use 64-bit division macro Guru Das Srinagesh
2020-03-11  1:41 ` [PATCH v8 03/12] hwmon: pwm-fan: " Guru Das Srinagesh
2020-03-11 15:08   ` Guenter Roeck
2020-03-11  1:41 ` [PATCH v8 04/12] ir-rx51: " Guru Das Srinagesh
2020-03-11  2:11   ` Sean Young
2020-03-11  1:41 ` [PATCH v8 05/12] pwm: clps711x: " Guru Das Srinagesh
2020-03-11  1:41 ` [PATCH v8 06/12] pwm: pwm-imx-tpm: " Guru Das Srinagesh
2020-03-11  1:41 ` [PATCH v8 07/12] pwm: imx27: Use 64-bit division macro and function Guru Das Srinagesh
2020-03-11  1:41 ` [PATCH v8 08/12] pwm: sifive: Use 64-bit division macro Guru Das Srinagesh
2020-03-11  1:41 ` [PATCH v8 09/12] pwm: stm32-lp: Use %llu format specifier for period Guru Das Srinagesh
2020-03-11  1:41 ` [PATCH v8 10/12] pwm: sun4i: Use 64-bit division function Guru Das Srinagesh
2020-03-11  3:35   ` Chen-Yu Tsai
2020-03-11  1:41 ` [PATCH v8 11/12] backlight: pwm_bl: " Guru Das Srinagesh
2020-03-11 10:05   ` Daniel Thompson
2020-03-11  1:41 ` Guru Das Srinagesh [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cc930f5601d2ad3b42a8535548908a1499530e29.1583889178.git.gurus@codeaurora.org \
    --to=gurus@codeaurora.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pwm@vger.kernel.org \
    --cc=subbaram@codeaurora.org \
    --cc=thierry.reding@gmail.com \
    --cc=uwe@kleine-koenig.org \
    --subject='Re: [PATCH v8 12/12] pwm: core: Convert period and duty cycle to u64' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).