From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752514AbeDSLZd (ORCPT ); Thu, 19 Apr 2018 07:25:33 -0400 Received: from mx2.suse.de ([195.135.220.15]:46229 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752337AbeDSLZ3 (ORCPT ); Thu, 19 Apr 2018 07:25:29 -0400 Subject: Re: [PATCH] Input: xen-kbdfront - allow better run-time configuration To: Oleksandr Andrushchenko , xen-devel@lists.xenproject.org, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, dmitry.torokhov@gmail.com, lyan@suse.com, boris.ostrovsky@oracle.com Cc: andrii_chepurnyi@epam.com, Oleksandr Andrushchenko References: <20180418150445.9805-1-andr2000@gmail.com> From: Juergen Gross Message-ID: Date: Thu, 19 Apr 2018 13:25:25 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20180418150445.9805-1-andr2000@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 18/04/18 17:04, Oleksandr Andrushchenko wrote: > From: Oleksandr Andrushchenko > > It is now only possible to control if multi-touch virtual device > is created or not (via the corresponding XenStore entries), > but keyboard and pointer devices are always created. Why don't you want to go that route for keyboard and mouse, too? Or does this really make no sense? > In some cases this is not desirable. For example, if virtual > keyboard device is exposed to Android then the latter won't > automatically show on-screen keyboard as it expects that a > physical keyboard device can be used for typing. > > Make it possible to configure which virtual devices are created > with module parameters: > - no_ptr_dev=1 if no pointer device needs to be created > - no_kbd_dev=1 if no keyboard device needs to be created > Keep old behavior by default. > > Signed-off-by: Oleksandr Andrushchenko > Suggested-by: Andrii Chepurnyi > Tested-by: Andrii Chepurnyi > --- > drivers/input/misc/xen-kbdfront.c | 159 +++++++++++++++++------------- > 1 file changed, 92 insertions(+), 67 deletions(-) > > diff --git a/drivers/input/misc/xen-kbdfront.c b/drivers/input/misc/xen-kbdfront.c > index d91f3b1c5375..a3306aad40b0 100644 > --- a/drivers/input/misc/xen-kbdfront.c > +++ b/drivers/input/misc/xen-kbdfront.c > @@ -51,6 +51,16 @@ module_param_array(ptr_size, int, NULL, 0444); > MODULE_PARM_DESC(ptr_size, > "Pointing device width, height in pixels (default 800,600)"); > > +static unsigned int no_ptr_dev; > +module_param(no_ptr_dev, uint, 0); Use type invbool instead? > +MODULE_PARM_DESC(no_ptr_dev, > + "If set then no virtual pointing device exposed to the guest"); > + > +static unsigned int no_kbd_dev; > +module_param(no_kbd_dev, uint, 0); invbool? Juergen