LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Aaron Ma <aaron.ma@canonical.com>
To: Benjamin Tissoires <benjamin.tissoires@redhat.com>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: "open list:HID CORE LAYER" <linux-input@vger.kernel.org>,
	lkml <linux-kernel@vger.kernel.org>,
	Christopher Heiny <Cheiny@synaptics.com>,
	Andrew Duggan <aduggan@synaptics.com>,
	Hans de Goede <hdegoede@redhat.com>
Subject: Re: [PATCH 2/2] Input: synaptics - remove X240 from the topbuttonpad list
Date: Thu, 23 May 2019 13:02:09 +0800	[thread overview]
Message-ID: <cdcc48a7-bd52-5ea4-6712-7f77604fe549@canonical.com> (raw)
In-Reply-To: <CAO-hwJLXB8Qec9Yhz0y6WgvEpE6KHk_53g4VtPGj9mfvMzk4dg@mail.gmail.com>



On 5/21/19 2:49 PM, Benjamin Tissoires wrote:
> A quick google image search showed that the X240 had 2 versions: one
> with the top software buttons, one without.
> 
> And this definitively rings a bell. I am sure we asked Lenovo and
> Synaptics to change the PnPID when they would do such a change, but
> they "forgot" during the *40 series refresh.
> We have code in place to fix the reported ranges of the coordinates,
> and we had to check against the board id (see min_max_pnpid_table[] in
> synaptics.c).
> Unfortunately, X240 (LEN0035) is not part of this table, so I don't
> know which refresh of the board ID has implemented the non top
> software buttons.

After double confirm from Lenovo, looks like they mixed up with
touchpads on X240/X240s.

For now only one user reported this LEN0035 doesn't work on SMBus mode.
module parameter can be a workaround.
Maybe some touchpads with software top buttons are working well on
SMBus. Let's keep eyes on this issue for now.

Regards,
Aaron

> 
> Cheers,
> Benjamin

  reply	other threads:[~2019-05-23  5:02 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-19  7:27 [PATCH 1/2] Input: elantech - enable middle button support on 2 ThinkPads Aaron Ma
2019-05-19  7:27 ` [PATCH 2/2] Input: synaptics - remove X240 from the topbuttonpad list Aaron Ma
2019-05-21  5:08   ` Dmitry Torokhov
2019-05-21  6:49     ` Benjamin Tissoires
2019-05-23  5:02       ` Aaron Ma [this message]
2019-05-21  5:10 ` [PATCH 1/2] Input: elantech - enable middle button support on 2 ThinkPads Dmitry Torokhov
2019-05-21  6:43   ` Benjamin Tissoires

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cdcc48a7-bd52-5ea4-6712-7f77604fe549@canonical.com \
    --to=aaron.ma@canonical.com \
    --cc=Cheiny@synaptics.com \
    --cc=aduggan@synaptics.com \
    --cc=benjamin.tissoires@redhat.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=hdegoede@redhat.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: [PATCH 2/2] Input: synaptics - remove X240 from the topbuttonpad list' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).