LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Santosh Shilimkar <santosh.shilimkar@ti.com>
To: Will Deacon <will.deacon@arm.com>,
	linux-kernel@vger.kernel.org, oprofile-list@lists.sf.net
Cc: Robert Richter <robert.richter@amd.com>
Subject: RE: [PATCH] oprofile: add SMP barriers for hrtimer hotplug code
Date: Mon, 31 Jan 2011 21:11:53 +0530	[thread overview]
Message-ID: <ce22f38374d26d324bb8e57276eb46f0@mail.gmail.com> (raw)
In-Reply-To: <1296486501-25848-1-git-send-email-will.deacon@arm.com>

> -----Original Message-----
> From: Will Deacon [mailto:will.deacon@arm.com]
> Sent: Monday, January 31, 2011 8:38 PM
> To: linux-kernel@vger.kernel.org; oprofile-list@lists.sf.net
> Cc: Will Deacon; Santosh Shilimkar; Robert Richter
> Subject: [PATCH] oprofile: add SMP barriers for hrtimer hotplug code
>
> OProfile uses a CPU notifier to start and stop any hrtimers when
> CPUs change
> between ONLINE and DEAD. A static int ctr_running is used to keep
> track of
> the counter state.
>
> This can lead to problems where writes to the state variable are re-
> ordered
> with repect to reads of the variable occurring on other CPUs,
> meaning that
> __oprofile_hrtimer_start may read ctr_running as 0 and not
> initialise the
> hrtimer. Potential deadlock can occur in __oprofile_hrtimer_stop
> because
> lock_hrtimer_base will poll until timer->base != NULL, which will
> never
> happen.
>
> This patch adds smp_mb()s to ensure that ctr_running mirrors the
> correct
> counter state.
>
> Cc: Santosh Shilimkar <santosh.shilimkar@ti.com>
> Cc: Robert Richter <robert.richter@amd.com>
> Signed-off-by: Will Deacon <will.deacon@arm.com>
> ---
>  drivers/oprofile/timer_int.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/oprofile/timer_int.c
> b/drivers/oprofile/timer_int.c
> index 0107251..38c1e1b 100644
> --- a/drivers/oprofile/timer_int.c
> +++ b/drivers/oprofile/timer_int.c
> @@ -48,6 +48,7 @@ static int oprofile_hrtimer_start(void)
>  {
>  	get_online_cpus();
>  	ctr_running = 1;
> +	smp_mb();
Is smp_wmb() more appropriate ?

>  	on_each_cpu(__oprofile_hrtimer_start, NULL, 1);
>  	put_online_cpus();
>  	return 0;
> @@ -70,6 +71,7 @@ static void oprofile_hrtimer_stop(void)
>  	get_online_cpus();
>  	for_each_online_cpu(cpu)
>  		__oprofile_hrtimer_stop(cpu);
> +	smp_mb();
>  	ctr_running = 0;
>  	put_online_cpus();
>  }
> --
Otherwise patch is fine.
Acked-by: Santosh Shilimkar <santosh.shilimkar@ti.com>

  reply	other threads:[~2011-01-31 15:42 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-31 15:08 Will Deacon
2011-01-31 15:41 ` Santosh Shilimkar [this message]
2011-01-31 17:24   ` Will Deacon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ce22f38374d26d324bb8e57276eb46f0@mail.gmail.com \
    --to=santosh.shilimkar@ti.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oprofile-list@lists.sf.net \
    --cc=robert.richter@amd.com \
    --cc=will.deacon@arm.com \
    --subject='RE: [PATCH] oprofile: add SMP barriers for hrtimer hotplug code' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).