LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Amelie DELAUNAY <amelie.delaunay@st.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Lee Jones <lee.jones@linaro.org>,
	Alexandre TORGUE <alexandre.torgue@st.com>,
	Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"linux-stm32@st-md-mailman.stormreply.com" 
	<linux-stm32@st-md-mailman.stormreply.com>,
	"kbuild-all@01.org" <kbuild-all@01.org>,
	Randy Dunlap <rdunlap@infradead.org>
Subject: Re: [PATCH] pinctrl: stmfx: Fix compile issue when CONFIG_OF_GPIO is not defined
Date: Fri, 24 May 2019 07:27:57 +0000	[thread overview]
Message-ID: <ce77d35a-806c-b7af-975d-1b24e98f8723@st.com> (raw)
In-Reply-To: <CACRpkdZLbMJ5dKiL9J1x=PozBVH777kNNABZi-n0LxD0BOp8mw@mail.gmail.com>

On 5/23/19 9:18 PM, Linus Walleij wrote:
> On Thu, May 23, 2019 at 4:11 PM Amelie DELAUNAY <amelie.delaunay@st.com> wrote:
>> On 5/22/19 11:48 PM, Linus Walleij wrote:
>>> On Wed, May 22, 2019 at 11:21 AM Amelie DELAUNAY <amelie.delaunay@st.com> wrote:
>>>
>>>> ../drivers/pinctrl/pinctrl-stmfx.c:409:20: error:
>>>> ‘pinconf_generic_dt_node_to_map_pin’ undeclared here (not in a function)
>>>>      .dt_node_to_map = pinconf_generic_dt_node_to_map_pin,
>>>>
>>>> OF_GPIO depends on OF.
>>>>
>>>> So either
>>>>        depends on OF || (OF && COMPILE_TEST)
>>>> or
>>>>        depends on OF || (OF_GPIO && COMPILE_TEST)
>>>>
>>>> and
>>>>
>>>>        select OF_GPIO
>>>
>>> I would use just:
>>>
>>> depends on OF_GPIO
>>>
>>> Because OF_GPIO already depends on OF, and
>>> compile tests will not work without OF_GPIO which
>>> require OF so...
>>>
>>> Besides it is what most other GPIO drivers do.
>>>
>>> So just keep that one line and drop the rest.
>>>
>>> Yours,
>>> Linus Walleij
>>>
>>
>> Ok so I can get rid of COMPILE_TEST ?
>>          depends on I2C
>>          depends on OF_GPIO
>>          select GENERIC_PINCONF
>>          select GPIOLIB_IRQCHIP
>>          select MFD_STMFX
> 
> Yep just like that.
> 
>> Because I've no arch to balance COMPILE_TEST. Or maybe something like
>>          depends on OF_GPIO && (OF || COMPILE_TEST)
>> even if OF_GPIO && OF is redundant ?
> 
> COMPILE_TEST is just to make something available for testing
> on other architectures, such as testing ARM-specific drivers
> on x86.
> 
> With just OF_GPIO as dependency, it will be compile tested anyways
> because x86 allyesconfig will enable OF and OF_GPIO, and also
> all the STMFX drivers.
> 
> Yours,
> Linus Walleij
> 

Thanks Linus for this clarification!

Regards,
Amelie

      reply	other threads:[~2019-05-24  7:28 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-20  7:52 Amelie Delaunay
2019-05-22  0:22 ` Randy Dunlap
2019-05-22  5:48 ` Lee Jones
2019-05-22  8:08   ` Amelie DELAUNAY
2019-05-22  8:41     ` Lee Jones
2019-05-22  9:20       ` Amelie DELAUNAY
2019-05-22  9:30         ` Lee Jones
2019-05-22 21:48         ` Linus Walleij
2019-05-23 14:11           ` Amelie DELAUNAY
2019-05-23 19:18             ` Linus Walleij
2019-05-24  7:27               ` Amelie DELAUNAY [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ce77d35a-806c-b7af-975d-1b24e98f8723@st.com \
    --to=amelie.delaunay@st.com \
    --cc=alexandre.torgue@st.com \
    --cc=kbuild-all@01.org \
    --cc=lee.jones@linaro.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=rdunlap@infradead.org \
    --subject='Re: [PATCH] pinctrl: stmfx: Fix compile issue when CONFIG_OF_GPIO is not defined' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).