LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Larry Finger <Larry.Finger@lwfinger.net>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: LKML <linux-kernel@vger.kernel.org>, linux-staging@lists.linux.dev
Subject: Re: kernel BUG in new r8188eu
Date: Sun, 1 Aug 2021 15:15:52 -0500	[thread overview]
Message-ID: <cef19337-5ff3-c0cd-33ef-4f9990bcd4ec@lwfinger.net> (raw)
In-Reply-To: <YQY/tfJJdBVg/mwf@kroah.com>

On 8/1/21 1:31 AM, Greg Kroah-Hartman wrote:
> 
> I am worried that my "remove the wrapper" logic got something wrong
> here, so if you could test the revert of that, I would appreciate it.
> 
> I think I need to go buy one of these devices so I can test cleanups
> locally...

The bad commit was 9ff1cc4ef80e ("staging: r8188eu: remove rtw_buf_free() 
function").

Looking at it, the only difference between the original wrapper and the new code 
is that the wrapper zeros the len variable before the kfree() call, but making 
that change did not help. Reverting that patch restores the old behavior.

There are lots of these on Ebay from $2.47 up with free shipping!

Larry


  reply	other threads:[~2021-08-01 20:15 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-30 19:59 Larry Finger
2021-07-31  5:37 ` Greg Kroah-Hartman
2021-07-31 16:18   ` Larry Finger
2021-07-31 18:53     ` Fabio Aiuto
2021-07-31 21:54       ` Larry Finger
2021-08-01  6:31     ` Greg Kroah-Hartman
2021-08-01 20:15       ` Larry Finger [this message]
2021-08-02 10:36         ` Greg Kroah-Hartman
2021-08-02 11:45           ` Fabio M. De Francesco
2021-08-02 14:38             ` Greg Kroah-Hartman
2021-08-02 14:40             ` Larry Finger
2021-08-02 15:46               ` Greg Kroah-Hartman
2021-08-02 14:49           ` Larry Finger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cef19337-5ff3-c0cd-33ef-4f9990bcd4ec@lwfinger.net \
    --to=larry.finger@lwfinger.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --subject='Re: kernel BUG in new r8188eu' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).