From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932239AbeEWJ3B (ORCPT ); Wed, 23 May 2018 05:29:01 -0400 Received: from lelnx194.ext.ti.com ([198.47.27.80]:50964 "EHLO lelnx194.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932137AbeEWJ26 (ORCPT ); Wed, 23 May 2018 05:28:58 -0400 Subject: Re: [PATCH] drm/omap: dss: Use ERR_CAST instead of ERR_PTR(PTR_ERR()) To: =?UTF-8?Q?Hern=c3=a1n_Gonzalez?= CC: , , , References: <1526254581-4388-1-git-send-email-hernan@vanguardiasur.com.ar> From: Tomi Valkeinen Message-ID: Date: Wed, 23 May 2018 12:28:51 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <1526254581-4388-1-git-send-email-hernan@vanguardiasur.com.ar> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 8bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 14/05/18 02:36, Hernán Gonzalez wrote: > Use ERR_CAST inlined function instead of ERR_PTR(PTR_ERR(...)). > > drivers/gpu/drm/omapdrm/dss/dss.c:959:9-16: WARNING: ERR_CAST can be used with d > Generated by: scripts/coccinelle/api/err_cast.cocci > > Signed-off-by: Hernán Gonzalez > --- > drivers/gpu/drm/omapdrm/dss/dss.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/omapdrm/dss/dss.c b/drivers/gpu/drm/omapdrm/dss/dss.c > index 0b908e9..be043c8 100644 > --- a/drivers/gpu/drm/omapdrm/dss/dss.c > +++ b/drivers/gpu/drm/omapdrm/dss/dss.c > @@ -956,7 +956,7 @@ dss_debugfs_create_file(struct dss_device *dss, const char *name, > &dss_debug_fops); > if (IS_ERR(d)) { > kfree(entry); > - return ERR_PTR(PTR_ERR(d)); > + return ERR_CAST(d); > } > > entry->dentry = d; > Thanks, I've picked this up. Tomi -- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki