LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
To: alan@linux.intel.com, sakari.ailus@linux.intel.com,
mchehab@kernel.org, gregkh@linuxfoundation.org,
andriy.shevchenko@linux.intel.com, chen.chenchacha@foxmail.com,
keescook@chromium.org, arvind.yadav.cs@gmail.com
Cc: devel@driverdev.osuosl.org,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-media@vger.kernel.org
Subject: [PATCH 0/3] media: staging: atomisp:
Date: Fri, 11 May 2018 17:06:15 +0200 [thread overview]
Message-ID: <cover.1526048313.git.christophe.jaillet@wanadoo.fr> (raw)
These 3 patches fixes (at least I hope) some issues found in or around
'lm3554_probe()'.
Please review them carefully. I've only compile tested the changes and
I propose them because they sound logical to me.
The first one, return an error code instead of 0 if the call to an
initialisation function fails.
The 2nd one reorders own some label are reached in order to have a logical
flow (first error goes to last label, last error goes to first label)
The 3rd one fix the use 'media_entity_cleanup()'. If this one is correct,
some other drivers will need to be fixed the same way.
Christophe JAILLET (3):
media: staging: atomisp: Return an error code in case
of error in 'lm3554_probe()'
media: staging: atomisp: Fix an error handling path in
'lm3554_probe()'
media: staging: atomisp: Fix usage of 'media_entity_cleanup()'
.../media/atomisp/i2c/atomisp-lm3554.c | 20 +++++++++----------
1 file changed, 9 insertions(+), 11 deletions(-)
--
2.17.0
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next reply other threads:[~2018-05-11 15:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-11 15:06 Christophe JAILLET [this message]
2018-05-11 15:06 ` [PATCH 1/3] media: staging: atomisp: Return an error code in case of error in 'lm3554_probe()' Christophe JAILLET
2018-05-11 15:06 ` [PATCH 2/3] media: staging: atomisp: Fix an error handling path " Christophe JAILLET
2018-05-11 15:09 ` Julia Lawall
2018-05-11 15:31 ` Alan Cox
2018-05-11 15:06 ` [PATCH 3/3] media: staging: atomisp: Fix usage of 'media_entity_cleanup()' Christophe JAILLET
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1526048313.git.christophe.jaillet@wanadoo.fr \
--to=christophe.jaillet@wanadoo.fr \
--cc=alan@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arvind.yadav.cs@gmail.com \
--cc=chen.chenchacha@foxmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=keescook@chromium.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--subject='Re: [PATCH 0/3] media: staging: atomisp:' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).