LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Dmitry Torokhov" <dmitry.torokhov@gmail.com>
To: "Yoichi Yuasa" <yoichi_yuasa@tripeaks.co.jp>
Cc: linux-input@atrey.karlin.mff.cuni.cz, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Add Cobalt button interface driver support
Date: Fri, 16 Feb 2007 10:15:11 -0500	[thread overview]
Message-ID: <d120d5000702160715x6f64853y59abb8a22e7d164c@mail.gmail.com> (raw)
In-Reply-To: <200702160815.l1G8FEIr078415@mbox33.po.2iij.net>

On 2/16/07, Yoichi Yuasa <yoichi_yuasa@tripeaks.co.jp> wrote:
> +
> +static int cobalt_buttons_open(struct inode *inode, struct file *file)
> +{
> +       buttons_timer.expires = jiffies + msecs_to_jiffies(BUTTONS_POLL_INTERVAL);
> +       add_timer(&buttons_timer);
> +
> +       return nonseekable_open(inode, file);
> +
> +}

Hi,

I am sorry, I was not clear enough - when I was talking about adding
cobalt_buttons_open/close I was not asking you to add a misc device to
the driver. I was talking about setting up open() and close() methods
in input_dev structure. These methods are called by input core when
first (or last) user opens or closes one of input interfaces, such as
/dev/input/eventX, /dev/input/jsX, etc and so it is naturally to
start/stop polling device from these functions.

Does this make sense?

-- 
Dmitry

  reply	other threads:[~2007-02-16 15:15 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-16  3:36 Yoichi Yuasa
2007-02-16  4:09 ` Dmitry Torokhov
2007-02-16  8:15   ` Yoichi Yuasa
2007-02-16 15:15     ` Dmitry Torokhov [this message]
2007-02-16 16:22       ` Yoichi Yuasa
2007-04-04  4:01         ` Dmitry Torokhov
2007-04-05  5:02           ` Yoichi Yuasa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d120d5000702160715x6f64853y59abb8a22e7d164c@mail.gmail.com \
    --to=dmitry.torokhov@gmail.com \
    --cc=linux-input@atrey.karlin.mff.cuni.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=yoichi_yuasa@tripeaks.co.jp \
    --subject='Re: [PATCH] Add Cobalt button interface driver support' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).