LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Dmitry Torokhov" <dmitry.torokhov@gmail.com>
To: "Stephen Hemminger" <shemminger@linux-foundation.org>
Cc: "Len Brown" <lenb@kernel.org>,
	"Andrew Morton" <akpm@linux-foundation.org>,
	linux-input@atrey.karlin.mff.cuni.cz,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fujtisu application panel driver
Date: Mon, 2 Jul 2007 15:16:30 -0400	[thread overview]
Message-ID: <d120d5000707021216y1a3641b1rbc0c741e2d7d4e70@mail.gmail.com> (raw)
In-Reply-To: <20070702111724.43ee5b43@freepuppy.localdomain.hemminger.net>

Hi Stephen,

On 7/2/07, Stephen Hemminger <shemminger@linux-foundation.org> wrote:
> This driver supports the application buttons on some Fujitsu Lifebook laptops.
> These buttons are read via the SMBus, for more details see:
>        http://apanel.sourceforge.net/tech.php
> The buttons are handled as by the regular input system.
> Two models are detected now, but other Fujitsu laptop's have
> keys that may work similarly.
>
> It is based on the earlier apanel driver done by Jochen Eisenger, but
> with many changes.  The original driver used ioctl's and a separate
> user space program; this version hooks into the input subsystem so
> that the normal Gnome/KDE shortcuts work without any userspace
> changes.
>

Thank you very much for updating the patch. I have a couple of requests though:

1. LEDs shoud use the generic led subsystem instead of input layer. I
do not have plans of adding any more LED_XXX constants and I think
that adding any LEDs not directly relating to keyboard state was a
mistake.

2. It would be nice if driver supported changing its keymaps now that
we allow overriding default getkeycode() and setkeycode().

3. Do not aaccess input_dev->private directly. input_set_drvdata() and
input+_getdrvdata shoudl be used.

> +static int apanel_event(struct input_dev *dev, unsigned int type,
> +                       unsigned int code, int value)
> +{
> +       struct apanel *ap = dev->private;

Also I don't think the above is correct. I think you need the following here:

   struct input_polled_dev *polldev = input_get_drvdata(dev);
   struct apanal *ap = polldev->private;

4:
> +       ipdev->input->cdev.dev = &ap->client.dev;

Please change to "ipdev->input->dev.parent = &ap->client.dev;"

5:
> +       ipdev->input->private = ap;

polledev uses input->private for its own purposed, you need to use
ipdev->private.

Thank you.

-- 
Dmitry

  reply	other threads:[~2007-07-02 19:16 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-02 18:17 Stephen Hemminger
2007-07-02 19:16 ` Dmitry Torokhov [this message]
2007-09-03  8:58   ` Stephen Hemminger
2007-09-07 12:02     ` Pavel Machek
2007-09-12 11:38       ` [PATCH] Fujitsu application panel driver (rev3) Stephen Hemminger
2007-09-14  5:30         ` Dmitry Torokhov
2007-09-16 19:55           ` Stephen Hemminger
2007-09-16 20:22             ` Dmitry Torokhov
2007-10-23 19:55               ` [PATCH] Fujitsu application panel driver Stephen Hemminger
2007-10-24 23:03                 ` Andrew Morton
2007-10-25 20:19                   ` [PATCH] apanel: space savings Stephen Hemminger
2007-10-28  5:30                 ` [PATCH] Fujitsu application panel driver Dmitry Torokhov
2007-11-18 22:36                 ` Robert Gerlach
2007-11-19  4:43                   ` Stephen Hemminger
2007-11-19 12:50                     ` Robert Gerlach
2007-11-19 17:26                       ` Stephen Hemminger
2007-11-19 20:37                         ` Robert Gerlach
2007-11-19 23:19                       ` Stephen Hemminger
2007-12-19  9:04                         ` Robert Gerlach
2007-12-12 14:10                 ` Dmitry Torokhov
2007-12-12 22:21                   ` [PATCH] Fujitsu application panel led value Stephen Hemminger
2007-07-05  1:29 ` [PATCH] fujtisu application panel driver Jason Uhlenkott
2007-09-03  9:00   ` Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d120d5000707021216y1a3641b1rbc0c741e2d7d4e70@mail.gmail.com \
    --to=dmitry.torokhov@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=lenb@kernel.org \
    --cc=linux-input@atrey.karlin.mff.cuni.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=shemminger@linux-foundation.org \
    --subject='Re: [PATCH] fujtisu application panel driver' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).