LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Laura Abbott <labbott@redhat.com>
To: Nathan Chancellor <natechancellor@gmail.com>,
	devel@driverdev.osuosl.org, dri-devel@lists.freedesktop.org,
	linaro-mm-sig@lists.linaro.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Joe Perches <joe@perches.com>
Cc: "Todd Kjos" <tkjos@android.com>,
	"Arve Hjønnevåg" <arve@android.com>,
	"Martijn Coenen" <maco@android.com>,
	"Sumit Semwal" <sumit.semwal@linaro.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] staging: android: ion: Fix license identifier comment format
Date: Mon, 7 May 2018 06:37:52 -0700	[thread overview]
Message-ID: <d157b475-7893-3ab6-87a8-b6ce5aa13b4f@redhat.com> (raw)
In-Reply-To: <20180507011854.12627-1-natechancellor@gmail.com>

On 05/06/2018 06:18 PM, Nathan Chancellor wrote:
> checkpatch.pl complains these are invalid because the rules in
> Documentation/process/license-rules.rst state that C headers should
> have "/* */" style comments.
> 

The SPDX markings are special, but I don't see anything from a
quick read of the SPDX specification that says they have to use //.
I think this is going to generate a lot of possible noise so it
might be worth adjusting checkpatch.

Thanks,
Laura

> Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
> ---
>   drivers/staging/android/ion/ion.h  | 2 +-
>   drivers/staging/android/uapi/ion.h | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/android/ion/ion.h b/drivers/staging/android/ion/ion.h
> index ea0897812780..16cbd38a7160 100644
> --- a/drivers/staging/android/ion/ion.h
> +++ b/drivers/staging/android/ion/ion.h
> @@ -1,4 +1,4 @@
> -// SPDX-License-Identifier: GPL-2.0
> +/* SPDX-License-Identifier: GPL-2.0 */
>   /*
>    * drivers/staging/android/ion/ion.h
>    *
> diff --git a/drivers/staging/android/uapi/ion.h b/drivers/staging/android/uapi/ion.h
> index 825d3e95ccd3..5d7009884c13 100644
> --- a/drivers/staging/android/uapi/ion.h
> +++ b/drivers/staging/android/uapi/ion.h
> @@ -1,4 +1,4 @@
> -// SPDX-License-Identifier: GPL-2.0
> +/* SPDX-License-Identifier: GPL-2.0 */
>   /*
>    * drivers/staging/android/uapi/ion.h
>    *
> 

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

  parent reply	other threads:[~2018-05-07 13:37 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-07  1:18 Nathan Chancellor
2018-05-07  1:18 ` [PATCH 2/2] staging: android: ion: Remove unnecessary blank line Nathan Chancellor
2018-05-07 13:38   ` Laura Abbott
2018-05-07 13:37 ` Laura Abbott [this message]
2018-05-07 14:40   ` [PATCH 1/2] staging: android: ion: Fix license identifier comment format Nathan Chancellor
2018-05-07 16:34     ` Laura Abbott

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d157b475-7893-3ab6-87a8-b6ce5aa13b4f@redhat.com \
    --to=labbott@redhat.com \
    --cc=arve@android.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=joe@perches.com \
    --cc=linaro-mm-sig@lists.linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maco@android.com \
    --cc=natechancellor@gmail.com \
    --cc=sumit.semwal@linaro.org \
    --cc=tkjos@android.com \
    --subject='Re: [PATCH 1/2] staging: android: ion: Fix license identifier comment format' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).