LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] IB/core: Make ib_mad_client_id atomic
@ 2018-04-18 14:24 Håkon Bugge
  2018-04-18 18:51 ` Weiny, Ira
                   ` (2 more replies)
  0 siblings, 3 replies; 17+ messages in thread
From: Håkon Bugge @ 2018-04-18 14:24 UTC (permalink / raw)
  To: Doug Ledford, Don Hiatt, Dasaratharaman Chandramouli, Ira Weiny,
	Sean Hefty
  Cc: linux-rdma, linux-kernel, Håkon Bugge

Two kernel threads may get the same value for agent.hi_tid, if the
agents are registered for different ports. As of now, this works, as
the agent list is per port.

It is however confusing and not future robust. Hence, making it
atomic.

Signed-off-by: Håkon Bugge <haakon.bugge@oracle.com>
Reviewed-by: Jack Morgenstein <jackm@dev.mellanox.co.il>
---
 drivers/infiniband/core/mad.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/infiniband/core/mad.c b/drivers/infiniband/core/mad.c
index c50596f7f98a..b28452a55a08 100644
--- a/drivers/infiniband/core/mad.c
+++ b/drivers/infiniband/core/mad.c
@@ -59,7 +59,7 @@ module_param_named(recv_queue_size, mad_recvq_size, int, 0444);
 MODULE_PARM_DESC(recv_queue_size, "Size of receive queue in number of work requests");
 
 static struct list_head ib_mad_port_list;
-static u32 ib_mad_client_id = 0;
+static atomic_t ib_mad_client_id = ATOMIC_INIT(0);
 
 /* Port list lock */
 static DEFINE_SPINLOCK(ib_mad_port_list_lock);
@@ -377,7 +377,7 @@ struct ib_mad_agent *ib_register_mad_agent(struct ib_device *device,
 	}
 
 	spin_lock_irqsave(&port_priv->reg_lock, flags);
-	mad_agent_priv->agent.hi_tid = ++ib_mad_client_id;
+	mad_agent_priv->agent.hi_tid = atomic_inc_return(&ib_mad_client_id);
 
 	/*
 	 * Make sure MAD registration (if supplied)
-- 
2.13.6

^ permalink raw reply	[flat|nested] 17+ messages in thread

end of thread, other threads:[~2018-05-01  6:40 UTC | newest]

Thread overview: 17+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-18 14:24 [PATCH] IB/core: Make ib_mad_client_id atomic Håkon Bugge
2018-04-18 18:51 ` Weiny, Ira
2018-04-19  2:59 ` Yanjun Zhu
2018-04-20  3:55 ` Doug Ledford
2018-04-20 15:34   ` Jason Gunthorpe
2018-04-23 14:19     ` Håkon Bugge
2018-04-23 19:16       ` jackm
2018-04-26 16:06         ` Håkon Bugge
2018-04-26 18:32           ` jackm
     [not found]             ` <9fdd3ec4-ee91-5442-e753-25d2ecd27ea9@xsintricity.com>
     [not found]               ` <A58D5192-06E7-46A3-869C-273E9A2BC128@oracle.com>
2018-04-27 19:08                 ` Doug Ledford
2018-04-30 11:50                   ` Håkon Bugge
2018-04-30 14:49         ` Jason Gunthorpe
2018-04-30 17:10           ` Doug Ledford
2018-04-30 17:49             ` Weiny, Ira
2018-04-30 23:01             ` Jason Gunthorpe
2018-05-01  4:38             ` jackm
2018-05-01  6:40               ` Håkon Bugge

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).