LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Christian König" <christian.koenig@amd.com>
To: Nathan Chancellor <nathan@kernel.org>,
	Alex Deucher <alexander.deucher@amd.com>,
	"Pan, Xinhui" <Xinhui.Pan@amd.com>
Cc: Nick Desaulniers <ndesaulniers@google.com>,
	"Gustavo A. R. Silva" <gustavoars@kernel.org>,
	Kees Cook <keescook@chromium.org>,
	amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
	linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com
Subject: Re: [PATCH] drm/radeon: Add break to switch statement in radeonfb_create_pinned_object()
Date: Mon, 16 Aug 2021 09:22:49 +0200	[thread overview]
Message-ID: <d2e9b2a0-49b9-42fe-47fc-66a44bef3b01@amd.com> (raw)
In-Reply-To: <20210815192959.90142-1-nathan@kernel.org>

Am 15.08.21 um 21:29 schrieb Nathan Chancellor:
> Clang + -Wimplicit-fallthrough warns:
>
> drivers/gpu/drm/radeon/radeon_fb.c:170:2: warning: unannotated
> fall-through between switch labels [-Wimplicit-fallthrough]
>          default:
>          ^
> drivers/gpu/drm/radeon/radeon_fb.c:170:2: note: insert 'break;' to avoid
> fall-through
>          default:
>          ^
>          break;
> 1 warning generated.
>
> Clang's version of this warning is a little bit more pedantic than
> GCC's. Add the missing break to satisfy it to match what has been done
> all over the kernel tree.
>
> Signed-off-by: Nathan Chancellor <nathan@kernel.org>

Reviewed-by: Christian König <christian.koenig@amd.com>

> ---
>   drivers/gpu/drm/radeon/radeon_fb.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_fb.c b/drivers/gpu/drm/radeon/radeon_fb.c
> index 0b206b052972..c8b545181497 100644
> --- a/drivers/gpu/drm/radeon/radeon_fb.c
> +++ b/drivers/gpu/drm/radeon/radeon_fb.c
> @@ -167,6 +167,7 @@ static int radeonfb_create_pinned_object(struct radeon_fbdev *rfbdev,
>   		break;
>   	case 2:
>   		tiling_flags |= RADEON_TILING_SWAP_16BIT;
> +		break;
>   	default:
>   		break;
>   	}
>
> base-commit: ba31f97d43be41ca99ab72a6131d7c226306865f


  reply	other threads:[~2021-08-16  7:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-15 19:29 Nathan Chancellor
2021-08-16  7:22 ` Christian König [this message]
2021-08-16 18:53   ` Alex Deucher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d2e9b2a0-49b9-42fe-47fc-66a44bef3b01@amd.com \
    --to=christian.koenig@amd.com \
    --cc=Xinhui.Pan@amd.com \
    --cc=alexander.deucher@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=clang-built-linux@googlegroups.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=gustavoars@kernel.org \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nathan@kernel.org \
    --cc=ndesaulniers@google.com \
    --subject='Re: [PATCH] drm/radeon: Add break to switch statement in radeonfb_create_pinned_object()' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).