LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Riccardo Mancini <rickyman7@gmail.com>
To: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
Cc: Ian Rogers <irogers@google.com>,
	Namhyung Kim <namhyung@kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	Mark Rutland <mark.rutland@arm.com>, Jiri Olsa <jolsa@redhat.com>,
	linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org
Subject: Re: [RFC PATCH 06/10] perf workqueue: introduce workqueue struct
Date: Thu, 15 Jul 2021 18:49:57 +0200	[thread overview]
Message-ID: <d39def9e5c3edd6292d86c90036fd79a2406db1d.camel@gmail.com> (raw)
In-Reply-To: <YO8BUfFe4iNo/awZ@kernel.org>

Hi Arnaldo,
thanks again for having a look at this patchset!

On Wed, 2021-07-14 at 12:22 -0300, Arnaldo Carvalho de Melo wrote:
> Em Tue, Jul 13, 2021 at 02:11:17PM +0200, Riccardo Mancini escreveu:
> > This patch adds the workqueue definition, along with simple creation and
> > destruction functions.
> > Furthermore, a simple subtest is added.
> > 
> > A workqueue is attached to a pool, on which it executes its workers.
> > Next patches will introduce workers.
> > 
> > Signed-off-by: Riccardo Mancini <rickyman7@gmail.com>
> > 
<SNIP>
> > +
> > +/**
> > + * create_workqueue - create a workqueue associated to @pool
> > + *
> > + * Only one workqueue can execute on a pool at a time.
> > + */
> > +struct workqueue_struct *create_workqueue(struct threadpool_struct *pool)
> 
> I wonder if we should use the exact same kernel signature and not pass a
> threadpool, essentially having just one threadpool in tools/perf/ that
> is used by create_workqueue(void)?

I wondered the same thing, but I thought that we'd need it to be dynamically
created to prevent spawning threads at the beginning that might not even be
used.
I think this could be a follow-up patch.

Thanks,
Riccardo

> 
> > +{
> > +       int err;
> > +       struct workqueue_struct *wq = malloc(sizeof(struct
> > workqueue_struct));
> > +
> > +
> > +       err = pthread_mutex_init(&wq->lock, NULL);
> > +       if (err)
> > +               goto out_free_wq;
> > +
> > +       err = pthread_cond_init(&wq->idle_cond, NULL);
> > +       if (err)
> > +               goto out_destroy_mutex;
> > +
> > +       wq->pool = NULL;
> > +       INIT_LIST_HEAD(&wq->busy_list);
> > +       INIT_LIST_HEAD(&wq->idle_list);
> > +
> > +       INIT_LIST_HEAD(&wq->pending);
> > +
> > +       err = pipe(wq->msg_pipe);
> > +       if (err)
> > +               goto out_destroy_cond;
> > +
> > +       wq->task.fn = worker_thread;
> > +
> > +       err = attach_threadpool_to_workqueue(wq, pool);
> > +       if (err)
> > +               goto out_destroy_cond;
> > +
> > +       wq->status = WORKQUEUE_STATUS__READY;
> > +
> > +       return wq;
> > +
> > +out_destroy_cond:
> > +       pthread_cond_destroy(&wq->idle_cond);
> > +out_destroy_mutex:
> > +       pthread_mutex_destroy(&wq->lock);
> > +out_free_wq:
> > +       free(wq);
> > +       return NULL;
> > +}
> > +
> > +/**
> > + * destroy_workqueue - stop @wq workers and destroy @wq
> > + */
> > +int destroy_workqueue(struct workqueue_struct *wq)
> > +{
> > +       int err = 0, ret;
> > +
> > +       ret = detach_threadpool_from_workqueue(wq);
> > +       if (ret) {
> > +               pr_err("workqueue: error detaching from threadpool.\n");
> > +               err = -1;
> > +       }
> > +
> > +       ret = pthread_mutex_destroy(&wq->lock);
> > +       if (ret) {
> > +               err = -1;
> > +               pr_err("workqueue: error pthread_mutex_destroy: %s\n",
> > +                       strerror(errno));
> > +       }
> > +
> > +       ret = pthread_cond_destroy(&wq->idle_cond);
> > +       if (ret) {
> > +               err = -1;
> > +               pr_err("workqueue: error pthread_cond_destroy: %s\n",
> > +                       strerror(errno));
> > +       }
> > +
> > +       ret = close(wq->msg_pipe[0]);
> > +       if (ret) {
> > +               err = -1;
> > +               pr_err("workqueue: error close msg_pipe[0]: %s\n",
> > +                       strerror(errno));
> > +       }
> > +
> > +       ret = close(wq->msg_pipe[1]);
> > +       if (ret) {
> > +               err = -1;
> > +               pr_err("workqueue: error close msg_pipe[1]: %s\n",
> > +                       strerror(errno));
> > +       }
> > +
> > +       free(wq);
> > +
> > +       return err;
> > +}
> > +
> > +/**
> > + * workqueue_nr_threads - get size of threadpool underlying @wq
> > + */
> > +int workqueue_nr_threads(struct workqueue_struct *wq)
> > +{
> > +       return threadpool_size(wq->pool);
> > +}
> > diff --git a/tools/perf/util/workqueue/workqueue.h
> > b/tools/perf/util/workqueue/workqueue.h
> > new file mode 100644
> > index 0000000000000000..86ec1d69274f41db
> > --- /dev/null
> > +++ b/tools/perf/util/workqueue/workqueue.h
> > @@ -0,0 +1,24 @@
> > +/* SPDX-License-Identifier: GPL-2.0 */
> > +#ifndef __WORKQUEUE_WORKQUEUE_H
> > +#define __WORKQUEUE_WORKQUEUE_H
> > +
> > +#include <stdlib.h>
> > +#include <sys/types.h>
> > +#include <linux/list.h>
> > +#include "threadpool.h"
> > +
> > +struct work_struct;
> > +typedef void (*work_func_t)(struct work_struct *work);
> > +
> > +struct work_struct {
> > +       struct list_head entry;
> > +       work_func_t func;
> > +};
> > +
> > +struct workqueue_struct;
> > +
> > +extern struct workqueue_struct *create_workqueue(struct threadpool_struct
> > *pool);
> > +extern int destroy_workqueue(struct workqueue_struct *wq);
> > +
> > +extern int workqueue_nr_threads(struct workqueue_struct *wq);
> > +#endif /* __WORKQUEUE_WORKQUEUE_H */
> > -- 
> > 2.31.1
> > 
> 



  reply	other threads:[~2021-07-15 16:50 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-13 12:11 [RFC PATCH 00/10] perf: add workqueue library and use it in synthetic-events Riccardo Mancini
2021-07-13 12:11 ` [RFC PATCH 01/10] perf workqueue: threadpool creation and destruction Riccardo Mancini
2021-07-14 14:16   ` Arnaldo Carvalho de Melo
2021-07-15 16:31     ` Riccardo Mancini
2021-07-15 20:48       ` Arnaldo Carvalho de Melo
2021-07-15 23:29     ` Namhyung Kim
2021-07-16 13:36       ` Riccardo Mancini
2021-07-19 19:39         ` Namhyung Kim
2021-07-13 12:11 ` [RFC PATCH 02/10] perf tests: add test for workqueue Riccardo Mancini
2021-07-14 15:10   ` Arnaldo Carvalho de Melo
2021-07-15 16:33     ` Riccardo Mancini
2021-07-13 12:11 ` [RFC PATCH 03/10] perf workqueue: add threadpool start and stop functions Riccardo Mancini
2021-07-14 15:15   ` Arnaldo Carvalho de Melo
2021-07-15 16:42     ` Riccardo Mancini
2021-07-15 20:43       ` Arnaldo Carvalho de Melo
2021-07-15 23:48   ` Namhyung Kim
2021-07-16 13:53     ` Riccardo Mancini
2021-07-16 16:29       ` Arnaldo Carvalho de Melo
2021-07-13 12:11 ` [RFC PATCH 04/10] perf workqueue: add threadpool execute and wait functions Riccardo Mancini
2021-07-15 23:56   ` Namhyung Kim
2021-07-16 13:55     ` Riccardo Mancini
2021-07-13 12:11 ` [RFC PATCH 05/10] perf workqueue: add sparse annotation header Riccardo Mancini
2021-07-13 12:11 ` [RFC PATCH 06/10] perf workqueue: introduce workqueue struct Riccardo Mancini
2021-07-14 15:22   ` Arnaldo Carvalho de Melo
2021-07-15 16:49     ` Riccardo Mancini [this message]
2021-07-15 20:47       ` Arnaldo Carvalho de Melo
2021-07-13 12:11 ` [RFC PATCH 07/10] perf workqueue: implement worker thread and management Riccardo Mancini
2021-07-13 12:11 ` [RFC PATCH 08/10] perf workqueue: add queue_work and flush_workqueue functions Riccardo Mancini
2021-07-13 12:11 ` [RFC PATCH 09/10] perf workqueue: add utility to execute a for loop in parallel Riccardo Mancini
2021-07-13 12:11 ` [RFC PATCH 10/10] perf synthetic-events: use workqueue parallel_for Riccardo Mancini
2021-07-13 19:14 ` [RFC PATCH 00/10] perf: add workqueue library and use it in synthetic-events Arnaldo Carvalho de Melo
2021-07-19 21:13 ` Jiri Olsa
2021-07-22 16:15   ` Riccardo Mancini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d39def9e5c3edd6292d86c90036fd79a2406db1d.camel@gmail.com \
    --to=rickyman7@gmail.com \
    --cc=arnaldo.melo@gmail.com \
    --cc=irogers@google.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --subject='Re: [RFC PATCH 06/10] perf workqueue: introduce workqueue struct' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).