LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] iio: mma8452: Fix ignoring MMA8452_INT_DRDY
@ 2018-06-07 18:52 Leonard Crestez
  2018-06-20  9:15 ` Martin Kepplinger
  0 siblings, 1 reply; 3+ messages in thread
From: Leonard Crestez @ 2018-06-07 18:52 UTC (permalink / raw)
  To: Harinath Nampally, Martin Kepplinger
  Cc: Jonathan Cameron, Peter Meerwald-Stadler, Hartmut Knaack,
	Lars-Peter Clausen, linux-iio, linux-kernel

Interrupts are ignored if no event bit is set in the status status
register and this breaks the buffer interface. No data is shown when
running "iio_generic_buffer -n mma8451 -a" and interrupt counts go
crazy.

Fix by not returning IRQ_NONE if DRDY is set.

Fixes: 605f72de137a ("iio: accel: mma8452: improvements to handle
multiple events")

Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com>

---
 drivers/iio/accel/mma8452.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Perhaps this whole early-exit check could be dropped? It is not clear
how it helps.

If for some models we want to ignore unsupported events then maybe this
should be checked for each individual bit. Instead of

if (src & MMA8452_INT_FF_MT) {

Check for:

if ((src & MMA8452_INT_FF_MT) && (data->chip_info->enabled_events & MMA8452_INT_FF_MT))

diff --git a/drivers/iio/accel/mma8452.c b/drivers/iio/accel/mma8452.c
index 7a2da7f9d4dc..5485b35fe553 100644
--- a/drivers/iio/accel/mma8452.c
+++ b/drivers/iio/accel/mma8452.c
@@ -1032,11 +1032,11 @@ static irqreturn_t mma8452_interrupt(int irq, void *p)
 
 	src = i2c_smbus_read_byte_data(data->client, MMA8452_INT_SRC);
 	if (src < 0)
 		return IRQ_NONE;
 
-	if (!(src & data->chip_info->enabled_events))
+	if (!(src & (data->chip_info->enabled_events | MMA8452_INT_DRDY)))
 		return IRQ_NONE;
 
 	if (src & MMA8452_INT_DRDY) {
 		iio_trigger_poll_chained(indio_dev->trig);
 		ret = IRQ_HANDLED;
-- 
2.17.1

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] iio: mma8452: Fix ignoring MMA8452_INT_DRDY
  2018-06-07 18:52 [PATCH] iio: mma8452: Fix ignoring MMA8452_INT_DRDY Leonard Crestez
@ 2018-06-20  9:15 ` Martin Kepplinger
  2018-06-22  1:34   ` harinath Nampally
  0 siblings, 1 reply; 3+ messages in thread
From: Martin Kepplinger @ 2018-06-20  9:15 UTC (permalink / raw)
  To: Leonard Crestez, Harinath Nampally
  Cc: Jonathan Cameron, Peter Meerwald-Stadler, Hartmut Knaack,
	Lars-Peter Clausen, linux-iio, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 1796 bytes --]

On 2018-06-07 20:52, Leonard Crestez wrote:
> Interrupts are ignored if no event bit is set in the status status
> register and this breaks the buffer interface. No data is shown when
> running "iio_generic_buffer -n mma8451 -a" and interrupt counts go
> crazy.
> 
> Fix by not returning IRQ_NONE if DRDY is set.
> 
> Fixes: 605f72de137a ("iio: accel: mma8452: improvements to handle
> multiple events")
> 
> Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com>

At least this does no harm to events. So if this solves your problem:

Acked-by: Martin Kepplinger <martink@posteo.de>

thanks,

                            martin

> 
> ---
>  drivers/iio/accel/mma8452.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Perhaps this whole early-exit check could be dropped? It is not clear
> how it helps.
> 
> If for some models we want to ignore unsupported events then maybe this
> should be checked for each individual bit. Instead of
> 
> if (src & MMA8452_INT_FF_MT) {
> 
> Check for:
> 
> if ((src & MMA8452_INT_FF_MT) && (data->chip_info->enabled_events & MMA8452_INT_FF_MT))
> 
> diff --git a/drivers/iio/accel/mma8452.c b/drivers/iio/accel/mma8452.c
> index 7a2da7f9d4dc..5485b35fe553 100644
> --- a/drivers/iio/accel/mma8452.c
> +++ b/drivers/iio/accel/mma8452.c
> @@ -1032,11 +1032,11 @@ static irqreturn_t mma8452_interrupt(int irq, void *p)
>  
>  	src = i2c_smbus_read_byte_data(data->client, MMA8452_INT_SRC);
>  	if (src < 0)
>  		return IRQ_NONE;
>  
> -	if (!(src & data->chip_info->enabled_events))
> +	if (!(src & (data->chip_info->enabled_events | MMA8452_INT_DRDY)))
>  		return IRQ_NONE;
>  
>  	if (src & MMA8452_INT_DRDY) {
>  		iio_trigger_poll_chained(indio_dev->trig);
>  		ret = IRQ_HANDLED;
> 


[-- Attachment #2: pEpkey.asc --]
[-- Type: application/pgp-keys, Size: 1795 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] iio: mma8452: Fix ignoring MMA8452_INT_DRDY
  2018-06-20  9:15 ` Martin Kepplinger
@ 2018-06-22  1:34   ` harinath Nampally
  0 siblings, 0 replies; 3+ messages in thread
From: harinath Nampally @ 2018-06-22  1:34 UTC (permalink / raw)
  To: Martin Kepplinger
  Cc: Leonard Crestez, Jonathan Cameron, Peter Meerwald-Stadler,
	Hartmut Knaack, Lars-Peter Clausen, linux-iio, LKML

On 2018-06-07 20:52, Leonard Crestez wrote:
> Interrupts are ignored if no event bit is set in the status status
> register and this breaks the buffer interface. No data is shown when
> running "iio_generic_buffer -n mma8451 -a" and interrupt counts go
> crazy.
>
> Fix by not returning IRQ_NONE if DRDY is set.
>
> Fixes: 605f72de137a ("iio: accel: mma8452: improvements to handle
> multiple events")
>
> Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com>
Thanks for catching it. Looks good to me.
Acked-by: Harinath Nampally <harinath922@gmail.com>

Thanks,
Harinath


On Wed, Jun 20, 2018 at 5:15 AM, Martin Kepplinger <martink@posteo.de> wrote:
> On 2018-06-07 20:52, Leonard Crestez wrote:
>> Interrupts are ignored if no event bit is set in the status status
>> register and this breaks the buffer interface. No data is shown when
>> running "iio_generic_buffer -n mma8451 -a" and interrupt counts go
>> crazy.
>>
>> Fix by not returning IRQ_NONE if DRDY is set.
>>
>> Fixes: 605f72de137a ("iio: accel: mma8452: improvements to handle
>> multiple events")
>>
>> Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com>
>
> At least this does no harm to events. So if this solves your problem:
>
> Acked-by: Martin Kepplinger <martink@posteo.de>
>
> thanks,
>
>                             martin
>
>>
>> ---
>>  drivers/iio/accel/mma8452.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> Perhaps this whole early-exit check could be dropped? It is not clear
>> how it helps.
>>
>> If for some models we want to ignore unsupported events then maybe this
>> should be checked for each individual bit. Instead of
>>
>> if (src & MMA8452_INT_FF_MT) {
>>
>> Check for:
>>
>> if ((src & MMA8452_INT_FF_MT) && (data->chip_info->enabled_events & MMA8452_INT_FF_MT))
>>
>> diff --git a/drivers/iio/accel/mma8452.c b/drivers/iio/accel/mma8452.c
>> index 7a2da7f9d4dc..5485b35fe553 100644
>> --- a/drivers/iio/accel/mma8452.c
>> +++ b/drivers/iio/accel/mma8452.c
>> @@ -1032,11 +1032,11 @@ static irqreturn_t mma8452_interrupt(int irq, void *p)
>>
>>       src = i2c_smbus_read_byte_data(data->client, MMA8452_INT_SRC);
>>       if (src < 0)
>>               return IRQ_NONE;
>>
>> -     if (!(src & data->chip_info->enabled_events))
>> +     if (!(src & (data->chip_info->enabled_events | MMA8452_INT_DRDY)))
>>               return IRQ_NONE;
>>
>>       if (src & MMA8452_INT_DRDY) {
>>               iio_trigger_poll_chained(indio_dev->trig);
>>               ret = IRQ_HANDLED;
>>
>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-06-22  1:35 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-06-07 18:52 [PATCH] iio: mma8452: Fix ignoring MMA8452_INT_DRDY Leonard Crestez
2018-06-20  9:15 ` Martin Kepplinger
2018-06-22  1:34   ` harinath Nampally

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).