LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "andrew hendry" <andrew.hendry@gmail.com>
To: "Linus Torvalds" <torvalds@linux-foundation.org>
Cc: "Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>
Subject: Re: Linux 2.6.22-rc1
Date: Tue, 15 May 2007 15:10:36 +1000	[thread overview]
Message-ID: <d45a3acc0705142210w3982c14ep8afac73c1352ec7e@mail.gmail.com> (raw)
In-Reply-To: <alpine.LFD.0.98.0705142135390.6739@woody.linux-foundation.org>

almost, highstart_pfn is used in a few printks

arch/i386/mm/discontig.c: In function 'setup_memory':
arch/i386/mm/discontig.c:314: error: 'highstart_pfn' undeclared (first
use in this function)
arch/i386/mm/discontig.c:314: error: (Each undeclared identifier is
reported only once
arch/i386/mm/discontig.c:314: error: for each function it appears in.)

On 5/15/07, Linus Torvalds <torvalds@linux-foundation.org> wrote:
>
>
> On Tue, 15 May 2007, andrew hendry wrote:
> >
> > from a randconfig, attached.
> >
> > arch/i386/mm/discontig.c:107: error: expected identifier or '(' before numeric constant
>
> Gaah. That file is horrible. It redeclares a lot of stuff that it has no
> business declaring.
>
> Does this patch help?
>
>                 Linus
> ---
>  arch/i386/mm/discontig.c |   10 +++-------
>  1 files changed, 3 insertions(+), 7 deletions(-)
>
> diff --git a/arch/i386/mm/discontig.c b/arch/i386/mm/discontig.c
> index aa58720..baac2a4 100644
> --- a/arch/i386/mm/discontig.c
> +++ b/arch/i386/mm/discontig.c
> @@ -31,6 +31,7 @@
>  #include <linux/module.h>
>  #include <linux/kexec.h>
>  #include <linux/pfn.h>
> +#include <linux/swap.h>
>
>  #include <asm/e820.h>
>  #include <asm/setup.h>
> @@ -97,15 +98,8 @@ unsigned long node_memmap_size_bytes(int nid, unsigned long start_pfn,
>  #endif
>
>  extern unsigned long find_max_low_pfn(void);
> -extern void find_max_pfn(void);
>  extern void add_one_highpage_init(struct page *, int, int);
>
> -extern struct e820map e820;
> -extern unsigned long highend_pfn, highstart_pfn;
> -extern unsigned long max_low_pfn;
> -extern unsigned long totalram_pages;
> -extern unsigned long totalhigh_pages;
> -
>  #define LARGE_PAGE_BYTES (PTRS_PER_PTE * PAGE_SIZE)
>
>  unsigned long node_remap_start_pfn[MAX_NUMNODES];
> @@ -360,7 +354,9 @@ void __init zone_sizes_init(void)
>         max_zone_pfns[ZONE_DMA] =
>                 virt_to_phys((char *)MAX_DMA_ADDRESS) >> PAGE_SHIFT;
>         max_zone_pfns[ZONE_NORMAL] = max_low_pfn;
> +#ifdef CONFIG_HIGHMEM
>         max_zone_pfns[ZONE_HIGHMEM] = highend_pfn;
> +#endif
>
>         /* If SRAT has not registered memory, register it now */
>         if (find_max_pfn_with_active_regions() == 0) {
>

  reply	other threads:[~2007-05-15  5:10 UTC|newest]

Thread overview: 79+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-13  3:20 Linus Torvalds
2007-05-13  9:20 ` Jan Engelhardt
2007-05-17  6:55   ` Len Brown
2007-05-13  9:29 ` Linux 2.6.22-rc1, 'nother randconfig Jan Engelhardt
2007-05-13  9:47 ` [PATCH] driver core: fix warning of temporarily unused multithreaded probing function (was: Re: Linux 2.6.22-rc1) Borislav Petkov
2007-05-14  8:06   ` Cornelia Huck
2007-05-13 12:44 ` Linux 2.6.22-rc1 Alessandro Suardi
2007-05-13 12:44 ` Indan Zupancic
2007-05-13 17:10 ` Antonino Ingargiola
2007-05-13 17:53   ` Linus Torvalds
2007-05-13 18:50     ` Antonino Ingargiola
2007-05-14  6:10       ` Jean Delvare
2007-05-14  8:34         ` Antonino Ingargiola
2007-05-14 12:14           ` Jean Delvare
2007-05-14 13:28             ` Antonino Ingargiola
2007-05-14 15:21               ` Jean Delvare
2007-05-14 16:04                 ` Antonino Ingargiola
2007-05-14 16:23                   ` Michal Piotrowski
2007-05-14 18:08                   ` Jean Delvare
2007-05-14 18:25                     ` Antonino Ingargiola
2007-05-14 16:30                 ` Linus Torvalds
2007-05-14 18:24                   ` Jean Delvare
2007-05-14 18:43                     ` Linus Torvalds
2007-05-14 19:28                       ` Jean Delvare
2007-05-14 19:53                         ` Jeff Garzik
2007-05-14 20:18                           ` Christoph Hellwig
2007-05-14 20:17                         ` Christoph Hellwig
2007-05-14 20:15                       ` Christoph Hellwig
2007-05-15 20:31             ` CONFIG_BREAK_MY_MACHINE was " Pavel Machek
2007-05-16 18:11               ` CONFIG_BREAK_MY_MACHINE Jean Delvare
2007-05-17  8:32                 ` CONFIG_BREAK_MY_MACHINE Hans de Goede
2007-05-17  8:47                   ` CONFIG_BREAK_MY_MACHINE Pavel Machek
2007-05-13 18:19 ` Linux 2.6.22-rc1 Tilman Schmidt
2007-05-13 23:20   ` David Miller
2007-05-13 23:32     ` Roland Dreier
2007-05-13 23:57     ` Tilman Schmidt
2007-05-14  4:37     ` Sam Ravnborg
2007-05-14  4:53       ` David Miller
2007-05-14  6:21     ` Satyam Sharma
2007-05-14 17:21   ` Jan Engelhardt
2007-05-14 17:32     ` Stefan Richter
2007-05-14 20:27       ` Jan Engelhardt
2007-05-14 18:01     ` Tilman Schmidt
2007-05-14 20:33       ` Jan Engelhardt
2007-05-14 21:40         ` Tilman Schmidt
2007-05-14 22:09           ` Stefan Richter
2007-05-15  3:02             ` Satyam Sharma
2007-05-15  8:08               ` Jan Engelhardt
2007-05-14 21:54         ` Stefan Richter
2007-05-15  2:34         ` Satyam Sharma
2007-05-15  2:42           ` Satyam Sharma
2007-05-15  6:05             ` Stefan Richter
2007-05-15  6:01           ` Stefan Richter
2007-05-15  8:16           ` Jan Engelhardt
2007-05-16  1:52             ` Satyam Sharma
2007-05-16  6:29               ` Stefan Richter
2007-05-16  9:56                 ` Satyam Sharma
2007-05-15 10:43           ` Tilman Schmidt
2007-05-16  1:39             ` Satyam Sharma
2007-05-16  9:14               ` Tilman Schmidt
2007-05-16  9:17                 ` Satyam Sharma
2007-05-15  5:35         ` Michael Gerdau
2007-05-13 20:51 ` 2.6.22-rc1: loop.c Alexey Dobriyan
2007-05-14  3:52   ` Jeremy Fitzhardinge
2007-05-13 22:53 ` Linux 2.6.22-rc1 Jeff Chua
2007-05-14  1:08 ` andrew hendry
2007-05-14  7:49 ` V4L Regression (Was: Linux 2.6.22-rc1) Robert Fitzsimons
2007-05-14 11:44 ` Linux 2.6.22-rc1, 'nother randconfig David Howells
2007-05-14 17:23   ` Jan Engelhardt
2007-05-15  9:26   ` David Howells
2007-05-15  9:40     ` Jan Engelhardt
2007-05-15  4:14 ` Linux 2.6.22-rc1 andrew hendry
2007-05-15  4:38   ` Linus Torvalds
2007-05-15  5:10     ` andrew hendry [this message]
2007-05-15 15:57       ` Linus Torvalds
2007-05-15 22:50         ` andrew hendry
2007-05-13  6:00 Jeff Chua
2007-05-13  6:13 ` Jeff Chua
2007-05-13  8:04 ` Jan Engelhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d45a3acc0705142210w3982c14ep8afac73c1352ec7e@mail.gmail.com \
    --to=andrew.hendry@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    --subject='Re: Linux 2.6.22-rc1' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).