LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Christian Borntraeger <borntraeger@de.ibm.com>,
	Janosch Frank <frankja@linux.ibm.com>,
	David Hildenbrand <david@redhat.com>,
	Cornelia Huck <cohuck@redhat.com>
Cc: Heiko Carstens <heiko.carstens@de.ibm.com>,
	Vasily Gorbik <gor@linux.ibm.com>,
	kvm@vger.kernel.org, linux-s390@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH -next 018/491] KERNEL VIRTUAL MACHINE for s390 (KVM/s390): Use fallthrough;
Date: Tue, 10 Mar 2020 21:51:32 -0700	[thread overview]
Message-ID: <d63c86429f3e5aa806aa3e185c97d213904924a5.1583896348.git.joe@perches.com> (raw)
In-Reply-To: <cover.1583896344.git.joe@perches.com>

Convert the various uses of fallthrough comments to fallthrough;

Done via script
Link: https://lore.kernel.org/lkml/b56602fcf79f849e733e7b521bb0e17895d390fa.1582230379.git.joe.com/

Signed-off-by: Joe Perches <joe@perches.com>
---
 arch/s390/kvm/gaccess.c   | 23 +++++++++++++----------
 arch/s390/kvm/interrupt.c |  2 +-
 arch/s390/kvm/kvm-s390.c  |  4 ++--
 arch/s390/mm/gmap.c       |  6 +++---
 4 files changed, 19 insertions(+), 16 deletions(-)

diff --git a/arch/s390/kvm/gaccess.c b/arch/s390/kvm/gaccess.c
index 07d30f..47a67a 100644
--- a/arch/s390/kvm/gaccess.c
+++ b/arch/s390/kvm/gaccess.c
@@ -505,7 +505,7 @@ static int trans_exc(struct kvm_vcpu *vcpu, int code, unsigned long gva,
 		switch (prot) {
 		case PROT_TYPE_IEP:
 			tec->b61 = 1;
-			/* FALL THROUGH */
+			fallthrough;
 		case PROT_TYPE_LA:
 			tec->b56 = 1;
 			break;
@@ -514,12 +514,12 @@ static int trans_exc(struct kvm_vcpu *vcpu, int code, unsigned long gva,
 			break;
 		case PROT_TYPE_ALC:
 			tec->b60 = 1;
-			/* FALL THROUGH */
+			fallthrough;
 		case PROT_TYPE_DAT:
 			tec->b61 = 1;
 			break;
 		}
-		/* FALL THROUGH */
+		fallthrough;
 	case PGM_ASCE_TYPE:
 	case PGM_PAGE_TRANSLATION:
 	case PGM_REGION_FIRST_TRANS:
@@ -534,7 +534,7 @@ static int trans_exc(struct kvm_vcpu *vcpu, int code, unsigned long gva,
 		tec->addr = gva >> PAGE_SHIFT;
 		tec->fsi = mode == GACC_STORE ? FSI_STORE : FSI_FETCH;
 		tec->as = psw_bits(vcpu->arch.sie_block->gpsw).as;
-		/* FALL THROUGH */
+		fallthrough;
 	case PGM_ALEN_TRANSLATION:
 	case PGM_ALE_SEQUENCE:
 	case PGM_ASTE_VALIDITY:
@@ -677,7 +677,7 @@ static unsigned long guest_translate(struct kvm_vcpu *vcpu, unsigned long gva,
 			dat_protection |= rfte.p;
 		ptr = rfte.rto * PAGE_SIZE + vaddr.rsx * 8;
 	}
-		/* fallthrough */
+		fallthrough;
 	case ASCE_TYPE_REGION2: {
 		union region2_table_entry rste;
 
@@ -695,7 +695,7 @@ static unsigned long guest_translate(struct kvm_vcpu *vcpu, unsigned long gva,
 			dat_protection |= rste.p;
 		ptr = rste.rto * PAGE_SIZE + vaddr.rtx * 8;
 	}
-		/* fallthrough */
+		fallthrough;
 	case ASCE_TYPE_REGION3: {
 		union region3_table_entry rtte;
 
@@ -723,7 +723,7 @@ static unsigned long guest_translate(struct kvm_vcpu *vcpu, unsigned long gva,
 			dat_protection |= rtte.fc0.p;
 		ptr = rtte.fc0.sto * PAGE_SIZE + vaddr.sx * 8;
 	}
-		/* fallthrough */
+		fallthrough;
 	case ASCE_TYPE_SEGMENT: {
 		union segment_table_entry ste;
 
@@ -1050,7 +1050,8 @@ static int kvm_s390_shadow_tables(struct gmap *sg, unsigned long saddr,
 		rc = gmap_shadow_r2t(sg, saddr, rfte.val, *fake);
 		if (rc)
 			return rc;
-	} /* fallthrough */
+	}
+		fallthrough;
 	case ASCE_TYPE_REGION2: {
 		union region2_table_entry rste;
 
@@ -1076,7 +1077,8 @@ static int kvm_s390_shadow_tables(struct gmap *sg, unsigned long saddr,
 		rc = gmap_shadow_r3t(sg, saddr, rste.val, *fake);
 		if (rc)
 			return rc;
-	} /* fallthrough */
+	}
+		fallthrough;
 	case ASCE_TYPE_REGION3: {
 		union region3_table_entry rtte;
 
@@ -1111,7 +1113,8 @@ static int kvm_s390_shadow_tables(struct gmap *sg, unsigned long saddr,
 		rc = gmap_shadow_sgt(sg, saddr, rtte.val, *fake);
 		if (rc)
 			return rc;
-	} /* fallthrough */
+	}
+		fallthrough;
 	case ASCE_TYPE_SEGMENT: {
 		union segment_table_entry ste;
 
diff --git a/arch/s390/kvm/interrupt.c b/arch/s390/kvm/interrupt.c
index 028167d6..819110 100644
--- a/arch/s390/kvm/interrupt.c
+++ b/arch/s390/kvm/interrupt.c
@@ -886,7 +886,7 @@ static int __must_check __deliver_prog(struct kvm_vcpu *vcpu)
 	case PGM_PRIMARY_AUTHORITY:
 	case PGM_SECONDARY_AUTHORITY:
 		nullifying = true;
-		/* fall through */
+		fallthrough;
 	case PGM_SPACE_SWITCH:
 		rc = put_guest_lc(vcpu, pgm_info.trans_exc_code,
 				  (u64 *)__LC_TRANS_EXC_CODE);
diff --git a/arch/s390/kvm/kvm-s390.c b/arch/s390/kvm/kvm-s390.c
index 6b1842a..d590f3 100644
--- a/arch/s390/kvm/kvm-s390.c
+++ b/arch/s390/kvm/kvm-s390.c
@@ -3752,7 +3752,7 @@ int kvm_arch_vcpu_ioctl_set_mpstate(struct kvm_vcpu *vcpu,
 		rc = kvm_s390_pv_set_cpu_state(vcpu, PV_CPU_STATE_OPR_LOAD);
 		break;
 	case KVM_MP_STATE_CHECK_STOP:
-		/* fall through - CHECK_STOP and LOAD are not supported yet */
+		fallthrough;	/* CHECK_STOP and LOAD are not supported yet */
 	default:
 		rc = -ENXIO;
 	}
@@ -4985,7 +4985,7 @@ void kvm_arch_commit_memory_region(struct kvm *kvm,
 					old->npages * PAGE_SIZE);
 		if (rc)
 			break;
-		/* FALLTHROUGH */
+		fallthrough;
 	case KVM_MR_CREATE:
 		rc = gmap_map_segment(kvm->arch.gmap, mem->userspace_addr,
 				      mem->guest_phys_addr, mem->memory_size);
diff --git a/arch/s390/mm/gmap.c b/arch/s390/mm/gmap.c
index 27926a0..03c899 100644
--- a/arch/s390/mm/gmap.c
+++ b/arch/s390/mm/gmap.c
@@ -804,7 +804,7 @@ static inline unsigned long *gmap_table_walk(struct gmap *gmap,
 		if (*table & _REGION_ENTRY_INVALID)
 			return NULL;
 		table = (unsigned long *)(*table & _REGION_ENTRY_ORIGIN);
-		/* Fallthrough */
+		fallthrough;
 	case _ASCE_TYPE_REGION2:
 		table += (gaddr & _REGION2_INDEX) >> _REGION2_SHIFT;
 		if (level == 3)
@@ -812,7 +812,7 @@ static inline unsigned long *gmap_table_walk(struct gmap *gmap,
 		if (*table & _REGION_ENTRY_INVALID)
 			return NULL;
 		table = (unsigned long *)(*table & _REGION_ENTRY_ORIGIN);
-		/* Fallthrough */
+		fallthrough;
 	case _ASCE_TYPE_REGION3:
 		table += (gaddr & _REGION3_INDEX) >> _REGION3_SHIFT;
 		if (level == 2)
@@ -820,7 +820,7 @@ static inline unsigned long *gmap_table_walk(struct gmap *gmap,
 		if (*table & _REGION_ENTRY_INVALID)
 			return NULL;
 		table = (unsigned long *)(*table & _REGION_ENTRY_ORIGIN);
-		/* Fallthrough */
+		fallthrough;
 	case _ASCE_TYPE_SEGMENT:
 		table += (gaddr & _SEGMENT_INDEX) >> _SEGMENT_SHIFT;
 		if (level == 1)
-- 
2.24.0


  parent reply	other threads:[~2020-03-11  5:08 UTC|newest]

Thread overview: 84+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-11 17:24 [PATCH -next 000/491] treewide: use fallthrough; Joe Perches
2020-03-11  4:51 ` [PATCH -next 001/491] MELLANOX ETHERNET INNOVA DRIVERS: Use fallthrough; Joe Perches
2020-03-11  7:01   ` Leon Romanovsky
2020-03-12  6:23   ` David Miller
2020-03-12  6:26     ` Joe Perches
2020-03-12  8:03       ` David Miller
2020-03-12 19:45       ` Jakub Kicinski
2020-03-12 19:52         ` Joe Perches
2020-03-11  4:51 ` [PATCH -next 002/491] MARVELL OCTEONTX2 RVU ADMIN FUNCTION DRIVER: " Joe Perches
2020-03-11  4:51 ` [PATCH -next 003/491] MELLANOX MLX5 core VPI driver: " Joe Perches
2020-03-11  7:00   ` Leon Romanovsky
2020-03-11  4:51 ` [PATCH -next 004/491] PERFORMANCE EVENTS SUBSYSTEM: " Joe Perches
2020-03-11 15:30   ` Peter Zijlstra
2020-03-12  6:15     ` Joe Perches
2020-03-11 19:20   ` Thomas Bogendoerfer
2020-03-11  4:51 ` [PATCH -next 005/491] ARM/UNIPHIER ARCHITECTURE: " Joe Perches
2020-03-11  5:15   ` Masahiro Yamada
2020-03-11 14:31     ` Joe Perches
2020-03-12  8:56       ` Greg Kroah-Hartman
2020-03-12  9:02         ` Masahiro Yamada
2020-03-12  9:36           ` Greg Kroah-Hartman
2020-03-12  9:37           ` Joe Perches
2020-03-12 13:47             ` Theodore Y. Ts'o
2020-03-12 14:15               ` Joe Perches
2020-03-12  9:03         ` Joe Perches
2020-03-11  4:51 ` [PATCH -next 006/491] ARM/RISCPC " Joe Perches
2020-03-12 10:11   ` Russell King - ARM Linux admin
2020-03-12 10:19     ` Joe Perches
2020-03-11  4:51 ` [PATCH -next 007/491] KERNEL VIRTUAL MACHINE FOR ARM/ARM64 (KVM/arm, KVM/arm64): " Joe Perches
2020-03-11  4:51 ` [PATCH -next 008/491] ARM/CIRRUS LOGIC EP93XX ARM ARCHITECTURE: " Joe Perches
2020-03-13 19:26   ` Alexander Sverdlin
2020-03-11  4:51 ` [PATCH -next 009/491] ARM/Amlogic Meson SoC support: " Joe Perches
2020-03-11  4:51 ` [PATCH -next 010/491] ARM/SAMSUNG EXYNOS ARM ARCHITECTURES: " Joe Perches
2020-03-13 14:26   ` Wolfram Sang
2020-03-14  1:17   ` Stephen Boyd
2020-05-13 11:59     ` Sylwester Nawrocki
2020-03-11  4:51 ` [PATCH -next 011/491] ARM/QUALCOMM SUPPORT: " Joe Perches
2020-03-11  5:23   ` Amit Kucheria
2020-03-11  8:46   ` Marc Gonzalez
2020-03-11 14:30     ` Joe Perches
2020-03-13 12:04   ` Stanimir Varbanov
2020-03-11  4:51 ` [PATCH -next 012/491] ARM/ZTE ARCHITECTURE: " Joe Perches
2020-03-11  4:51 ` [PATCH -next 013/491] INGENIC JZ47xx SoCs: " Joe Perches
2020-03-11  7:40   ` Miquel Raynal
2020-03-11 14:20     ` Ulf Hansson
2020-03-11 14:29       ` Miquel Raynal
2020-03-12  6:26     ` Joe Perches
2020-03-11  4:51 ` [PATCH -next 014/491] DECSTATION PLATFORM SUPPORT: " Joe Perches
2020-03-11 19:19   ` Thomas Bogendoerfer
2020-03-11  4:51 ` [PATCH -next 015/491] KERNEL VIRTUAL MACHINE FOR MIPS (KVM/mips): " Joe Perches
2020-03-11 19:20   ` Thomas Bogendoerfer
2020-03-11  4:51 ` [PATCH -next 016/491] KERNEL VIRTUAL MACHINE FOR POWERPC (KVM/powerpc): " Joe Perches
2020-03-19  1:18   ` Paul Mackerras
2020-03-19  1:22     ` Joe Perches
2020-03-19 23:33       ` Paul Mackerras
2020-03-11  4:51 ` [PATCH -next 017/491] CELL BROADBAND ENGINE ARCHITECTURE: " Joe Perches
2020-03-11  8:08   ` Arnd Bergmann
2020-03-26 12:06   ` Michael Ellerman
2020-03-11  4:51 ` Joe Perches [this message]
2020-03-11 11:33   ` [PATCH -next 018/491] KERNEL VIRTUAL MACHINE for s390 (KVM/s390): " Christian Borntraeger
2020-03-13 12:04   ` Christian Borntraeger
2020-03-11  4:51 ` [PATCH -next 019/491] Hyper-V CORE AND DRIVERS: " Joe Perches
2020-03-11 11:00   ` Wei Liu
2020-03-11  4:51 ` [PATCH -next 020/491] XEN HYPERVISOR INTERFACE: " Joe Perches
2020-03-11  6:47   ` Jürgen Groß
2020-03-11  4:51 ` [PATCH -next 021/491] KERNEL VIRTUAL MACHINE FOR X86 (KVM/x86): " Joe Perches
2020-03-11  9:43   ` Paolo Bonzini
2020-03-11  4:51 ` [PATCH -next 022/491] X86 MCE INFRASTRUCTURE: " Joe Perches
2020-03-11 17:14   ` Borislav Petkov
2020-03-11  4:51 ` [PATCH -next 023/491] AMD KFD: " Joe Perches
2020-03-11 21:50   ` Felix Kuehling
2020-03-11 22:09     ` Joe Perches
2020-03-12 14:12       ` Alex Deucher
2020-03-11  4:51 ` [PATCH -next 024/491] AMD DISPLAY CORE: " Joe Perches
2020-03-12 14:10   ` Alex Deucher
2020-03-11  4:51 ` [PATCH -next 025/491] AMD POWERPLAY: " Joe Perches
2020-03-12 14:10   ` Alex Deucher
2020-03-11  4:51 ` [PATCH -next 026/491] INTEL GVT-g DRIVERS (Intel GPU Virtualization): " Joe Perches
2020-03-11  4:51 ` [PATCH -next 027/491] AMD XGBE DRIVER: " Joe Perches
2020-03-11  4:51 ` [PATCH -next 028/491] BROADCOM BNX2X 10 GIGABIT ETHERNET " Joe Perches
2020-03-11  4:51 ` [PATCH -next 029/491] BROADCOM BNXT_EN 50 " Joe Perches
2020-03-11  4:51 ` [PATCH -next 030/491] BROADCOM GENET " Joe Perches
2020-03-11 16:35   ` Florian Fainelli
2020-03-11  4:51 ` [PATCH -next 031/491] BROCADE BNA 10 GIGABIT " Joe Perches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d63c86429f3e5aa806aa3e185c97d213904924a5.1583896348.git.joe@perches.com \
    --to=joe@perches.com \
    --cc=borntraeger@de.ibm.com \
    --cc=cohuck@redhat.com \
    --cc=david@redhat.com \
    --cc=frankja@linux.ibm.com \
    --cc=gor@linux.ibm.com \
    --cc=heiko.carstens@de.ibm.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --subject='Re: [PATCH -next 018/491] KERNEL VIRTUAL MACHINE for s390 (KVM/s390): Use fallthrough;' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).