LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Jan Kiszka <jan.kiszka@siemens.com>
To: Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Jason Wessel <jason.wessel@windriver.com>,
	kgdb-bugreport@lists.sourceforge.net,
	Andi Kleen <andi@firstfloor.org>, Ben Widawsky <ben@bwidawsk.net>,
	Borislav Petkov <bp@suse.de>
Subject: [PATCH v12 02/28] scripts/gdb: Add cache for type objects
Date: Fri, 30 Jan 2015 08:24:31 +0100	[thread overview]
Message-ID: <d73e068991f9bf5c2766633c54abcc347a7d1036.1422602696.git.jan.kiszka@siemens.com> (raw)
In-Reply-To: <cover.1422602696.git.jan.kiszka@siemens.com>
In-Reply-To: <cover.1422602696.git.jan.kiszka@siemens.com>

Type lookups are very slow in gdb-python which is often noticeable when
iterating over a number of objects. Introduce the helper class
CachedType that keeps a reference to a gdb.Type object but also
refreshes it after an object file has been loaded.

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
 scripts/gdb/linux/utils.py | 34 ++++++++++++++++++++++++++++++++++
 1 file changed, 34 insertions(+)
 create mode 100644 scripts/gdb/linux/utils.py

diff --git a/scripts/gdb/linux/utils.py b/scripts/gdb/linux/utils.py
new file mode 100644
index 0000000..f883611
--- /dev/null
+++ b/scripts/gdb/linux/utils.py
@@ -0,0 +1,34 @@
+#
+# gdb helper commands and functions for Linux kernel debugging
+#
+#  common utilities
+#
+# Copyright (c) Siemens AG, 2011-2013
+#
+# Authors:
+#  Jan Kiszka <jan.kiszka@siemens.com>
+#
+# This work is licensed under the terms of the GNU GPL version 2.
+#
+
+import gdb
+
+
+class CachedType:
+    def __init__(self, name):
+        self._type = None
+        self._name = name
+
+    def _new_objfile_handler(self, event):
+        self._type = None
+        gdb.events.new_objfile.disconnect(self._new_objfile_handler)
+
+    def get_type(self):
+        if self._type is None:
+            self._type = gdb.lookup_type(self._name)
+            if self._type is None:
+                raise gdb.GdbError(
+                    "cannot resolve type '{0}'".format(self._name))
+            if hasattr(gdb, 'events') and hasattr(gdb.events, 'new_objfile'):
+                gdb.events.new_objfile.connect(self._new_objfile_handler)
+        return self._type
-- 
2.1.4


  parent reply	other threads:[~2015-01-30  7:25 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-30  7:24 [PATCH v12 00/28] Add gdb python scripts as kernel debugging helpers Jan Kiszka
2015-01-30  7:24 ` [PATCH v12 01/28] scripts/gdb: Add infrastructure Jan Kiszka
2015-01-30 10:59   ` Michal Marek
2015-02-04  6:49   ` [PATCH v13 " Jan Kiszka
2015-01-30  7:24 ` Jan Kiszka [this message]
2015-01-30  7:24 ` [PATCH v12 03/28] scripts/gdb: Add container_of helper and convenience function Jan Kiszka
2015-01-30  7:24 ` [PATCH v12 04/28] scripts/gdb: Add module iteration class Jan Kiszka
2015-01-30  7:24 ` [PATCH v12 05/28] scripts/gdb: Add lx-symbols command Jan Kiszka
2015-01-30  7:24 ` [PATCH v12 06/28] module: Do not inline do_init_module Jan Kiszka
2015-02-10 23:59   ` Rusty Russell
2015-01-30  7:24 ` [PATCH v12 07/28] scripts/gdb: Add automatic symbol reloading on module insertion Jan Kiszka
2015-01-30  7:24 ` [PATCH v12 08/28] scripts/gdb: Add internal helper and convenience function to look up a module Jan Kiszka
2015-01-30  7:24 ` [PATCH v12 09/28] scripts/gdb: Add get_target_endianness helper Jan Kiszka
2015-01-30  7:24 ` [PATCH v12 10/28] scripts/gdb: Add read_u16/32/64 helpers Jan Kiszka
2015-01-30  7:24 ` [PATCH v12 11/28] scripts/gdb: Add lx-dmesg command Jan Kiszka
2015-01-30  7:24 ` [PATCH v12 12/28] scripts/gdb: Add task iteration class Jan Kiszka
2015-01-30  7:24 ` [PATCH v12 13/28] scripts/gdb: Add helper and convenience function to look up tasks Jan Kiszka
2015-01-30  7:24 ` [PATCH v12 14/28] scripts/gdb: Add is_target_arch helper Jan Kiszka
2015-01-30  7:24 ` [PATCH v12 15/28] scripts/gdb: Add internal helper and convenience function to retrieve thread_info Jan Kiszka
2015-01-30  7:24 ` [PATCH v12 16/28] scripts/gdb: Add get_gdbserver_type helper Jan Kiszka
2015-01-30  7:24 ` [PATCH v12 17/28] scripts/gdb: Add internal helper and convenience function for per-cpu lookup Jan Kiszka
2015-01-30  7:24 ` [PATCH v12 18/28] scripts/gdb: Add lx_current convenience function Jan Kiszka
2015-01-30  7:24 ` [PATCH v12 19/28] scripts/gdb: Add class to iterate over CPU masks Jan Kiszka
2015-01-30  7:24 ` [PATCH v12 20/28] scripts/gdb: Add lx-lsmod command Jan Kiszka
2015-01-30  7:24 ` [PATCH v12 21/28] scripts/gdb: Add basic documentation Jan Kiszka
2015-01-30  7:24 ` [PATCH v12 22/28] scripts/gdb: Port to python3 / gdb7.7 Jan Kiszka
2015-01-30  7:24 ` [PATCH v12 23/28] scripts/gdb: Ignore byte-compiled python files Jan Kiszka
2015-01-30  7:24 ` [PATCH v12 24/28] scripts/gdb: Use a generator instead of iterator for task list Jan Kiszka
2015-01-30  7:24 ` [PATCH v12 25/28] scripts/gdb: Convert ModuleList to generator function Jan Kiszka
2015-01-30  7:24 ` [PATCH v12 26/28] scripts/gdb: Convert CpuList " Jan Kiszka
2015-01-30  7:24 ` [PATCH v12 27/28] scripts/gdb: Define maintainer Jan Kiszka
2015-01-30  7:24 ` [PATCH v12 28/28] scripts/gdb: Disable pagination while printing from breakpoint handler Jan Kiszka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d73e068991f9bf5c2766633c54abcc347a7d1036.1422602696.git.jan.kiszka@siemens.com \
    --to=jan.kiszka@siemens.com \
    --cc=akpm@linux-foundation.org \
    --cc=andi@firstfloor.org \
    --cc=ben@bwidawsk.net \
    --cc=bp@suse.de \
    --cc=jason.wessel@windriver.com \
    --cc=kgdb-bugreport@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --subject='Re: [PATCH v12 02/28] scripts/gdb: Add cache for type objects' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).