LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "dave chung" <ponstrip@gmail.com>
To: "Stanislav Brabec" <utx@penguin.cz>
Cc: linux-kernel@vger.kernel.org,
	"Thibaut VARENE" <varenet@parisc-linux.org>
Subject: Re: [PATCH] drivers/video/s1d13xxxfb.c as module with dbg
Date: Sun, 11 Nov 2007 07:29:35 +0800	[thread overview]
Message-ID: <d7b238da0711101529s3384cb6bx928c74cfef8fde0f@mail.gmail.com> (raw)
In-Reply-To: <1194709875.4486.8.camel@utx.utx.cz>

On 11/10/07, Stanislav Brabec <utx@penguin.cz> wrote:
> Attached patch fixes two compilation problems of s1d13xxxfb.c:
> - Fixes outdated dbg() message to fix compilation error with debugging enabled.
> - Do not read kernel command line options when compiled as module.
>
> Signed-off-by: Stanislav Brabec <utx@penguin.cz>
>
> --- linux-2.6.23/drivers/video/s1d13xxxfb.c     2007-10-09 22:31:38.000000000 +0200
> +++ linux-2.6.23/drivers/video/s1d13xxxfb.c     2007-11-02 16:48:34.000000000 +0100
> @@ -540,7 +540,7 @@
>         int ret = 0;
>         u8 revision;
>
> -       dbg("probe called: device is %p\n", dev);
> +       dbg("probe called: device is %p\n", pdev);
>
>         printk(KERN_INFO "Epson S1D13XXX FB Driver\n");
>
> @@ -753,8 +753,11 @@
>  static int __init
>  s1d13xxxfb_init(void)
>  {
> +
> +#ifndef MODULE
>         if (fb_get_options("s1d13xxxfb", NULL))
>                 return -ENODEV;
> +#endif
>
>         return platform_driver_register(&s1d13xxxfb_driver);
>  }
>
>
>________________________________________________________________________
> Stanislav Brabec
> http://www.penguin.cz/~utx
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>

we also need to look at splitting out the "chip revision", which is
currently hard set, as I have had very good results with this driver
and  chip  S1D13506, which is functionally similar but without the
external clocking and without teh internal ram.
 We also have some build dependancies related to  "CONFIG_FB_S1D13XXX"
and  ics1523 , this chip is not used on the full range of S1D13XXX and
causes errors in the build , for chips such as S1D13506.
potentially we could re-use most of the code, but would need a way to
pass in S1D_CHIP_REV and one or 2 other chip specific data items.

Steve

  reply	other threads:[~2007-11-10 23:29 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-10 15:51 Stanislav Brabec
2007-11-10 23:29 ` dave chung [this message]
2007-11-11 15:17   ` Thibaut VARENE
2007-11-13 23:21   ` Kristoffer Ericson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d7b238da0711101529s3384cb6bx928c74cfef8fde0f@mail.gmail.com \
    --to=ponstrip@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=utx@penguin.cz \
    --cc=varenet@parisc-linux.org \
    --subject='Re: [PATCH] drivers/video/s1d13xxxfb.c as module with dbg' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).