LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Paul Menzel <pmenzel+linux-block@molgen.mpg.de>
To: Bart Van Assche <Bart.VanAssche@wdc.com>
Cc: jejb@linux.vnet.ibm.com, regressions@leemhuis.info,
	linux-kernel@vger.kernel.org, linux-block@vger.kernel.org,
	martin.petersen@oracle.com, axboe@kernel.dk,
	linux-scsi@vger.kernel.org
Subject: Re: Regression 4.17-rc1: SSD doesn’t properly resume causing system hang (NULL pointer dereference)
Date: Wed, 25 Apr 2018 14:34:50 +0200	[thread overview]
Message-ID: <db0952af-d603-227e-3d58-ac466eb707a9@molgen.mpg.de> (raw)
In-Reply-To: <df8a54d242adb7c26ceef57d6a0e7a51232f911c.camel@wdc.com>

[-- Attachment #1: Type: text/plain, Size: 1681 bytes --]

Dear Bart,


On 04/25/18 14:26, Bart Van Assche wrote:
> On Wed, 2018-04-25 at 07:37 +0200, Paul Menzel wrote:
>> Am 24.04.2018 um 23:17 schrieb Bart Van Assche:
>>> On Tue, 2018-04-24 at 23:04 +0200, Paul Menzel wrote:
>>>> I applied your change, and rebuilt the Linux kernel. Unfortunately, it
>>>> looks like, it didn’t make a difference.
>>>
>>> In that case I don't know what is causing the failure. Can you run a bisect
>>> to determine which commit introduced this regression?
>>
>> With `scsi_mod.use_blk_mq=n` the system resumes fine, so for to me
>> unknown reasons, that Kconfig option get selected in my Linux kernel
>> configuration. I remember having similar issues when this was enabled by
>> default in Linux 4.13-rc?, so it was just a configuration problem and
>> not a regression. Unfortunately, the Linux configuration files are not
>> under version control, so I cannot check, but it is probably my fault.
>>
>> Sorry for the noise, and please tell me, what I can do to get the option
>> working on this old device.

> Did the same system boot fine with a previous kernel with scsi-mq enabled?

No, as far as I know it never worked, see thread *[Regression 4.13-rc1] 
Resume does not work on Lenovo X60t* [1].

> Anyway, we would like to know what is the root cause such that this NULL
> pointer dereference can be fixed. There are namely plans to remove the
> legacy block layer in the not too distant future.

I’ll be happy to test proposed changes.


Kind regards,

Paul


PS: Your mailer also changed *doesn’t* to *doesn* in the subject line.


[1] https://www.spinics.net/lists/linux-scsi/msg111457.html


[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 5174 bytes --]

      reply	other threads:[~2018-04-25 12:34 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-24 16:14 Paul Menzel
2018-04-24 16:26 ` Regression 4.17-rc1: SSD doesnʼt " Bart Van Assche
2018-04-24 17:10   ` Paul Menzel
2018-04-24 17:31     ` Regression 4.17-rc1: SSD doesn " Bart Van Assche
2018-04-24 17:37       ` Paul Menzel
2018-04-24 18:27         ` Bart Van Assche
2018-04-24 21:04           ` Paul Menzel
2018-04-24 21:17             ` Bart Van Assche
2018-04-25  5:37               ` Paul Menzel
2018-04-25 12:26                 ` Bart Van Assche
2018-04-25 12:34                   ` Paul Menzel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=db0952af-d603-227e-3d58-ac466eb707a9@molgen.mpg.de \
    --to=pmenzel+linux-block@molgen.mpg.de \
    --cc=Bart.VanAssche@wdc.com \
    --cc=axboe@kernel.dk \
    --cc=jejb@linux.vnet.ibm.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=regressions@leemhuis.info \
    --subject='Re: Regression 4.17-rc1: SSD doesn’t properly resume causing system hang (NULL pointer dereference)' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).