LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@infradead.org>
To: Stephen Rothwell <sfr@canb.auug.org.au>,
	Linux Next Mailing List <linux-next@vger.kernel.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	linux-scsi <linux-scsi@vger.kernel.org>,
	"Martin K. Petersen" <martin.petersen@oracle.com>
Subject: Re: linux-next: Tree for Aug 19 (scsi/libsas/)
Date: Tue, 18 Aug 2020 23:30:36 -0700	[thread overview]
Message-ID: <dbbf8037-1e6c-5e66-39e1-3a5f4b0f3249@infradead.org> (raw)
In-Reply-To: <20200819155742.1793a180@canb.auug.org.au>

On 8/18/20 10:57 PM, Stephen Rothwell wrote:
> Hi all,
> 
> Changes since 20200818:
> 

Is this some kind of mis-merge?

In sas_discover.c:

	case SAS_SATA_DEV:
	case SAS_SATA_PM:
#ifdef CONFIG_SCSI_SAS_ATA
		error = sas_discover_sata(dev);
		break;
#else
		pr_notice("ATA device seen but CONFIG_SCSI_SAS_ATA=N so cannot attach\n");
		fallthrough;
#endif
		fallthrough;	/* only for the #else condition above */




  CC [M]  drivers/scsi/libsas/sas_discover.o
In file included from ./../include/linux/compiler_types.h:65:0,
                 from <command-line>:0:
../drivers/scsi/libsas/sas_discover.c: In function 'sas_discover_domain':
../include/linux/compiler_attributes.h:214:41: warning: attribute 'fallthrough' not preceding a case label or default label
 # define fallthrough                    __attribute__((__fallthrough__))
                                         ^
../drivers/scsi/libsas/sas_discover.c:469:3: note: in expansion of macro 'fallthrough'
   fallthrough;
   ^~~~~~~~~~~
  CC      drivers/ide/ide-eh.o
../include/linux/compiler_attributes.h:214:41: error: invalid use of attribute 'fallthrough'
 # define fallthrough                    __attribute__((__fallthrough__))
                                         ^
../drivers/scsi/libsas/sas_discover.c:471:3: note: in expansion of macro 'fallthrough'
   fallthrough; /* only for the #else condition above */
   ^~~~~~~~~~~



-- 
~Randy
Reported-by: Randy Dunlap <rdunlap@infradead.org>

  reply	other threads:[~2020-08-19  6:30 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-19  5:57 linux-next: Tree for Aug 19 Stephen Rothwell
2020-08-19  6:30 ` Randy Dunlap [this message]
2020-08-19  8:09   ` linux-next: Tree for Aug 19 (scsi/libsas/) Stephen Rothwell
2020-08-19  9:24     ` Gustavo A. R. Silva

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dbbf8037-1e6c-5e66-39e1-3a5f4b0f3249@infradead.org \
    --to=rdunlap@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=sfr@canb.auug.org.au \
    --subject='Re: linux-next: Tree for Aug 19 (scsi/libsas/)' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).