LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] staging: r8188eu: core: remove unused variable padapter
@ 2021-09-10 18:31 Saurav Girepunje
  2021-09-10 18:40 ` Pavel Skripkin
  0 siblings, 1 reply; 5+ messages in thread
From: Saurav Girepunje @ 2021-09-10 18:31 UTC (permalink / raw)
  To: Larry.Finger, phil, gregkh, straube.linux, fmdefrancesco,
	paskripkin, saurav.girepunje, linux-staging, linux-kernel
  Cc: saurav.girepunje

Remove unused variable padapter from mp_init_xmit_attrib().

Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com>
---
 drivers/staging/r8188eu/core/rtw_mp.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/r8188eu/core/rtw_mp.c b/drivers/staging/r8188eu/core/rtw_mp.c
index dabdd0406f30..8ac23d2112fb 100644
--- a/drivers/staging/r8188eu/core/rtw_mp.c
+++ b/drivers/staging/r8188eu/core/rtw_mp.c
@@ -75,7 +75,7 @@ static void _init_mp_priv_(struct mp_priv *pmp_priv)
 	memcpy(pnetwork->Ssid.Ssid, "mp_871x", pnetwork->Ssid.SsidLength);
 }

-static void mp_init_xmit_attrib(struct mp_tx *pmptx, struct adapter *padapter)
+static void mp_init_xmit_attrib(struct mp_tx *pmptx)
 {
 	struct pkt_attrib *pattrib;
 	struct tx_desc *desc;
@@ -107,7 +107,7 @@ s32 init_mp_priv(struct adapter *padapter)
 	pmppriv->papdater = padapter;

 	pmppriv->tx.stop = 1;
-	mp_init_xmit_attrib(&pmppriv->tx, padapter);
+	mp_init_xmit_attrib(&pmppriv->tx);

 	switch (padapter->registrypriv.rf_config) {
 	case RF_1T1R:
--
2.32.0


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] staging: r8188eu: core: remove unused variable padapter
  2021-09-10 18:31 [PATCH] staging: r8188eu: core: remove unused variable padapter Saurav Girepunje
@ 2021-09-10 18:40 ` Pavel Skripkin
  0 siblings, 0 replies; 5+ messages in thread
From: Pavel Skripkin @ 2021-09-10 18:40 UTC (permalink / raw)
  To: Saurav Girepunje, Larry.Finger, phil, gregkh, straube.linux,
	fmdefrancesco, linux-staging, linux-kernel
  Cc: saurav.girepunje

On 9/10/21 21:31, Saurav Girepunje wrote:
> Remove unused variable padapter from mp_init_xmit_attrib().
> 
> Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com>

Reviewed-by: Pavel Skripkin <paskripkin@gmail.com>

Thanks!

> ---
>   drivers/staging/r8188eu/core/rtw_mp.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/r8188eu/core/rtw_mp.c b/drivers/staging/r8188eu/core/rtw_mp.c
> index dabdd0406f30..8ac23d2112fb 100644
> --- a/drivers/staging/r8188eu/core/rtw_mp.c
> +++ b/drivers/staging/r8188eu/core/rtw_mp.c
> @@ -75,7 +75,7 @@ static void _init_mp_priv_(struct mp_priv *pmp_priv)
>   	memcpy(pnetwork->Ssid.Ssid, "mp_871x", pnetwork->Ssid.SsidLength);
>   }
> 
> -static void mp_init_xmit_attrib(struct mp_tx *pmptx, struct adapter *padapter)
> +static void mp_init_xmit_attrib(struct mp_tx *pmptx)
>   {
>   	struct pkt_attrib *pattrib;
>   	struct tx_desc *desc;
> @@ -107,7 +107,7 @@ s32 init_mp_priv(struct adapter *padapter)
>   	pmppriv->papdater = padapter;
> 
>   	pmppriv->tx.stop = 1;
> -	mp_init_xmit_attrib(&pmppriv->tx, padapter);
> +	mp_init_xmit_attrib(&pmppriv->tx);
> 
>   	switch (padapter->registrypriv.rf_config) {
>   	case RF_1T1R:
> --
> 2.32.0
> 


With regards,
Pavel Skripkin

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] staging: r8188eu: core: remove unused variable pAdapter
  2021-10-02 15:38 ` Michael Straube
@ 2021-10-02 16:09   ` Saurav Girepunje
  0 siblings, 0 replies; 5+ messages in thread
From: Saurav Girepunje @ 2021-10-02 16:09 UTC (permalink / raw)
  To: Michael Straube, Larry.Finger, phil, gregkh, linux-staging, linux-kernel
  Cc: saurav.girepunje



On 02/10/21 9:08 pm, Michael Straube wrote:
> Thanks for you patch Saurav, just some minor style issue.
> 
> On 10/2/21 17:13, Saurav Girepunje wrote:
>> Remove unused variable pAdapter in Efuse_Read1ByteFromFakeContent.
>>
>> Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com>
>> ---
>>   drivers/staging/r8188eu/core/rtw_efuse.c | 7 +++----
>>   1 file changed, 3 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/staging/r8188eu/core/rtw_efuse.c 
>> b/drivers/staging/r8188eu/core/rtw_efuse.c
>> index 801887f497cf..d33a5b3b4088 100644
>> --- a/drivers/staging/r8188eu/core/rtw_efuse.c
>> +++ b/drivers/staging/r8188eu/core/rtw_efuse.c
>> @@ -28,8 +28,7 @@ u8 fakeBTEfuseModifiedMap[EFUSE_BT_MAX_MAP_LEN] = {0};
>>   #define REG_EFUSE_CTRL        0x0030
>>   #define EFUSE_CTRL            REG_EFUSE_CTRL        /*  E-Fuse 
>> Control. */
>>
>> -static bool Efuse_Read1ByteFromFakeContent(struct adapter *pAdapter,
>> -                       u16 Offset,
>> +static bool Efuse_Read1ByteFromFakeContent(u16 Offset,
>>                          u8 *Value)
> 
> There is no need for a line break here.                 ^
> 
> Other than that looks good to me.
> 
> Thanks,
> Michael

Thanks Michael for review. Yes line break not needed here. I will 
update. I will resend the patch.

Regards,
Saurav

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] staging: r8188eu: core: remove unused variable pAdapter
  2021-10-02 15:13 [PATCH] staging: r8188eu: core: remove unused variable pAdapter Saurav Girepunje
@ 2021-10-02 15:38 ` Michael Straube
  2021-10-02 16:09   ` Saurav Girepunje
  0 siblings, 1 reply; 5+ messages in thread
From: Michael Straube @ 2021-10-02 15:38 UTC (permalink / raw)
  To: Saurav Girepunje, Larry.Finger, phil, gregkh, linux-staging,
	linux-kernel
  Cc: saurav.girepunje

Thanks for you patch Saurav, just some minor style issue.

On 10/2/21 17:13, Saurav Girepunje wrote:
> Remove unused variable pAdapter in Efuse_Read1ByteFromFakeContent.
> 
> Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com>
> ---
>   drivers/staging/r8188eu/core/rtw_efuse.c | 7 +++----
>   1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/staging/r8188eu/core/rtw_efuse.c b/drivers/staging/r8188eu/core/rtw_efuse.c
> index 801887f497cf..d33a5b3b4088 100644
> --- a/drivers/staging/r8188eu/core/rtw_efuse.c
> +++ b/drivers/staging/r8188eu/core/rtw_efuse.c
> @@ -28,8 +28,7 @@ u8 fakeBTEfuseModifiedMap[EFUSE_BT_MAX_MAP_LEN] = {0};
>   #define REG_EFUSE_CTRL		0x0030
>   #define EFUSE_CTRL			REG_EFUSE_CTRL		/*  E-Fuse Control. */
> 
> -static bool Efuse_Read1ByteFromFakeContent(struct adapter *pAdapter,
> -					   u16 Offset,
> +static bool Efuse_Read1ByteFromFakeContent(u16 Offset,
>   					   u8 *Value)

There is no need for a line break here.                 ^

Other than that looks good to me.

Thanks,
Michael

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH] staging: r8188eu: core: remove unused variable pAdapter
@ 2021-10-02 15:13 Saurav Girepunje
  2021-10-02 15:38 ` Michael Straube
  0 siblings, 1 reply; 5+ messages in thread
From: Saurav Girepunje @ 2021-10-02 15:13 UTC (permalink / raw)
  To: Larry.Finger, phil, gregkh, straube.linux, linux-staging, linux-kernel
  Cc: saurav.girepunje

Remove unused variable pAdapter in Efuse_Read1ByteFromFakeContent.

Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com>
---
 drivers/staging/r8188eu/core/rtw_efuse.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/r8188eu/core/rtw_efuse.c b/drivers/staging/r8188eu/core/rtw_efuse.c
index 801887f497cf..d33a5b3b4088 100644
--- a/drivers/staging/r8188eu/core/rtw_efuse.c
+++ b/drivers/staging/r8188eu/core/rtw_efuse.c
@@ -28,8 +28,7 @@ u8 fakeBTEfuseModifiedMap[EFUSE_BT_MAX_MAP_LEN] = {0};
 #define REG_EFUSE_CTRL		0x0030
 #define EFUSE_CTRL			REG_EFUSE_CTRL		/*  E-Fuse Control. */

-static bool Efuse_Read1ByteFromFakeContent(struct adapter *pAdapter,
-					   u16 Offset,
+static bool Efuse_Read1ByteFromFakeContent(u16 Offset,
 					   u8 *Value)
 {
 	if (Offset >= EFUSE_MAX_HW_SIZE)
@@ -96,7 +95,7 @@ ReadEFuseByte(
 	u16 retry;

 	if (pseudo) {
-		Efuse_Read1ByteFromFakeContent(Adapter, _offset, pbuf);
+		Efuse_Read1ByteFromFakeContent(_offset, pbuf);
 		return;
 	}

@@ -134,7 +133,7 @@ u8 efuse_OneByteRead(struct adapter *pAdapter, u16 addr, u8 *data, bool pseudo)
 	u8 result;

 	if (pseudo) {
-		result = Efuse_Read1ByteFromFakeContent(pAdapter, addr, data);
+		result = Efuse_Read1ByteFromFakeContent(addr, data);
 		return result;
 	}
 	/*  -----------------e-fuse reg ctrl --------------------------------- */
--
2.32.0


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2021-10-02 16:09 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-10 18:31 [PATCH] staging: r8188eu: core: remove unused variable padapter Saurav Girepunje
2021-09-10 18:40 ` Pavel Skripkin
2021-10-02 15:13 [PATCH] staging: r8188eu: core: remove unused variable pAdapter Saurav Girepunje
2021-10-02 15:38 ` Michael Straube
2021-10-02 16:09   ` Saurav Girepunje

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).