LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Liang, Kan" <kan.liang@linux.intel.com>
To: Jiri Olsa <jolsa@redhat.com>
Cc: acme@kernel.org, mingo@redhat.com, peterz@infradead.org,
	linux-kernel@vger.kernel.org, namhyung@kernel.org,
	ganapatrao.kulkarni@cavium.com, zhangshaokun@hisilicon.com,
	yao.jin@linux.intel.com, will.deacon@arm.com, ak@linux.intel.com,
	agustinv@codeaurora.org
Subject: Re: [V2 PATCH] perf parse-events: Specially handle uncore event alias in small groups
Date: Wed, 25 Apr 2018 10:42:27 -0400	[thread overview]
Message-ID: <dbc6f99c-3728-3f23-9c38-a91865dbdefe@linux.intel.com> (raw)
In-Reply-To: <20180425142337.GE3396@krava>



On 4/25/2018 10:23 AM, Jiri Olsa wrote:
> On Wed, Apr 25, 2018 at 06:50:18AM -0700, kan.liang@linux.intel.com wrote:
>> From: Kan Liang <kan.liang@linux.intel.com>
>>
>> Perf stat doesn't count the uncore event aliases from the same uncore
>> block in a group, for example:
>>
>>    perf stat -e '{unc_m_cas_count.all,unc_m_clockticks}' -a -I 1000
>>    #           time             counts unit events
>>         1.000447342      <not counted>      unc_m_cas_count.all
>>         1.000447342      <not counted>      unc_m_clockticks
>>         2.000740654      <not counted>      unc_m_cas_count.all
>>         2.000740654      <not counted>      unc_m_clockticks
>>
>> The output is very misleading. It gives a wrong impression that the
>> uncore event doesn't work.
>>
>> An uncore block could be composed by several PMUs. An uncore event alias
>> is a joint name which means the same event runs on all PMUs of a block.
>> Perf doesn't support mixed events from different PMUs in the same group.
>> It is wrong to put uncore event aliases in a big group.
>>
>> The right way is to split the big group into multiple small groups which
>> only include the events from the same PMU.
>> Only uncore event aliases from the same uncore block should be specially
>> handled here. It doesn't make sense to mix the uncore events with other
>> uncore events from different blocks or even core events in a group.
>>
>> With the patch:
>>    #           time             counts unit events
>>       1.001557653            140,833      unc_m_cas_count.all
>>       1.001557653      1,330,231,332      unc_m_clockticks
>>       2.002709483             85,007      unc_m_cas_count.all
>>       2.002709483      1,429,494,563      unc_m_clockticks
> 
> hum, I still can see the original behaviour even with the patch:
>

That's because the data_reads and clockticks are from different uncore 
blocks. The data_reads is a IMC event. The clockticks is a CBOX event.

The patch only supports the events from the same uncore blocks in group.

Thanks,
Kan


> [jolsa@krava perf]$ sudo ./perf stat -e '{data_reads,clockticks}' -a -I 1000
> #           time             counts unit events
>       1.000184929      <not counted> MiB  data_reads
>       1.000184929    <not supported>      clockticks
>       2.000552765      <not counted> MiB  data_reads
>       2.000552765    <not supported>      clockticks
>       3.000846298      <not counted> MiB  data_reads
>       3.000846298    <not supported>      clockticks
>       4.001044852      <not counted> MiB  data_reads
>       4.001044852    <not supported>      clockticks
>       5.001247131      <not counted> MiB  data_reads
>       5.001247131    <not supported>      clockticks
> ^C     5.546917060      <not counted> MiB  data_reads
>       5.546917060    <not supported>      clockticks
> 
> 
> jirka
> 

  reply	other threads:[~2018-04-25 14:42 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-25 13:50 [V2 PATCH] perf parse-events: Specially handle uncore event alias in small groups kan.liang
2018-04-25 14:23 ` Jiri Olsa
2018-04-25 14:42   ` Liang, Kan [this message]
2018-04-25 14:59     ` Jiri Olsa
2018-04-25 15:28       ` Liang, Kan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dbc6f99c-3728-3f23-9c38-a91865dbdefe@linux.intel.com \
    --to=kan.liang@linux.intel.com \
    --cc=acme@kernel.org \
    --cc=agustinv@codeaurora.org \
    --cc=ak@linux.intel.com \
    --cc=ganapatrao.kulkarni@cavium.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --cc=will.deacon@arm.com \
    --cc=yao.jin@linux.intel.com \
    --cc=zhangshaokun@hisilicon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).