From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754680AbeDYOm5 (ORCPT ); Wed, 25 Apr 2018 10:42:57 -0400 Received: from mga18.intel.com ([134.134.136.126]:64597 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754395AbeDYOmb (ORCPT ); Wed, 25 Apr 2018 10:42:31 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,326,1520924400"; d="scan'208";a="194306776" Subject: Re: [V2 PATCH] perf parse-events: Specially handle uncore event alias in small groups To: Jiri Olsa Cc: acme@kernel.org, mingo@redhat.com, peterz@infradead.org, linux-kernel@vger.kernel.org, namhyung@kernel.org, ganapatrao.kulkarni@cavium.com, zhangshaokun@hisilicon.com, yao.jin@linux.intel.com, will.deacon@arm.com, ak@linux.intel.com, agustinv@codeaurora.org References: <1524664218-134407-1-git-send-email-kan.liang@linux.intel.com> <20180425142337.GE3396@krava> From: "Liang, Kan" Message-ID: Date: Wed, 25 Apr 2018 10:42:27 -0400 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20180425142337.GE3396@krava> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/25/2018 10:23 AM, Jiri Olsa wrote: > On Wed, Apr 25, 2018 at 06:50:18AM -0700, kan.liang@linux.intel.com wrote: >> From: Kan Liang >> >> Perf stat doesn't count the uncore event aliases from the same uncore >> block in a group, for example: >> >> perf stat -e '{unc_m_cas_count.all,unc_m_clockticks}' -a -I 1000 >> # time counts unit events >> 1.000447342 unc_m_cas_count.all >> 1.000447342 unc_m_clockticks >> 2.000740654 unc_m_cas_count.all >> 2.000740654 unc_m_clockticks >> >> The output is very misleading. It gives a wrong impression that the >> uncore event doesn't work. >> >> An uncore block could be composed by several PMUs. An uncore event alias >> is a joint name which means the same event runs on all PMUs of a block. >> Perf doesn't support mixed events from different PMUs in the same group. >> It is wrong to put uncore event aliases in a big group. >> >> The right way is to split the big group into multiple small groups which >> only include the events from the same PMU. >> Only uncore event aliases from the same uncore block should be specially >> handled here. It doesn't make sense to mix the uncore events with other >> uncore events from different blocks or even core events in a group. >> >> With the patch: >> # time counts unit events >> 1.001557653 140,833 unc_m_cas_count.all >> 1.001557653 1,330,231,332 unc_m_clockticks >> 2.002709483 85,007 unc_m_cas_count.all >> 2.002709483 1,429,494,563 unc_m_clockticks > > hum, I still can see the original behaviour even with the patch: > That's because the data_reads and clockticks are from different uncore blocks. The data_reads is a IMC event. The clockticks is a CBOX event. The patch only supports the events from the same uncore blocks in group. Thanks, Kan > [jolsa@krava perf]$ sudo ./perf stat -e '{data_reads,clockticks}' -a -I 1000 > # time counts unit events > 1.000184929 MiB data_reads > 1.000184929 clockticks > 2.000552765 MiB data_reads > 2.000552765 clockticks > 3.000846298 MiB data_reads > 3.000846298 clockticks > 4.001044852 MiB data_reads > 4.001044852 clockticks > 5.001247131 MiB data_reads > 5.001247131 clockticks > ^C 5.546917060 MiB data_reads > 5.546917060 clockticks > > > jirka >