LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Colin King (gmail)" <colin.i.king@googlemail.com>
To: Joe Perches <joe@perches.com>,
	Colin Ian King <colin.i.king@googlemail.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-mm@kvack.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] hugetlb: Fix spelling mistake "hierarichal" -> "hierarchical"
Date: Fri, 26 Nov 2021 08:29:59 +0000	[thread overview]
Message-ID: <dcd6ed6a-a915-49b5-a428-f21f2e3e3e00@gmail.com> (raw)
In-Reply-To: <aa7ad39528c768dfd3a33890cf7d14b59ba3a5fc.camel@perches.com>

On 26/11/2021 08:15, Joe Perches wrote:
> On Thu, 2021-11-25 at 09:06 +0000, Colin Ian King wrote:
>> There is a spelling mistake in a literal string and a comment. Fix them.
> []
>> diff --git a/mm/hugetlb_cgroup.c b/mm/hugetlb_cgroup.c
> []
>> @@ -495,11 +495,11 @@ static int hugetlb_cgroup_read_numa_stat(struct seq_file *seq, void *dummy)
>>   	 * The hierarchical total is pretty much the value recorded by the
>>   	 * counter, so use that.
>>   	 */
>> -	seq_printf(seq, "%stotal=%lu", legacy ? "hierarichal_" : "",
>> +	seq_printf(seq, "%stotal=%lu", legacy ? "hierarchical_" : "",
>>   		   page_counter_read(&h_cg->hugepage[idx]) * PAGE_SIZE);
> 
> Not sure this should be changed as seq output is nominally ABI.

This just landed in linux-next, so I doubt many folk are using it. Let's 
fix it before it lands mainline.

> 
>>   
>>   	/*
>> -	 * For each node, transverse the css tree to obtain the hierarichal
>> +	 * For each node, transverse the css tree to obtain the hierarchical
> 
> Fixing the comment typo is good.  Thanks.
> 
> 


  reply	other threads:[~2021-11-26  8:38 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-25  9:06 Colin Ian King
2021-11-26  5:28 ` Muchun Song
2021-11-26  8:15 ` Joe Perches
2021-11-26  8:29   ` Colin King (gmail) [this message]
2021-11-26  8:57     ` Muchun Song

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dcd6ed6a-a915-49b5-a428-f21f2e3e3e00@gmail.com \
    --to=colin.i.king@googlemail.com \
    --cc=akpm@linux-foundation.org \
    --cc=joe@perches.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --subject='Re: [PATCH][next] hugetlb: Fix spelling mistake "hierarichal" -> "hierarchical"' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).