From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E3E2C432BE for ; Tue, 3 Aug 2021 08:45:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0870960555 for ; Tue, 3 Aug 2021 08:45:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234663AbhHCIqE (ORCPT ); Tue, 3 Aug 2021 04:46:04 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:51544 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234573AbhHCIqD (ORCPT ); Tue, 3 Aug 2021 04:46:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1627980352; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iANhlztARO325R7WvNzYfBHyV3Zp037KAmbrWxgTFzY=; b=VbONNOApG4cxHioKOGtgNNneRxg6hkJaZwWI16N4MOVVYzuFC9CYo//jPJKf8z3tX20iRK 55E7MUhGc3iTcQLLB8jRLuY/Aafg3Ep8d1W2rqBaje6eIzgjSjBQ4h4q3jHyiw7n17pKk7 WJ7y3FzsHb/EgH9U8YcfE00NpYxA0Qw= Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-375-OEqxTVlkP3uPEi-_DNbMSg-1; Tue, 03 Aug 2021 04:45:51 -0400 X-MC-Unique: OEqxTVlkP3uPEi-_DNbMSg-1 Received: by mail-ej1-f70.google.com with SMTP id k22-20020a1709061596b02905a370b2f477so743650ejd.17 for ; Tue, 03 Aug 2021 01:45:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=iANhlztARO325R7WvNzYfBHyV3Zp037KAmbrWxgTFzY=; b=WcrRlIedN4Bs6HSOW4znpShFjrgbQKzvxd4rRtcKLZbuO9jNYnrrL8XPDt5wE4fK9F EDJKxkIamE/ulksWVDg1JMp8vSerp2Jtx/iXxJNSdZOgWUSwbpvqr3lNBFL8zJ6Kgevg vooSpIJcPuf81WqpWYChqGqAIAihI9CoUEzsd6CbWzXLm3VACeKUS3KM538g3VtAxJMV ENN55cbo8tnrJYmBR1qgCIf7eNYiVSJD0G2NuRfUEidQ3PJjmBSbYxg7oJ3va9CTl8UF 8tuR8fa3fCtgpkQJGCs6/xWEL9mG/+eNtXjwMGq/VSs1BYomqqYTSXbVUUnpzUBhk9zF 9Ujg== X-Gm-Message-State: AOAM531eB52Rsgx/pbt4/qd/nlsJs/egHE7t9/VnQSrZAtfDpUFG2AiP iSbWx35rZATK7hFg98hdBnSWz3KgDLS9avIlzYCww4ebiPD8bXSFAwY3PxCFOXMwnQG5mPhtH04 t2yvWJLJ5gYCs0RPXCmN3dAUV X-Received: by 2002:a50:da0e:: with SMTP id z14mr24713990edj.73.1627980350569; Tue, 03 Aug 2021 01:45:50 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzCkagRcMhtmbJrZjOBeLVemJvXcgugb6f910OjikZKE8IYSVHjybA/5Uwzx7kONUFePHtjvw== X-Received: by 2002:a50:da0e:: with SMTP id z14mr24713980edj.73.1627980350441; Tue, 03 Aug 2021 01:45:50 -0700 (PDT) Received: from [192.168.10.118] ([93.56.169.140]) by smtp.gmail.com with ESMTPSA id dn18sm7776486edb.42.2021.08.03.01.45.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 03 Aug 2021 01:45:49 -0700 (PDT) Subject: Re: [PATCH v3 08/12] KVM: SVM: add warning for mistmatch between AVIC state and AVIC access page state To: Maxim Levitsky , kvm@vger.kernel.org Cc: Wanpeng Li , Thomas Gleixner , Joerg Roedel , Borislav Petkov , Sean Christopherson , Jim Mattson , "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , "open list:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , Suravee Suthikulpanit , Vitaly Kuznetsov , Ingo Molnar , "H. Peter Anvin" References: <20210802183329.2309921-1-mlevitsk@redhat.com> <20210802183329.2309921-9-mlevitsk@redhat.com> From: Paolo Bonzini Message-ID: Date: Tue, 3 Aug 2021 10:45:48 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210802183329.2309921-9-mlevitsk@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/08/21 20:33, Maxim Levitsky wrote: > > + WARN_ON_ONCE(vcpu->kvm->arch.apic_access_memslot_enabled != > + kvm_vcpu_apicv_active(vcpu)); This should also check !vcpu->kvm->arch.apicv_inhibit_reasons instead of apic_access_memslot_enabled. Paolo