LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Matthias Brugger <matthias.bgg@gmail.com>
To: Hsin-Yi Wang <hsinyi@chromium.org>
Cc: "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Devicetree List <devicetree@vger.kernel.org>,
lkml <linux-kernel@vger.kernel.org>,
linux-mediatek@lists.infradead.org,
Nicolas Boichat <drinkcat@chromium.org>,
Enric Balletbo i Serra <enric.balletbo@collabora.com>,
Daniel Kurtz <djkurtz@chromium.org>
Subject: Re: [PATCH v2 2/2] arm64: dts: mediatek: add mt8173 elm and hana board
Date: Wed, 15 Jan 2020 17:14:09 +0100 [thread overview]
Message-ID: <df0824f0-b546-89fb-e219-a47ad83a0c62@gmail.com> (raw)
In-Reply-To: <CAJMQK-i3TzrxgSQpt8pfN_bc+XZ9jfe537i0eeYFdKqwa_M3gA@mail.gmail.com>
On 15/01/2020 09:53, Hsin-Yi Wang wrote:
> On Tue, Jan 14, 2020 at 11:10 PM Matthias Brugger
> <matthias.bgg@gmail.com> wrote:
>>
>>
>>
>> On 13/01/2020 19:01, Hsin-Yi Wang wrote:
>>> On Fri, Jan 10, 2020 at 9:42 PM Matthias Brugger <matthias.bgg@gmail.com> wrote:
>>>>
>>>>
>>> Thanks, I will address the comments and send next version
>>>>
>>>> On 10/01/2020 08:37, Hsin-Yi Wang wrote:
>>>>> Elm is Acer Chromebook R13. Hana is Lenovo Chromebook. Both uses mt8173
>>>>> SoC.
>>>>>
>>>>> Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
>>>>> ---
>>>>> Changes in v2:
>>>>> - remove downstream nodes and unused nodes
>>>>> - use GPIO_ACTIVE_LOW for ps8640 gpios
>>>>> - move trackpad to hana
>>>>> ---
>>>>> arch/arm64/boot/dts/mediatek/Makefile | 3 +
>>>>> .../dts/mediatek/mt8173-elm-hana-rev7.dts | 27 +
>>>>> .../boot/dts/mediatek/mt8173-elm-hana.dts | 16 +
>>>>> .../boot/dts/mediatek/mt8173-elm-hana.dtsi | 60 +
>>>>> arch/arm64/boot/dts/mediatek/mt8173-elm.dts | 15 +
>>>>> arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi | 1040 +++++++++++++++++
>>>>> 6 files changed, 1161 insertions(+)
>>>>> create mode 100644 arch/arm64/boot/dts/mediatek/mt8173-elm-hana-rev7.dts
>>>>> create mode 100644 arch/arm64/boot/dts/mediatek/mt8173-elm-hana.dts
>>>>> create mode 100644 arch/arm64/boot/dts/mediatek/mt8173-elm-hana.dtsi
>>>>> create mode 100644 arch/arm64/boot/dts/mediatek/mt8173-elm.dts
>>>>> create mode 100644 arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
>>>>>
[...]
>>>>> + compatible = "mediatek,mt6397-rtc";
>>>>> + };
>>>>> +
>>>>> + syscfg_pctl_pmic: syscfg_pctl_pmic@c000 {
>>>>> + compatible = "mediatek,mt6397-pctl-pmic-syscfg",
>>>>> + "syscon";
>>>>> + reg = <0 0x0000c000 0 0x0108>;
>>>>
>>>> not an upstream compatible, please delete the node.
>>>>
>>
>> I think my comment was not correct. I'll have to dig more to understand why we
>> have a compatible without a binding description.
>>
> Here's a similar syscon node that is in a binding document's example:
>
> syscfg_pctl_a: syscfg-pctl-a@10005000 {
> compatible = "mediatek,mt8135-pctl-a-syscfg", "syscon";
> reg = <0 0x10005000 0 0x1000>;
> };
>
> https://elixir.bootlin.com/linux/latest/source/Documentation/devicetree/bindings/pinctrl/pinctrl-mt65xx.txt#L81
>
Yes I know, that's why I said that my first comment was not correct. Just leave
it in.
Regards,
Matthias
next prev parent reply other threads:[~2020-01-15 16:14 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-10 7:37 [PATCH v2 0/2] Add " Hsin-Yi Wang
2020-01-10 7:37 ` [PATCH v2 1/2] dt-bindings: arm64: dts: mediatek: Add mt8173 elm and hana Hsin-Yi Wang
2020-01-10 11:38 ` Enric Balletbo i Serra
2020-01-15 14:52 ` Rob Herring
2020-01-10 7:37 ` [PATCH v2 2/2] arm64: dts: mediatek: add mt8173 elm and hana board Hsin-Yi Wang
2020-01-10 8:52 ` Yingjoe Chen
2020-01-10 13:42 ` Matthias Brugger
2020-01-13 18:01 ` Hsin-Yi Wang
2020-01-14 15:10 ` Matthias Brugger
2020-01-14 15:33 ` Hsin-Yi Wang
2020-01-15 8:53 ` Hsin-Yi Wang
2020-01-15 16:14 ` Matthias Brugger [this message]
2020-01-13 9:29 ` Enric Balletbo i Serra
2020-01-13 18:18 ` Matthias Kaehlcke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=df0824f0-b546-89fb-e219-a47ad83a0c62@gmail.com \
--to=matthias.bgg@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=djkurtz@chromium.org \
--cc=drinkcat@chromium.org \
--cc=enric.balletbo@collabora.com \
--cc=hsinyi@chromium.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--subject='Re: [PATCH v2 2/2] arm64: dts: mediatek: add mt8173 elm and hana board' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).