LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Jike Song" <albcamus@gmail.com>
To: "Ingo Molnar" <mingo@elte.hu>
Cc: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86: fix inline assembly constraints
Date: Thu, 30 Oct 2008 10:31:30 +0800	[thread overview]
Message-ID: <df9815e70810291931i4c00966u8f4493386e376b28@mail.gmail.com> (raw)
In-Reply-To: <20081029163400.GA14866@elte.hu>

On Thu, Oct 30, 2008 at 12:34 AM, Ingo Molnar <mingo@elte.hu> wrote:
>
> * Jike Song <albcamus@gmail.com> wrote:
>>
>> --
>
> that was an easy patch to act upon ;-)
>
>        Ingo
>
Sorry Ingo, I missed your point. Do you mean this patch is trivial or
unnecessary?

Besides, by looking at the inline assembly in kernel,  I found lots of
codes like this:

        static inline void atomic_add(int i, atomic_t *v)
        {
	        asm volatile(LOCK_PREFIX "addl %1,%0"
		             : "=m" (v->counter)
		             : "ir" (i), "m" (v->counter));
        }


Yes, it works. But a little ugly..  Should this be cleaned-up with the
following?

        : "+m" (v->counter)
        : "ir" (i)

If you agrees, I'll send out the patch; otherwise I won't wasting your time ;-)


-- 
Thanks,
Jike

  reply	other threads:[~2008-10-30  2:31 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-29 16:32 Jike Song
2008-10-29 16:32 ` Jike Song
2008-10-29 16:34 ` Ingo Molnar
2008-10-30  2:31   ` Jike Song [this message]
2008-10-30  3:54     ` H. Peter Anvin
2008-10-30  6:40       ` Jike Song
2008-10-30 14:51         ` H. Peter Anvin
2008-10-30 19:29     ` Ingo Molnar
2008-10-31  2:12       ` Jike Song
     [not found] <fa.IZJ3RdF6xWbbMqWVWyYRstzZBsk@ifi.uio.no>
     [not found] ` <fa.L4yER0Vo1brqQzpHIySgWqUN5UM@ifi.uio.no>
     [not found]   ` <fa.rs0w7okAn1If1ilwD81OTzT4rKg@ifi.uio.no>
2008-10-30  3:52     ` Robert Hancock

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=df9815e70810291931i4c00966u8f4493386e376b28@mail.gmail.com \
    --to=albcamus@gmail.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --subject='Re: [PATCH] x86: fix inline assembly constraints' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).