LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Igor Russkikh <igor.russkikh@aquantia.com>
To: Colin King <colin.king@canonical.com>,
	"David S . Miller" <davem@davemloft.net>,
	Pavel Belous <pavel.belous@aquantia.com>,
	Wei Yongjun <weiyongjun1@huawei.com>,
	netdev@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] net: aquantia: fix unsigned numvecs comparison with less than zero
Date: Thu, 10 May 2018 18:36:20 +0300	[thread overview]
Message-ID: <e0d3695f-89cf-f1c6-6284-f244fa58ba64@aquantia.com> (raw)
In-Reply-To: <20180510125201.19707-1-colin.king@canonical.com>


Thanks, Colin!

> The comparison of numvecs < 0 is always false because numvecs is a u32
> and hence the error return from a failed call to pci_alloc_irq_vectores
> is never detected.  Fix this by using the signed int ret to handle the
> error return and assign numvecs to err.
> 
> Detected by CoverityScan, CID#1468650 ("Unsigned compared against 0")
> 
> Fixes: a09bd81b5413 ("net: aquantia: Limit number of vectors to actually allocated irqs")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---

Acked-by: Igor Russkikh <igor.russkikh@aquantia.com>

  reply	other threads:[~2018-05-10 15:36 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-10 12:52 Colin King
2018-05-10 15:36 ` Igor Russkikh [this message]
2018-05-10 21:53 ` David Miller
2018-05-11 12:40   ` Igor Russkikh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e0d3695f-89cf-f1c6-6284-f244fa58ba64@aquantia.com \
    --to=igor.russkikh@aquantia.com \
    --cc=colin.king@canonical.com \
    --cc=davem@davemloft.net \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pavel.belous@aquantia.com \
    --cc=weiyongjun1@huawei.com \
    --subject='Re: [PATCH][next] net: aquantia: fix unsigned numvecs comparison with less than zero' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).