LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Michal Simek <michal.simek@xilinx.com>
To: Jolly Shah <jolly.shah@xilinx.com>,
	ard.biesheuvel@linaro.org, mingo@kernel.org,
	gregkh@linuxfoundation.org, matt@codeblueprint.co.uk,
	sudeep.holla@arm.com, hkallweit1@gmail.com,
	keescook@chromium.org, dmitry.torokhov@gmail.com,
	michal.simek@xilinx.com
Cc: rajanv@xilinx.com, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	Tejas Patel <tejas.patel@xilinx.com>
Subject: Re: [PATCH 2/2] arch: arm64: xilinx: Make zynqmp_firmware driver optional
Date: Mon, 24 Feb 2020 11:43:38 +0100	[thread overview]
Message-ID: <e17afc7e-c070-6134-29cb-9fa7b855bf96@xilinx.com> (raw)
In-Reply-To: <1578596764-29351-3-git-send-email-jolly.shah@xilinx.com>

On 09. 01. 20 20:06, Jolly Shah wrote:
> From: Tejas Patel <tejas.patel@xilinx.com>
> 
> Zynqmp firmware driver requires firmware to be present in system.
> Zynqmp firmware driver will crash if firmware is not present in system.
> For example single arch QEMU, may not have firmware, with such setup
> Linux booting fails.


I think that moving it to firmware Kconfig is good solution. What it is
wrong is that description above where I agree with Sudeep.
It means.
1. User should have option to disable zynqmp firmware driver which is
what this patch allows. It means if someone decides to use different
firmware mechanism it can do it directly by simply y/n option.

2. Autodetection of PMUFW presence is another feature which could be
implemented to have this driver enabled but different mechanism can be
used.

3. Doing this because of missing feature in QEMU is IMHO wrong. QEMU
should be fixed and then you don't have any issue if this should be used
or not.

Just a summary. Remove that QEMU example from commit message and talk to
Edgar to fix single QEMU solution to have that regs mapped all the time.

Thanks,
Michal


  reply	other threads:[~2020-02-24 10:43 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-09 19:06 [PATCH 0/2] " Jolly Shah
2020-01-09 19:06 ` [PATCH 1/2] include: linux: firmware: Correct config dependency of zynqmp_eemi_ops Jolly Shah
2020-02-24 10:35   ` Michal Simek
2020-01-09 19:06 ` [PATCH 2/2] arch: arm64: xilinx: Make zynqmp_firmware driver optional Jolly Shah
2020-02-24 10:43   ` Michal Simek [this message]
2020-02-26  0:12     ` Jolly Shah
2020-01-10 11:54 ` [PATCH 0/2] " Sudeep Holla
2020-01-13  6:46   ` Rajan Vaja
2020-01-13 15:13     ` Sudeep Holla
2020-02-24 10:33     ` Michal Simek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e17afc7e-c070-6134-29cb-9fa7b855bf96@xilinx.com \
    --to=michal.simek@xilinx.com \
    --cc=ard.biesheuvel@linaro.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hkallweit1@gmail.com \
    --cc=jolly.shah@xilinx.com \
    --cc=keescook@chromium.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matt@codeblueprint.co.uk \
    --cc=mingo@kernel.org \
    --cc=rajanv@xilinx.com \
    --cc=sudeep.holla@arm.com \
    --cc=tejas.patel@xilinx.com \
    --subject='Re: [PATCH 2/2] arch: arm64: xilinx: Make zynqmp_firmware driver optional' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).