From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49DCDC4338F for ; Tue, 3 Aug 2021 08:09:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 34FE960F11 for ; Tue, 3 Aug 2021 08:09:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234570AbhHCIJp (ORCPT ); Tue, 3 Aug 2021 04:09:45 -0400 Received: from www62.your-server.de ([213.133.104.62]:44598 "EHLO www62.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234455AbhHCIJT (ORCPT ); Tue, 3 Aug 2021 04:09:19 -0400 Received: from sslproxy06.your-server.de ([78.46.172.3]) by www62.your-server.de with esmtpsa (TLSv1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.92.3) (envelope-from ) id 1mApTi-0001E5-4G; Tue, 03 Aug 2021 10:08:46 +0200 Received: from [85.5.47.65] (helo=linux.home) by sslproxy06.your-server.de with esmtpsa (TLSv1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mApTh-000HvD-J6; Tue, 03 Aug 2021 10:08:45 +0200 Subject: Re: [PATCH net-next 1/2] net/sched: sch_ingress: Support clsact egress mini-Qdisc option To: Cong Wang Cc: Peilin Ye , Jamal Hadi Salim , Jiri Pirko , "David S. Miller" , Jakub Kicinski , Linux Kernel Network Developers , LKML , Cong Wang , Peilin Ye , Alexei Starovoitov , John Fastabend References: <1931ca440b47344fe357d5438aeab4b439943d10.1627936393.git.peilin.ye@bytedance.com> <672e6f13-bf58-d542-6712-e6f803286373@iogearbox.net> From: Daniel Borkmann Message-ID: Date: Tue, 3 Aug 2021 10:08:40 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Authenticated-Sender: daniel@iogearbox.net X-Virus-Scanned: Clear (ClamAV 0.103.2/26251/Mon Aug 2 10:18:34 2021) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/3/21 2:08 AM, Cong Wang wrote: > On Mon, Aug 2, 2021 at 2:11 PM Daniel Borkmann wrote: >> >> NAK, just use clsact qdisc in the first place which has both ingress and egress >> support instead of adding such hack. You already need to change your scripts for >> clsact-on, so just swap 'tc qdisc add dev eth0 ingress' to 'tc qdisc add dev eth0 >> clsact' w/o needing to change kernel. > > If we were able to change the "script" as easily as you described, > you would not even see such a patch. The fact is it is not under > our control, the most we can do is change the qdisc after it is > created by the "script", ideally without interfering its traffic, > hence we have such a patch. > > (BTW, it is actually not a script, it is a cloud platform.) Sigh, so you're trying to solve a non-technical issue with one cloud provider by taking a detour for unnecessarily extending the kernel instead with functionality that already exists in another qdisc (and potentially waiting few years until they eventually upgrade). I presume Bytedance should be a big enough entity to make a case for that provider to change it. After all swapping ingress with clsact for such script is completely transparent and there is nothing that would break. (Fwiw, from all the major cloud providers we have never seen such issue in our deployments.) Thanks, Daniel