LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Bart Van Assche" <bart.vanassche@gmail.com>
To: "Linus Torvalds" <torvalds@linux-foundation.org>
Cc: "Andrew Morton" <akpm@linux-foundation.org>,
	"Dave Young" <hidave.darkstar@gmail.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH][RESEND] C99 initializers for DEFINE_RATELIMIT_STATE()
Date: Mon, 10 Nov 2008 13:43:24 +0100	[thread overview]
Message-ID: <e2e108260811100443j18a6353cj8d47ee3f1f8bec1@mail.gmail.com> (raw)
In-Reply-To: <200811042114.48495.bart.vanassche@gmail.com>

Could someone please be so kind to ACK the patch below, NAK it or tell
me whether I should send the patch below to someone else ?

Thanks,

Bart.

On Tue, Nov 4, 2008 at 9:14 PM, Bart Van Assche
<bart.vanassche@gmail.com> wrote:
> A few months ago (July 25, 2008) the printk ratelimiting code has been
> rewritten. This patch added a.o. the new macro DEFINE_RATELIMIT_STATE(). The
> patch below converts the initializers in that macro to C99 style.
>
> For more information about the printk ratelimiting rewrite, see also commit
> 717115e1a5856b57af0f71e1df7149108294fc10
> (http://git.kernel.org/?p=linux/kernel/git/stable/linux-2.6.27.y.git;a=commit;h=717115e1a5856b57af0f71e1df7149108294fc10).
>
> Impact: cleanup, no functionality changed.
>
> Signed-off-by: Bart Van Assche <bart.vanassche@gmail.com>
>
> diff --git a/include/linux/ratelimit.h b/include/linux/ratelimit.h
> index 18a5b9b..61cc908 100644
> --- a/include/linux/ratelimit.h
> +++ b/include/linux/ratelimit.h
> @@ -13,8 +13,9 @@ struct ratelimit_state {
>        unsigned long begin;
>  };
>
> -#define DEFINE_RATELIMIT_STATE(name, interval, burst)          \
> -               struct ratelimit_state name = {interval, burst,}
> +#define DEFINE_RATELIMIT_STATE(name, interval_value, burst_value)      \
> +       struct ratelimit_state name =                                   \
> +               { .interval = (interval_value), .burst = (burst_value) }
>
>  extern int __ratelimit(struct ratelimit_state *rs);
>

  reply	other threads:[~2008-11-10 12:43 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-04 20:14 Bart Van Assche
2008-11-10 12:43 ` Bart Van Assche [this message]
2008-11-10 17:16   ` Randy Dunlap
2008-11-10 17:30     ` Andrew Morton
2008-11-10 17:34       ` Linus Torvalds
2008-11-10 18:06         ` Bart Van Assche

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e2e108260811100443j18a6353cj8d47ee3f1f8bec1@mail.gmail.com \
    --to=bart.vanassche@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=hidave.darkstar@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    --subject='Re: [PATCH][RESEND] C99 initializers for DEFINE_RATELIMIT_STATE()' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).