LKML Archive on
help / color / mirror / Atom feed
From: "Bart Van Assche" <>
To: "Linus Torvalds" <>
Cc: "Andrew Morton" <>,
	"Randy Dunlap" <>,
	"Dave Young" <>,
Subject: Re: [PATCH][RESEND] C99 initializers for DEFINE_RATELIMIT_STATE()
Date: Mon, 10 Nov 2008 19:06:57 +0100	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Mon, Nov 10, 2008 at 6:34 PM, Linus Torvalds
<> wrote:
> On Mon, 10 Nov 2008, Andrew Morton wrote:
>> I already have a patch queued which does this
>> (linux-ratelimith-fixed-missing-initializer-warning.patch).  I sent it
>> to Linus on October 29 and he did not apply it, so I parked it for 2.6.29.
> I just don't see the point of the patch at all. It doesn't fix anything,
> and it just makes the code bigger and uglier. We have tons of other
> simple initializers that aren't C99, and we're not going to convert them
> either.

The current version of the header file include/linux/ratelimit.h
triggers false positives when the compiler flag
-Wmissing-field-initializers is specified. The header file
include/linux/ratelimit.h is included directly or indirectly by many
other header files -- inclusion of this file can't be avoided. The
above patch suppresses these false positives by converting the
initializers to C99 style, such that kernel developers who want to
check their code through -Wmissing-field-initializers can use this
compiler flag.  And I do not have plans to send patches for converting
initializers to C99-style for any .c file.


      reply	other threads:[~2008-11-10 18:07 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-04 20:14 Bart Van Assche
2008-11-10 12:43 ` Bart Van Assche
2008-11-10 17:16   ` Randy Dunlap
2008-11-10 17:30     ` Andrew Morton
2008-11-10 17:34       ` Linus Torvalds
2008-11-10 18:06         ` Bart Van Assche [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \
    --subject='Re: [PATCH][RESEND] C99 initializers for DEFINE_RATELIMIT_STATE()' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).