LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Subhash Jadavani <subhashj@codeaurora.org>
To: Alim Akhtar <alim.akhtar@samsung.com>
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
	jejb@linux.vnet.ibm.com, martin.petersen@oracle.com,
	vivek.gautam@codeaurora.org, vinholikatti@gmail.com,
	olof@lixom.net
Subject: Re: [PATCH 4/4] scsi: ufs: make ufshcd_config_pwr_mode of non-static func
Date: Wed, 16 May 2018 14:27:04 -0700	[thread overview]
Message-ID: <e3eb556127dcb28d6e0c170a886ab409@codeaurora.org> (raw)
In-Reply-To: <1525601658-31989-5-git-send-email-alim.akhtar@samsung.com>

On 2018-05-06 03:14, Alim Akhtar wrote:
> This makes ufshcd_config_pwr_mode non-static so that other vendors
> like exynos can use the same.
> 
> Signed-off-by: Seungwon Jeon <essuuj@gmail.com>
> Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com>
> ---
>  drivers/scsi/ufs/ufshcd.c | 5 ++---
>  drivers/scsi/ufs/ufshcd.h | 2 ++
>  2 files changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
> index 5bfd385..68aefcd 100644
> --- a/drivers/scsi/ufs/ufshcd.c
> +++ b/drivers/scsi/ufs/ufshcd.c
> @@ -233,8 +233,6 @@ static void ufshcd_suspend_clkscaling(struct 
> ufs_hba *hba);
>  static void __ufshcd_suspend_clkscaling(struct ufs_hba *hba);
>  static int ufshcd_scale_clks(struct ufs_hba *hba, bool scale_up);
>  static irqreturn_t ufshcd_intr(int irq, void *__hba);
> -static int ufshcd_config_pwr_mode(struct ufs_hba *hba,
> -		struct ufs_pa_layer_attr *desired_pwr_mode);
>  static int ufshcd_change_power_mode(struct ufs_hba *hba,
>  			     struct ufs_pa_layer_attr *pwr_mode);
>  static inline bool ufshcd_valid_tag(struct ufs_hba *hba, int tag)
> @@ -3969,7 +3967,7 @@ static int ufshcd_change_power_mode(struct 
> ufs_hba *hba,
>   * @hba: per-adapter instance
>   * @desired_pwr_mode: desired power configuration
>   */
> -static int ufshcd_config_pwr_mode(struct ufs_hba *hba,
> +int ufshcd_config_pwr_mode(struct ufs_hba *hba,
>  		struct ufs_pa_layer_attr *desired_pwr_mode)
>  {
>  	struct ufs_pa_layer_attr final_params = { 0 };
> @@ -3987,6 +3985,7 @@ static int ufshcd_config_pwr_mode(struct ufs_hba 
> *hba,
> 
>  	return ret;
>  }
> +EXPORT_SYMBOL_GPL(ufshcd_config_pwr_mode);
> 
>  /**
>   * ufshcd_complete_dev_init() - checks device readiness
> diff --git a/drivers/scsi/ufs/ufshcd.h b/drivers/scsi/ufs/ufshcd.h
> index 013a07e..b42a5a3 100644
> --- a/drivers/scsi/ufs/ufshcd.h
> +++ b/drivers/scsi/ufs/ufshcd.h
> @@ -805,6 +805,8 @@ extern int ufshcd_dme_set_attr(struct ufs_hba
> *hba, u32 attr_sel,
>  			       u8 attr_set, u32 mib_val, u8 peer);
>  extern int ufshcd_dme_get_attr(struct ufs_hba *hba, u32 attr_sel,
>  			       u32 *mib_val, u8 peer);
> +extern int ufshcd_config_pwr_mode(struct ufs_hba *hba,
> +			struct ufs_pa_layer_attr *desired_pwr_mode);
> 
>  /* UIC command interfaces for DME primitives */
>  #define DME_LOCAL	0

Looks good to me.
Reviewed-by: Subhash Jadavani <subhashj@codeaurora.org>

-- 
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

  parent reply	other threads:[~2018-05-16 21:27 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20180506102636epcas2p3432b71e5c867f6cfec16cf2a8c74b0e2@epcas2p3.samsung.com>
2018-05-06 10:14 ` [PATCH 0/4] Add required changes to ufshcd to support exynos ufs hci Alim Akhtar
     [not found]   ` <CGME20180506102638epcas1p17bea76e1a5dbac535d5d6a10181f7e29@epcas1p1.samsung.com>
2018-05-06 10:14     ` [PATCH 1/4] scsi: ufs: add quirk to fix mishandling utrlclr/utmrlclr Alim Akhtar
2018-05-16 21:23       ` Subhash Jadavani
2018-05-17  4:06       ` Asutosh Das (asd)
     [not found]   ` <CGME20180506102639epcas2p13ac44966a64e539f611ccdc2479e1abb@epcas2p1.samsung.com>
2018-05-06 10:14     ` [PATCH 2/4] scsi: ufs: add quirk not to allow reset of interrupt aggregation Alim Akhtar
2018-05-16 21:24       ` Subhash Jadavani
     [not found]   ` <CGME20180506102641epcas1p40fb2055e82d32d7cfa594af132273d31@epcas1p4.samsung.com>
2018-05-06 10:14     ` [PATCH 3/4] scsi: ufs: add quirk to enable host controller without hce Alim Akhtar
2018-05-16 21:26       ` Subhash Jadavani
     [not found]   ` <CGME20180506102643epcas2p24ed80d7ede859db73c2595724d9c2414@epcas2p2.samsung.com>
2018-05-06 10:14     ` [PATCH 4/4] scsi: ufs: make ufshcd_config_pwr_mode of non-static func Alim Akhtar
2018-05-16  7:51       ` Avri Altman
2018-05-16 21:27       ` Subhash Jadavani [this message]
2018-05-16  4:30   ` [PATCH 0/4] Add required changes to ufshcd to support exynos ufs hci Alim Akhtar
2018-05-18 14:52   ` Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e3eb556127dcb28d6e0c170a886ab409@codeaurora.org \
    --to=subhashj@codeaurora.org \
    --cc=alim.akhtar@samsung.com \
    --cc=jejb@linux.vnet.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=olof@lixom.net \
    --cc=vinholikatti@gmail.com \
    --cc=vivek.gautam@codeaurora.org \
    --subject='Re: [PATCH 4/4] scsi: ufs: make ufshcd_config_pwr_mode of non-static func' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).