LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Shuah Khan <skhan@linuxfoundation.org>
To: cgel.zte@gmail.com, jasowang@redhat.com
Cc: john.stultz@linaro.org, tglx@linutronix.de, sboyd@kernel.org,
	shuah@kernel.org, mst@redhat.com, zhang.yunkai@zte.com.cn,
	linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	Zeal Robot <zealci@zte.com.cn>,
	Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH linux-next] tools: remove unneeded semicolon
Date: Tue, 24 Aug 2021 08:39:56 -0600	[thread overview]
Message-ID: <e501f3f4-2eb7-a742-57ac-34f4f8e83d82@linuxfoundation.org> (raw)
In-Reply-To: <20210802071449.588393-1-zhang.yunkai@zte.com.cn>

On 8/2/21 1:14 AM, cgel.zte@gmail.com wrote:
> From: Zhang Yunkai <zhang.yunkai@zte.com.cn>
> 
> Fix the following coccicheck REVIEW:
> ./tools/testing/selftests/timers/inconsistency-check.c:75:2-3 REVIEW
> Unneeded semicolon
> ./tools/testing/selftests/timers/set-timer-lat.c:83:2-3 REVIEW Unneeded
> semicolon
> ./tools/virtio/virtio-trace/trace-agent-ctl.c:78:2-3 REVIEW Unneeded
> semicolon
> ./tools/testing/selftests/timers/nanosleep.c:75:2-3 REVIEW Unneeded
> semicolon
> ./tools/testing/selftests/timers/nsleep-lat.c:75:2-3 REVIEW Unneeded
> semicolon
> ./tools/testing/selftests/timers/alarmtimer-suspend.c:82:2-3 REVIEW
> Unneeded semicolon
> 
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Zhang Yunkai <zhang.yunkai@zte.com.cn>
> ---
>   tools/testing/selftests/timers/alarmtimer-suspend.c  | 2 +-
>   tools/testing/selftests/timers/inconsistency-check.c | 2 +-
>   tools/testing/selftests/timers/nanosleep.c           | 2 +-
>   tools/testing/selftests/timers/nsleep-lat.c          | 2 +-
>   tools/testing/selftests/timers/set-timer-lat.c       | 2 +-
>   tools/virtio/virtio-trace/trace-agent-ctl.c          | 2 +-
>   6 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/tools/testing/selftests/timers/alarmtimer-suspend.c b/tools/testing/selftests/timers/alarmtimer-suspend.c
> index 4da09dbf83ba..54da4b088f4c 100644
> --- a/tools/testing/selftests/timers/alarmtimer-suspend.c
> +++ b/tools/testing/selftests/timers/alarmtimer-suspend.c
> @@ -79,7 +79,7 @@ char *clockstring(int clockid)
>   		return "CLOCK_BOOTTIME_ALARM";
>   	case CLOCK_TAI:
>   		return "CLOCK_TAI";
> -	};
> +	}
>   	return "UNKNOWN_CLOCKID";
>   }
>   
> diff --git a/tools/testing/selftests/timers/inconsistency-check.c b/tools/testing/selftests/timers/inconsistency-check.c
> index 022d3ffe3fbf..e6756d9c60a7 100644
> --- a/tools/testing/selftests/timers/inconsistency-check.c
> +++ b/tools/testing/selftests/timers/inconsistency-check.c
> @@ -72,7 +72,7 @@ char *clockstring(int clockid)
>   		return "CLOCK_BOOTTIME_ALARM";
>   	case CLOCK_TAI:
>   		return "CLOCK_TAI";
> -	};
> +	}
>   	return "UNKNOWN_CLOCKID";
>   }
>   
> diff --git a/tools/testing/selftests/timers/nanosleep.c b/tools/testing/selftests/timers/nanosleep.c
> index 71b5441c2fd9..433a09676aeb 100644
> --- a/tools/testing/selftests/timers/nanosleep.c
> +++ b/tools/testing/selftests/timers/nanosleep.c
> @@ -72,7 +72,7 @@ char *clockstring(int clockid)
>   		return "CLOCK_BOOTTIME_ALARM";
>   	case CLOCK_TAI:
>   		return "CLOCK_TAI";
> -	};
> +	}
>   	return "UNKNOWN_CLOCKID";
>   }
>   
> diff --git a/tools/testing/selftests/timers/nsleep-lat.c b/tools/testing/selftests/timers/nsleep-lat.c
> index eb3e79ed7b4a..a7ca9825e106 100644
> --- a/tools/testing/selftests/timers/nsleep-lat.c
> +++ b/tools/testing/selftests/timers/nsleep-lat.c
> @@ -72,7 +72,7 @@ char *clockstring(int clockid)
>   		return "CLOCK_BOOTTIME_ALARM";
>   	case CLOCK_TAI:
>   		return "CLOCK_TAI";
> -	};
> +	}
>   	return "UNKNOWN_CLOCKID";
>   }
>   
> diff --git a/tools/testing/selftests/timers/set-timer-lat.c b/tools/testing/selftests/timers/set-timer-lat.c
> index 50da45437daa..d60bbcad487f 100644
> --- a/tools/testing/selftests/timers/set-timer-lat.c
> +++ b/tools/testing/selftests/timers/set-timer-lat.c
> @@ -80,7 +80,7 @@ char *clockstring(int clockid)
>   		return "CLOCK_BOOTTIME_ALARM";
>   	case CLOCK_TAI:
>   		return "CLOCK_TAI";
> -	};
> +	}
>   	return "UNKNOWN_CLOCKID";
>   }
>   
> diff --git a/tools/virtio/virtio-trace/trace-agent-ctl.c b/tools/virtio/virtio-trace/trace-agent-ctl.c
> index 73d253d4b559..39860be6e2d8 100644
> --- a/tools/virtio/virtio-trace/trace-agent-ctl.c
> +++ b/tools/virtio/virtio-trace/trace-agent-ctl.c
> @@ -75,7 +75,7 @@ static int wait_order(int ctl_fd)
>   
>   		if (ret)
>   			break;
> -	};
> +	}
>   
>   	return ret;
>   
> 

We can't accept this patch. The from and Signed-off-by don't match.

thanks,
-- Shuah

  reply	other threads:[~2021-08-24 14:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-02  7:14 cgel.zte
2021-08-24 14:39 ` Shuah Khan [this message]
2021-08-20  3:38 CGEL
2021-08-24 14:41 ` Shuah Khan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e501f3f4-2eb7-a742-57ac-34f4f8e83d82@linuxfoundation.org \
    --to=skhan@linuxfoundation.org \
    --cc=cgel.zte@gmail.com \
    --cc=jasowang@redhat.com \
    --cc=john.stultz@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=sboyd@kernel.org \
    --cc=shuah@kernel.org \
    --cc=tglx@linutronix.de \
    --cc=virtualization@lists.linux-foundation.org \
    --cc=zealci@zte.com.cn \
    --cc=zhang.yunkai@zte.com.cn \
    --subject='Re: [PATCH linux-next] tools: remove unneeded semicolon' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).