LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH v3] drm/dp_mst: Fix return code on sideband message failure
@ 2021-07-06 15:30 Kuogee Hsieh
  2021-07-07  8:37 ` Jani Nikula
  0 siblings, 1 reply; 14+ messages in thread
From: Kuogee Hsieh @ 2021-07-06 15:30 UTC (permalink / raw)
  To: robdclark, sean, swboyd, lyude
  Cc: abhinavk, aravindh, khsieh, rsubbia, rnayak, freedreno, airlied,
	daniel, maarten.lankhorst, jani.nikula, mripard, tzimmermann,
	dri-devel, linux-kernel

From: Rajkumar Subbiah <rsubbia@codeaurora.org>

Commit 2f015ec6eab6 ("drm/dp_mst: Add sideband down request tracing +
selftests") added some debug code for sideband message tracing. But
it seems to have unintentionally changed the behavior on sideband message
failure. It catches and returns failure only if DRM_UT_DP is enabled.
Otherwise it ignores the error code and returns success. So on an MST
unplug, the caller is unaware that the clear payload message failed and
ends up waiting for 4 seconds for the response. Fixes the issue by
returning the proper error code.

Changes in V2:
-- Revise commit text as review comment
-- add Fixes text

Changes in V3:
-- remove "unlikely" optimization

Fixes: 2f015ec6eab6 ("drm/dp_mst: Add sideband down request tracing + selftests")

Signed-off-by: Rajkumar Subbiah <rsubbia@codeaurora.org>
Signed-off-by: Kuogee Hsieh <khsieh@codeaurora.org>

Reviewed-by: Stephen Boyd <swboyd@chromium.org>
---
 drivers/gpu/drm/drm_dp_mst_topology.c | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c b/drivers/gpu/drm/drm_dp_mst_topology.c
index 1590144..df91110 100644
--- a/drivers/gpu/drm/drm_dp_mst_topology.c
+++ b/drivers/gpu/drm/drm_dp_mst_topology.c
@@ -2887,11 +2887,13 @@ static int process_single_tx_qlock(struct drm_dp_mst_topology_mgr *mgr,
 	idx += tosend + 1;
 
 	ret = drm_dp_send_sideband_msg(mgr, up, chunk, idx);
-	if (unlikely(ret) && drm_debug_enabled(DRM_UT_DP)) {
-		struct drm_printer p = drm_debug_printer(DBG_PREFIX);
+	if (ret) {
+		if (drm_debug_enabled(DRM_UT_DP)) {
+			struct drm_printer p = drm_debug_printer(DBG_PREFIX);
 
-		drm_printf(&p, "sideband msg failed to send\n");
-		drm_dp_mst_dump_sideband_msg_tx(&p, txmsg);
+			drm_printf(&p, "sideband msg failed to send\n");
+			drm_dp_mst_dump_sideband_msg_tx(&p, txmsg);
+		}
 		return ret;
 	}
 
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project


^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH v3] drm/dp_mst: Fix return code on sideband message failure
  2021-07-06 15:30 [PATCH v3] drm/dp_mst: Fix return code on sideband message failure Kuogee Hsieh
@ 2021-07-07  8:37 ` Jani Nikula
  2021-07-13 22:24   ` khsieh
  0 siblings, 1 reply; 14+ messages in thread
From: Jani Nikula @ 2021-07-07  8:37 UTC (permalink / raw)
  To: Kuogee Hsieh, robdclark, sean, swboyd, lyude
  Cc: abhinavk, aravindh, khsieh, rsubbia, rnayak, freedreno, airlied,
	daniel, maarten.lankhorst, mripard, tzimmermann, dri-devel,
	linux-kernel

On Tue, 06 Jul 2021, Kuogee Hsieh <khsieh@codeaurora.org> wrote:
> From: Rajkumar Subbiah <rsubbia@codeaurora.org>
>
> Commit 2f015ec6eab6 ("drm/dp_mst: Add sideband down request tracing +
> selftests") added some debug code for sideband message tracing. But
> it seems to have unintentionally changed the behavior on sideband message
> failure. It catches and returns failure only if DRM_UT_DP is enabled.
> Otherwise it ignores the error code and returns success. So on an MST
> unplug, the caller is unaware that the clear payload message failed and
> ends up waiting for 4 seconds for the response. Fixes the issue by
> returning the proper error code.
>
> Changes in V2:
> -- Revise commit text as review comment
> -- add Fixes text
>
> Changes in V3:
> -- remove "unlikely" optimization
>
> Fixes: 2f015ec6eab6 ("drm/dp_mst: Add sideband down request tracing + selftests")
>
> Signed-off-by: Rajkumar Subbiah <rsubbia@codeaurora.org>
> Signed-off-by: Kuogee Hsieh <khsieh@codeaurora.org>
>
> Reviewed-by: Stephen Boyd <swboyd@chromium.org>

Reviewed-by: Jani Nikula <jani.nikula@intel.com>


> ---
>  drivers/gpu/drm/drm_dp_mst_topology.c | 10 ++++++----
>  1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c b/drivers/gpu/drm/drm_dp_mst_topology.c
> index 1590144..df91110 100644
> --- a/drivers/gpu/drm/drm_dp_mst_topology.c
> +++ b/drivers/gpu/drm/drm_dp_mst_topology.c
> @@ -2887,11 +2887,13 @@ static int process_single_tx_qlock(struct drm_dp_mst_topology_mgr *mgr,
>  	idx += tosend + 1;
>  
>  	ret = drm_dp_send_sideband_msg(mgr, up, chunk, idx);
> -	if (unlikely(ret) && drm_debug_enabled(DRM_UT_DP)) {
> -		struct drm_printer p = drm_debug_printer(DBG_PREFIX);
> +	if (ret) {
> +		if (drm_debug_enabled(DRM_UT_DP)) {
> +			struct drm_printer p = drm_debug_printer(DBG_PREFIX);
>  
> -		drm_printf(&p, "sideband msg failed to send\n");
> -		drm_dp_mst_dump_sideband_msg_tx(&p, txmsg);
> +			drm_printf(&p, "sideband msg failed to send\n");
> +			drm_dp_mst_dump_sideband_msg_tx(&p, txmsg);
> +		}
>  		return ret;
>  	}

-- 
Jani Nikula, Intel Open Source Graphics Center

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH v3] drm/dp_mst: Fix return code on sideband message failure
  2021-07-07  8:37 ` Jani Nikula
@ 2021-07-13 22:24   ` khsieh
  2021-07-22 17:53     ` Lyude Paul
  0 siblings, 1 reply; 14+ messages in thread
From: khsieh @ 2021-07-13 22:24 UTC (permalink / raw)
  To: Jani Nikula
  Cc: robdclark, sean, swboyd, lyude, abhinavk, aravindh, rsubbia,
	rnayak, freedreno, airlied, daniel, maarten.lankhorst, mripard,
	tzimmermann, dri-devel, linux-kernel

On 2021-07-07 01:37, Jani Nikula wrote:
> On Tue, 06 Jul 2021, Kuogee Hsieh <khsieh@codeaurora.org> wrote:
>> From: Rajkumar Subbiah <rsubbia@codeaurora.org>
>> 
>> Commit 2f015ec6eab6 ("drm/dp_mst: Add sideband down request tracing +
>> selftests") added some debug code for sideband message tracing. But
>> it seems to have unintentionally changed the behavior on sideband 
>> message
>> failure. It catches and returns failure only if DRM_UT_DP is enabled.
>> Otherwise it ignores the error code and returns success. So on an MST
>> unplug, the caller is unaware that the clear payload message failed 
>> and
>> ends up waiting for 4 seconds for the response. Fixes the issue by
>> returning the proper error code.
>> 
>> Changes in V2:
>> -- Revise commit text as review comment
>> -- add Fixes text
>> 
>> Changes in V3:
>> -- remove "unlikely" optimization
>> 
>> Fixes: 2f015ec6eab6 ("drm/dp_mst: Add sideband down request tracing + 
>> selftests")
>> 
>> Signed-off-by: Rajkumar Subbiah <rsubbia@codeaurora.org>
>> Signed-off-by: Kuogee Hsieh <khsieh@codeaurora.org>
>> 
>> Reviewed-by: Stephen Boyd <swboyd@chromium.org>
> 
> Reviewed-by: Jani Nikula <jani.nikula@intel.com>
> 
> 
>> ---
Lyude,
Any comments from you?
Thanks,

>>  drivers/gpu/drm/drm_dp_mst_topology.c | 10 ++++++----
>>  1 file changed, 6 insertions(+), 4 deletions(-)
>> 
>> diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c 
>> b/drivers/gpu/drm/drm_dp_mst_topology.c
>> index 1590144..df91110 100644
>> --- a/drivers/gpu/drm/drm_dp_mst_topology.c
>> +++ b/drivers/gpu/drm/drm_dp_mst_topology.c
>> @@ -2887,11 +2887,13 @@ static int process_single_tx_qlock(struct 
>> drm_dp_mst_topology_mgr *mgr,
>>  	idx += tosend + 1;
>> 
>>  	ret = drm_dp_send_sideband_msg(mgr, up, chunk, idx);
>> -	if (unlikely(ret) && drm_debug_enabled(DRM_UT_DP)) {
>> -		struct drm_printer p = drm_debug_printer(DBG_PREFIX);
>> +	if (ret) {
>> +		if (drm_debug_enabled(DRM_UT_DP)) {
>> +			struct drm_printer p = drm_debug_printer(DBG_PREFIX);
>> 
>> -		drm_printf(&p, "sideband msg failed to send\n");
>> -		drm_dp_mst_dump_sideband_msg_tx(&p, txmsg);
>> +			drm_printf(&p, "sideband msg failed to send\n");
>> +			drm_dp_mst_dump_sideband_msg_tx(&p, txmsg);
>> +		}
>>  		return ret;
>>  	}

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH v3] drm/dp_mst: Fix return code on sideband message failure
  2021-07-13 22:24   ` khsieh
@ 2021-07-22 17:53     ` Lyude Paul
  2021-07-22 22:28       ` khsieh
  0 siblings, 1 reply; 14+ messages in thread
From: Lyude Paul @ 2021-07-22 17:53 UTC (permalink / raw)
  To: khsieh, Jani Nikula
  Cc: robdclark, sean, swboyd, abhinavk, aravindh, rsubbia, rnayak,
	freedreno, airlied, daniel, maarten.lankhorst, mripard,
	tzimmermann, dri-devel, linux-kernel

On Tue, 2021-07-13 at 15:24 -0700, khsieh@codeaurora.org wrote:
> On 2021-07-07 01:37, Jani Nikula wrote:
> > On Tue, 06 Jul 2021, Kuogee Hsieh <khsieh@codeaurora.org> wrote:
> > > From: Rajkumar Subbiah <rsubbia@codeaurora.org>
> > > 
> > > Commit 2f015ec6eab6 ("drm/dp_mst: Add sideband down request tracing +
> > > selftests") added some debug code for sideband message tracing. But
> > > it seems to have unintentionally changed the behavior on sideband 
> > > message
> > > failure. It catches and returns failure only if DRM_UT_DP is enabled.
> > > Otherwise it ignores the error code and returns success. So on an MST
> > > unplug, the caller is unaware that the clear payload message failed 
> > > and
> > > ends up waiting for 4 seconds for the response. Fixes the issue by
> > > returning the proper error code.
> > > 
> > > Changes in V2:
> > > -- Revise commit text as review comment
> > > -- add Fixes text
> > > 
> > > Changes in V3:
> > > -- remove "unlikely" optimization
> > > 
> > > Fixes: 2f015ec6eab6 ("drm/dp_mst: Add sideband down request tracing + 
> > > selftests")
> > > 
> > > Signed-off-by: Rajkumar Subbiah <rsubbia@codeaurora.org>
> > > Signed-off-by: Kuogee Hsieh <khsieh@codeaurora.org>
> > > 
> > > Reviewed-by: Stephen Boyd <swboyd@chromium.org>
> > 
> > Reviewed-by: Jani Nikula <jani.nikula@intel.com>
> > 
> > 
> > > ---
> Lyude,
> Any comments from you?
> Thanks,

Hey! Sorry did I forget to respond to this?

Reviewed-by: Lyude Paul <lyude@redhat.com>

> 
> > >  drivers/gpu/drm/drm_dp_mst_topology.c | 10 ++++++----
> > >  1 file changed, 6 insertions(+), 4 deletions(-)
> > > 
> > > diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c 
> > > b/drivers/gpu/drm/drm_dp_mst_topology.c
> > > index 1590144..df91110 100644
> > > --- a/drivers/gpu/drm/drm_dp_mst_topology.c
> > > +++ b/drivers/gpu/drm/drm_dp_mst_topology.c
> > > @@ -2887,11 +2887,13 @@ static int process_single_tx_qlock(struct 
> > > drm_dp_mst_topology_mgr *mgr,
> > >         idx += tosend + 1;
> > > 
> > >         ret = drm_dp_send_sideband_msg(mgr, up, chunk, idx);
> > > -       if (unlikely(ret) && drm_debug_enabled(DRM_UT_DP)) {
> > > -               struct drm_printer p = drm_debug_printer(DBG_PREFIX);
> > > +       if (ret) {
> > > +               if (drm_debug_enabled(DRM_UT_DP)) {
> > > +                       struct drm_printer p =
> > > drm_debug_printer(DBG_PREFIX);
> > > 
> > > -               drm_printf(&p, "sideband msg failed to send\n");
> > > -               drm_dp_mst_dump_sideband_msg_tx(&p, txmsg);
> > > +                       drm_printf(&p, "sideband msg failed to send\n");
> > > +                       drm_dp_mst_dump_sideband_msg_tx(&p, txmsg);
> > > +               }
> > >                 return ret;
> > >         }
> 

-- 
Cheers,
 Lyude Paul (she/her)
 Software Engineer at Red Hat


^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH v3] drm/dp_mst: Fix return code on sideband message failure
  2021-07-22 17:53     ` Lyude Paul
@ 2021-07-22 22:28       ` khsieh
  2021-07-27 19:21         ` Lyude Paul
  0 siblings, 1 reply; 14+ messages in thread
From: khsieh @ 2021-07-22 22:28 UTC (permalink / raw)
  To: Lyude Paul
  Cc: Jani Nikula, robdclark, sean, swboyd, abhinavk, aravindh,
	rsubbia, rnayak, freedreno, airlied, daniel, maarten.lankhorst,
	mripard, tzimmermann, dri-devel, linux-kernel

On 2021-07-22 10:53, Lyude Paul wrote:
> On Tue, 2021-07-13 at 15:24 -0700, khsieh@codeaurora.org wrote:
>> On 2021-07-07 01:37, Jani Nikula wrote:
>> > On Tue, 06 Jul 2021, Kuogee Hsieh <khsieh@codeaurora.org> wrote:
>> > > From: Rajkumar Subbiah <rsubbia@codeaurora.org>
>> > >
>> > > Commit 2f015ec6eab6 ("drm/dp_mst: Add sideband down request tracing +
>> > > selftests") added some debug code for sideband message tracing. But
>> > > it seems to have unintentionally changed the behavior on sideband
>> > > message
>> > > failure. It catches and returns failure only if DRM_UT_DP is enabled.
>> > > Otherwise it ignores the error code and returns success. So on an MST
>> > > unplug, the caller is unaware that the clear payload message failed
>> > > and
>> > > ends up waiting for 4 seconds for the response. Fixes the issue by
>> > > returning the proper error code.
>> > >
>> > > Changes in V2:
>> > > -- Revise commit text as review comment
>> > > -- add Fixes text
>> > >
>> > > Changes in V3:
>> > > -- remove "unlikely" optimization
>> > >
>> > > Fixes: 2f015ec6eab6 ("drm/dp_mst: Add sideband down request tracing +
>> > > selftests")
>> > >
>> > > Signed-off-by: Rajkumar Subbiah <rsubbia@codeaurora.org>
>> > > Signed-off-by: Kuogee Hsieh <khsieh@codeaurora.org>
>> > >
>> > > Reviewed-by: Stephen Boyd <swboyd@chromium.org>
>> >
>> > Reviewed-by: Jani Nikula <jani.nikula@intel.com>
>> >
>> >
>> > > ---
>> Lyude,
>> Any comments from you?
>> Thanks,
> 
> Hey! Sorry did I forget to respond to this?
> 
> Reviewed-by: Lyude Paul <lyude@redhat.com>
> 

It looks like this patch is good to go (mainlined).
Anything needed from me to do?
Thanks,

>> 
>> > >  drivers/gpu/drm/drm_dp_mst_topology.c | 10 ++++++----
>> > >  1 file changed, 6 insertions(+), 4 deletions(-)
>> > >
>> > > diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c
>> > > b/drivers/gpu/drm/drm_dp_mst_topology.c
>> > > index 1590144..df91110 100644
>> > > --- a/drivers/gpu/drm/drm_dp_mst_topology.c
>> > > +++ b/drivers/gpu/drm/drm_dp_mst_topology.c
>> > > @@ -2887,11 +2887,13 @@ static int process_single_tx_qlock(struct
>> > > drm_dp_mst_topology_mgr *mgr,
>> > >         idx += tosend + 1;
>> > >
>> > >         ret = drm_dp_send_sideband_msg(mgr, up, chunk, idx);
>> > > -       if (unlikely(ret) && drm_debug_enabled(DRM_UT_DP)) {
>> > > -               struct drm_printer p = drm_debug_printer(DBG_PREFIX);
>> > > +       if (ret) {
>> > > +               if (drm_debug_enabled(DRM_UT_DP)) {
>> > > +                       struct drm_printer p =
>> > > drm_debug_printer(DBG_PREFIX);
>> > >
>> > > -               drm_printf(&p, "sideband msg failed to send\n");
>> > > -               drm_dp_mst_dump_sideband_msg_tx(&p, txmsg);
>> > > +                       drm_printf(&p, "sideband msg failed to send\n");
>> > > +                       drm_dp_mst_dump_sideband_msg_tx(&p, txmsg);
>> > > +               }
>> > >                 return ret;
>> > >         }
>> 

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH v3] drm/dp_mst: Fix return code on sideband message failure
  2021-07-22 22:28       ` khsieh
@ 2021-07-27 19:21         ` Lyude Paul
  2021-07-27 22:41           ` khsieh
  0 siblings, 1 reply; 14+ messages in thread
From: Lyude Paul @ 2021-07-27 19:21 UTC (permalink / raw)
  To: khsieh
  Cc: Jani Nikula, robdclark, sean, swboyd, abhinavk, aravindh,
	rsubbia, rnayak, freedreno, airlied, daniel, maarten.lankhorst,
	mripard, tzimmermann, dri-devel, linux-kernel

On Thu, 2021-07-22 at 15:28 -0700, khsieh@codeaurora.org wrote:
> 
> It looks like this patch is good to go (mainlined).
> Anything needed from me to do?
> Thanks,

Do you have access for pushing this patch? If not let me know and I can go
ahead and push it to drm-misc-next for you.

-- 
Cheers,
 Lyude Paul (she/her)
 Software Engineer at Red Hat


^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH v3] drm/dp_mst: Fix return code on sideband message failure
  2021-07-27 19:21         ` Lyude Paul
@ 2021-07-27 22:41           ` khsieh
  2021-07-27 22:44             ` Lyude Paul
  0 siblings, 1 reply; 14+ messages in thread
From: khsieh @ 2021-07-27 22:41 UTC (permalink / raw)
  To: Lyude Paul
  Cc: Jani Nikula, robdclark, sean, swboyd, abhinavk, aravindh,
	rsubbia, rnayak, freedreno, airlied, daniel, maarten.lankhorst,
	mripard, tzimmermann, dri-devel, linux-kernel

On 2021-07-27 12:21, Lyude Paul wrote:
> On Thu, 2021-07-22 at 15:28 -0700, khsieh@codeaurora.org wrote:
>> 
>> It looks like this patch is good to go (mainlined).
>> Anything needed from me to do?
>> Thanks,
> 
> Do you have access for pushing this patch? If not let me know and I can 
> go
> ahead and push it to drm-misc-next for you.
no, I do not have access to drm-misc-next.
Please push it for me.
Thanks a lots.

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH v3] drm/dp_mst: Fix return code on sideband message failure
  2021-07-27 22:41           ` khsieh
@ 2021-07-27 22:44             ` Lyude Paul
  2021-08-25 16:06               ` khsieh
  0 siblings, 1 reply; 14+ messages in thread
From: Lyude Paul @ 2021-07-27 22:44 UTC (permalink / raw)
  To: khsieh
  Cc: Jani Nikula, robdclark, sean, swboyd, abhinavk, aravindh,
	rsubbia, rnayak, freedreno, airlied, daniel, maarten.lankhorst,
	mripard, tzimmermann, dri-devel, linux-kernel

Nice timing, you literally got me as I was 2 minutes away from leaving work
for the day :P. I will go ahead and push it now.

BTW - in the future I recommend using dim to add Fixes: tags as it'll add Cc:
to stable as appropriate (this patch in particular should be Cc:
stable@vger.kernel.org # v5.3+). will add these tags when I push it

On Tue, 2021-07-27 at 15:41 -0700, khsieh@codeaurora.org wrote:
> On 2021-07-27 12:21, Lyude Paul wrote:
> > On Thu, 2021-07-22 at 15:28 -0700, khsieh@codeaurora.org wrote:
> > > 
> > > It looks like this patch is good to go (mainlined).
> > > Anything needed from me to do?
> > > Thanks,
> > 
> > Do you have access for pushing this patch? If not let me know and I can 
> > go
> > ahead and push it to drm-misc-next for you.
> no, I do not have access to drm-misc-next.
> Please push it for me.
> Thanks a lots.
> 

-- 
Cheers,
 Lyude Paul (she/her)
 Software Engineer at Red Hat


^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH v3] drm/dp_mst: Fix return code on sideband message failure
  2021-07-27 22:44             ` Lyude Paul
@ 2021-08-25 16:06               ` khsieh
  2021-08-25 16:26                 ` Lyude Paul
  0 siblings, 1 reply; 14+ messages in thread
From: khsieh @ 2021-08-25 16:06 UTC (permalink / raw)
  To: Lyude Paul
  Cc: Jani Nikula, robdclark, sean, swboyd, abhinavk, aravindh,
	rsubbia, rnayak, freedreno, airlied, daniel, maarten.lankhorst,
	mripard, tzimmermann, dri-devel, linux-kernel

On 2021-07-27 15:44, Lyude Paul wrote:
> Nice timing, you literally got me as I was 2 minutes away from leaving 
> work
> for the day :P. I will go ahead and push it now.
> 
Hi Lyude,

Had you pushed this patch yet?
We still did not see this patch at msm-nex and v5.10 branch.
Thanks,


> BTW - in the future I recommend using dim to add Fixes: tags as it'll 
> add Cc:
> to stable as appropriate (this patch in particular should be Cc:
> stable@vger.kernel.org # v5.3+). will add these tags when I push it
> 
> On Tue, 2021-07-27 at 15:41 -0700, khsieh@codeaurora.org wrote:
>> On 2021-07-27 12:21, Lyude Paul wrote:
>> > On Thu, 2021-07-22 at 15:28 -0700, khsieh@codeaurora.org wrote:
>> > >
>> > > It looks like this patch is good to go (mainlined).
>> > > Anything needed from me to do?
>> > > Thanks,
>> >
>> > Do you have access for pushing this patch? If not let me know and I can
>> > go
>> > ahead and push it to drm-misc-next for you.
>> no, I do not have access to drm-misc-next.
>> Please push it for me.
>> Thanks a lots.
>> 

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH v3] drm/dp_mst: Fix return code on sideband message failure
  2021-08-25 16:06               ` khsieh
@ 2021-08-25 16:26                 ` Lyude Paul
  2021-08-30 15:56                   ` khsieh
  0 siblings, 1 reply; 14+ messages in thread
From: Lyude Paul @ 2021-08-25 16:26 UTC (permalink / raw)
  To: khsieh
  Cc: Jani Nikula, robdclark, sean, swboyd, abhinavk, aravindh,
	rsubbia, rnayak, freedreno, airlied, daniel, maarten.lankhorst,
	mripard, tzimmermann, dri-devel, linux-kernel

The patch was pushed yes (was part of drm-misc-next-2021-07-29), seems like it
just hasn't trickled down to linus's branch quite yet.

On Wed, 2021-08-25 at 09:06 -0700, khsieh@codeaurora.org wrote:
> On 2021-07-27 15:44, Lyude Paul wrote:
> > Nice timing, you literally got me as I was 2 minutes away from leaving 
> > work
> > for the day :P. I will go ahead and push it now.
> > 
> Hi Lyude,
> 
> Had you pushed this patch yet?
> We still did not see this patch at msm-nex and v5.10 branch.
> Thanks,
> 
> 
> > BTW - in the future I recommend using dim to add Fixes: tags as it'll 
> > add Cc:
> > to stable as appropriate (this patch in particular should be Cc:
> > stable@vger.kernel.org # v5.3+). will add these tags when I push it
> > 
> > On Tue, 2021-07-27 at 15:41 -0700, khsieh@codeaurora.org wrote:
> > > On 2021-07-27 12:21, Lyude Paul wrote:
> > > > On Thu, 2021-07-22 at 15:28 -0700, khsieh@codeaurora.org wrote:
> > > > > 
> > > > > It looks like this patch is good to go (mainlined).
> > > > > Anything needed from me to do?
> > > > > Thanks,
> > > > 
> > > > Do you have access for pushing this patch? If not let me know and I
> > > > can
> > > > go
> > > > ahead and push it to drm-misc-next for you.
> > > no, I do not have access to drm-misc-next.
> > > Please push it for me.
> > > Thanks a lots.
> > > 
> 

-- 
Cheers,
 Lyude Paul (she/her)
 Software Engineer at Red Hat


^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH v3] drm/dp_mst: Fix return code on sideband message failure
  2021-08-25 16:26                 ` Lyude Paul
@ 2021-08-30 15:56                   ` khsieh
  2021-08-30 16:58                     ` Lyude Paul
  0 siblings, 1 reply; 14+ messages in thread
From: khsieh @ 2021-08-30 15:56 UTC (permalink / raw)
  To: Lyude Paul
  Cc: Jani Nikula, robdclark, sean, swboyd, abhinavk, aravindh,
	rsubbia, rnayak, freedreno, airlied, daniel, maarten.lankhorst,
	mripard, tzimmermann, dri-devel, linux-kernel

On 2021-08-25 09:26, Lyude Paul wrote:
> The patch was pushed yes (was part of drm-misc-next-2021-07-29), seems 
> like it
> just hasn't trickled down to linus's branch quite yet.

Hi Stephen B,

Would you mind back porting this patch to V5.10 branch?
It will have lots of helps for us to support display port MST case.
Thanks,



> 
> On Wed, 2021-08-25 at 09:06 -0700, khsieh@codeaurora.org wrote:
>> On 2021-07-27 15:44, Lyude Paul wrote:
>> > Nice timing, you literally got me as I was 2 minutes away from leaving
>> > work
>> > for the day :P. I will go ahead and push it now.
>> >
>> Hi Lyude,
>> 
>> Had you pushed this patch yet?
>> We still did not see this patch at msm-nex and v5.10 branch.
>> Thanks,
>> 
>> 
>> > BTW - in the future I recommend using dim to add Fixes: tags as it'll
>> > add Cc:
>> > to stable as appropriate (this patch in particular should be Cc:
>> > stable@vger.kernel.org # v5.3+). will add these tags when I push it
>> >
>> > On Tue, 2021-07-27 at 15:41 -0700, khsieh@codeaurora.org wrote:
>> > > On 2021-07-27 12:21, Lyude Paul wrote:
>> > > > On Thu, 2021-07-22 at 15:28 -0700, khsieh@codeaurora.org wrote:
>> > > > >
>> > > > > It looks like this patch is good to go (mainlined).
>> > > > > Anything needed from me to do?
>> > > > > Thanks,
>> > > >
>> > > > Do you have access for pushing this patch? If not let me know and I
>> > > > can
>> > > > go
>> > > > ahead and push it to drm-misc-next for you.
>> > > no, I do not have access to drm-misc-next.
>> > > Please push it for me.
>> > > Thanks a lots.
>> > >
>> 

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH v3] drm/dp_mst: Fix return code on sideband message failure
  2021-08-30 15:56                   ` khsieh
@ 2021-08-30 16:58                     ` Lyude Paul
  2021-08-30 22:57                       ` Stephen Boyd
  2021-09-07 20:47                       ` khsieh
  0 siblings, 2 replies; 14+ messages in thread
From: Lyude Paul @ 2021-08-30 16:58 UTC (permalink / raw)
  To: khsieh
  Cc: Jani Nikula, robdclark, sean, swboyd, abhinavk, aravindh,
	rsubbia, rnayak, freedreno, airlied, daniel, maarten.lankhorst,
	mripard, tzimmermann, dri-devel, linux-kernel

On Mon, 2021-08-30 at 08:56 -0700, khsieh@codeaurora.org wrote:
> On 2021-08-25 09:26, Lyude Paul wrote:
> > The patch was pushed yes (was part of drm-misc-next-2021-07-29), seems 
> > like it
> > just hasn't trickled down to linus's branch quite yet.
> 
> Hi Stephen B,
> 
> Would you mind back porting this patch to V5.10 branch?
> It will have lots of helps for us to support display port MST case.
> Thanks,

I'm assuming you're talking to someone else? A little confused because I don't
see a Stephen B in this thread

> 
> 
> 
> > 
> > On Wed, 2021-08-25 at 09:06 -0700, khsieh@codeaurora.org wrote:
> > > On 2021-07-27 15:44, Lyude Paul wrote:
> > > > Nice timing, you literally got me as I was 2 minutes away from leaving
> > > > work
> > > > for the day :P. I will go ahead and push it now.
> > > > 
> > > Hi Lyude,
> > > 
> > > Had you pushed this patch yet?
> > > We still did not see this patch at msm-nex and v5.10 branch.
> > > Thanks,
> > > 
> > > 
> > > > BTW - in the future I recommend using dim to add Fixes: tags as it'll
> > > > add Cc:
> > > > to stable as appropriate (this patch in particular should be Cc:
> > > > stable@vger.kernel.org # v5.3+). will add these tags when I push it
> > > > 
> > > > On Tue, 2021-07-27 at 15:41 -0700, khsieh@codeaurora.org wrote:
> > > > > On 2021-07-27 12:21, Lyude Paul wrote:
> > > > > > On Thu, 2021-07-22 at 15:28 -0700, khsieh@codeaurora.org wrote:
> > > > > > > 
> > > > > > > It looks like this patch is good to go (mainlined).
> > > > > > > Anything needed from me to do?
> > > > > > > Thanks,
> > > > > > 
> > > > > > Do you have access for pushing this patch? If not let me know and
> > > > > > I
> > > > > > can
> > > > > > go
> > > > > > ahead and push it to drm-misc-next for you.
> > > > > no, I do not have access to drm-misc-next.
> > > > > Please push it for me.
> > > > > Thanks a lots.
> > > > > 
> > > 
> 

-- 
Cheers,
 Lyude Paul (she/her)
 Software Engineer at Red Hat


^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH v3] drm/dp_mst: Fix return code on sideband message failure
  2021-08-30 16:58                     ` Lyude Paul
@ 2021-08-30 22:57                       ` Stephen Boyd
  2021-09-07 20:47                       ` khsieh
  1 sibling, 0 replies; 14+ messages in thread
From: Stephen Boyd @ 2021-08-30 22:57 UTC (permalink / raw)
  To: Lyude Paul, khsieh
  Cc: Jani Nikula, robdclark, sean, abhinavk, aravindh, rsubbia,
	rnayak, freedreno, airlied, daniel, maarten.lankhorst, mripard,
	tzimmermann, dri-devel, linux-kernel

Quoting Lyude Paul (2021-08-30 09:58:01)
> On Mon, 2021-08-30 at 08:56 -0700, khsieh@codeaurora.org wrote:
> > On 2021-08-25 09:26, Lyude Paul wrote:
> > > The patch was pushed yes (was part of drm-misc-next-2021-07-29), seems
> > > like it
> > > just hasn't trickled down to linus's branch quite yet.
> >
> > Hi Stephen B,
> >
> > Would you mind back porting this patch to V5.10 branch?
> > It will have lots of helps for us to support display port MST case.
> > Thanks,

If the patch is tagged for stable then it will automatically be
backported to the 5.10 stable release, or at least attempted. If you
don't see it in the stable tree but it's in Linus' tree then you can
submit the patch directly to stable.  See
Documentation/process/stable-kernel-rules.rst for more info.

>
> I'm assuming you're talking to someone else? A little confused because I don't
> see a Stephen B in this thread

I assume it is me.

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH v3] drm/dp_mst: Fix return code on sideband message failure
  2021-08-30 16:58                     ` Lyude Paul
  2021-08-30 22:57                       ` Stephen Boyd
@ 2021-09-07 20:47                       ` khsieh
  1 sibling, 0 replies; 14+ messages in thread
From: khsieh @ 2021-09-07 20:47 UTC (permalink / raw)
  To: Lyude Paul
  Cc: Jani Nikula, robdclark, sean, swboyd, abhinavk, aravindh,
	rsubbia, rnayak, freedreno, airlied, daniel, maarten.lankhorst,
	mripard, tzimmermann, dri-devel, linux-kernel

On 2021-08-30 09:58, Lyude Paul wrote:
> On Mon, 2021-08-30 at 08:56 -0700, khsieh@codeaurora.org wrote:
>> On 2021-08-25 09:26, Lyude Paul wrote:
>> > The patch was pushed yes (was part of drm-misc-next-2021-07-29), seems
>> > like it
>> > just hasn't trickled down to linus's branch quite yet.
>> 
>> Hi Stephen B,
>> 
>> Would you mind back porting this patch to V5.10 branch?
>> It will have lots of helps for us to support display port MST case.
>> Thanks,
> 
> I'm assuming you're talking to someone else? A little confused because 
> I don't
> see a Stephen B in this thread

Yes,
I am asking Stephen B (swbody@chromium.org) helps to back port this 
patch to v5.10.
> 
>> 
>> 
>> 
>> >
>> > On Wed, 2021-08-25 at 09:06 -0700, khsieh@codeaurora.org wrote:
>> > > On 2021-07-27 15:44, Lyude Paul wrote:
>> > > > Nice timing, you literally got me as I was 2 minutes away from leaving
>> > > > work
>> > > > for the day :P. I will go ahead and push it now.
>> > > >
>> > > Hi Lyude,
>> > >
>> > > Had you pushed this patch yet?
>> > > We still did not see this patch at msm-nex and v5.10 branch.
>> > > Thanks,
>> > >
>> > >
>> > > > BTW - in the future I recommend using dim to add Fixes: tags as it'll
>> > > > add Cc:
>> > > > to stable as appropriate (this patch in particular should be Cc:
>> > > > stable@vger.kernel.org # v5.3+). will add these tags when I push it
>> > > >
>> > > > On Tue, 2021-07-27 at 15:41 -0700, khsieh@codeaurora.org wrote:
>> > > > > On 2021-07-27 12:21, Lyude Paul wrote:
>> > > > > > On Thu, 2021-07-22 at 15:28 -0700, khsieh@codeaurora.org wrote:
>> > > > > > >
>> > > > > > > It looks like this patch is good to go (mainlined).
>> > > > > > > Anything needed from me to do?
>> > > > > > > Thanks,
>> > > > > >
>> > > > > > Do you have access for pushing this patch? If not let me know and
>> > > > > > I
>> > > > > > can
>> > > > > > go
>> > > > > > ahead and push it to drm-misc-next for you.
>> > > > > no, I do not have access to drm-misc-next.
>> > > > > Please push it for me.
>> > > > > Thanks a lots.
>> > > > >
>> > >
>> 

^ permalink raw reply	[flat|nested] 14+ messages in thread

end of thread, other threads:[~2021-09-07 20:47 UTC | newest]

Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-06 15:30 [PATCH v3] drm/dp_mst: Fix return code on sideband message failure Kuogee Hsieh
2021-07-07  8:37 ` Jani Nikula
2021-07-13 22:24   ` khsieh
2021-07-22 17:53     ` Lyude Paul
2021-07-22 22:28       ` khsieh
2021-07-27 19:21         ` Lyude Paul
2021-07-27 22:41           ` khsieh
2021-07-27 22:44             ` Lyude Paul
2021-08-25 16:06               ` khsieh
2021-08-25 16:26                 ` Lyude Paul
2021-08-30 15:56                   ` khsieh
2021-08-30 16:58                     ` Lyude Paul
2021-08-30 22:57                       ` Stephen Boyd
2021-09-07 20:47                       ` khsieh

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).