LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Vineet Gupta <Vineet.Gupta1@synopsys.com>
To: Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>,
	"linux-snps-arc@lists.infradead.org"
	<linux-snps-arc@lists.infradead.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Alexey Brodkin" <Alexey.Brodkin@synopsys.com>
Subject: Re: [PATCH 1/2] ARC: define __ALIGN_STR and __ALIGN symbols for ARC
Date: Wed, 11 Mar 2020 16:35:40 +0000	[thread overview]
Message-ID: <e7b583c8-6189-cf4d-1df5-402fdc2e896c@synopsys.com> (raw)
In-Reply-To: <20200311162644.7667-1-Eugeniy.Paltsev@synopsys.com>

On 3/11/20 9:26 AM, Eugeniy Paltsev wrote:
> As of today ARC uses generic __ALIGN_STR and __ALIGN symbol
> definitions from "include/linux/linkage.h"
> They are defined to ".align 4,0x90" which instructed the assembler
> to use `0x90` as a fill byte when aligning functions declared with
> ENTRY or similar macroses. This leads to generated weird instructions
> in code (when alignment is used) like "ldh_s r12,[r0,0x20]" which is
> encoded as 0x9090 for ARCv2.
> 
> Let's use ".align 4" which insert a "nop_s" instruction instead.
> 
> Signed-off-by: Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>

Acked-by: Vineet Gupta <vgupta@synopsys.com>

-Vineet

      parent reply	other threads:[~2020-03-11 16:36 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-11 16:26 Eugeniy Paltsev
2020-03-11 16:26 ` [PATCH 2/2] ARC: don't align ret_from_exception function Eugeniy Paltsev
2020-03-11 17:38   ` Vineet Gupta
2020-03-11 20:58     ` Eugeniy Paltsev
2020-03-11 21:10       ` Vineet Gupta
2020-03-11 22:28         ` Eugeniy Paltsev
2020-03-11 16:35 ` Vineet Gupta [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e7b583c8-6189-cf4d-1df5-402fdc2e896c@synopsys.com \
    --to=vineet.gupta1@synopsys.com \
    --cc=Alexey.Brodkin@synopsys.com \
    --cc=Eugeniy.Paltsev@synopsys.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-snps-arc@lists.infradead.org \
    --subject='Re: [PATCH 1/2] ARC: define __ALIGN_STR and __ALIGN symbols for ARC' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).