LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Andy Lutomirski <luto@amacapital.net>
To: x86@kernel.org, linux-kernel@vger.kernel.org
Cc: Andi Kleen <andi@firstfloor.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Andy Lutomirski <luto@amacapital.net>
Subject: [PATCH 2/2] x86_64, switch_to: Fix an incorrect comment
Date: Mon,  8 Dec 2014 11:44:15 -0800	[thread overview]
Message-ID: <e7f8e32b0d7604551079aa0f1cd33cb9b843ab71.1418067750.git.luto@amacapital.net> (raw)
In-Reply-To: <cover.1418067750.git.luto@amacapital.net>
In-Reply-To: <cover.1418067750.git.luto@amacapital.net>

I have no idea why load_sp0 would have anything to do with the page
table pointer (i.e. cr3).

Signed-off-by: Andy Lutomirski <luto@amacapital.net>
---
 arch/x86/kernel/process_64.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/arch/x86/kernel/process_64.c b/arch/x86/kernel/process_64.c
index e2efaa3473fa..726aa694991f 100644
--- a/arch/x86/kernel/process_64.c
+++ b/arch/x86/kernel/process_64.c
@@ -283,9 +283,7 @@ __switch_to(struct task_struct *prev_p, struct task_struct *next_p)
 
 	fpu = switch_fpu_prepare(prev_p, next_p, cpu);
 
-	/*
-	 * Reload esp0, LDT and the page table pointer:
-	 */
+	/* Reload esp0 and ss1. */
 	load_sp0(tss, next);
 
 	/* We must save %fs and %gs before load_TLS() because
-- 
1.9.3


      parent reply	other threads:[~2014-12-08 19:44 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-08 19:44 [PATCH 0/2] x86_64: switch_to fixes Andy Lutomirski
2014-12-08 19:44 ` [PATCH 1/2] x86_64, switch_to: Load TLS descriptors before switching DS and ES Andy Lutomirski
2014-12-08 19:44 ` Andy Lutomirski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e7f8e32b0d7604551079aa0f1cd33cb9b843ab71.1418067750.git.luto@amacapital.net \
    --to=luto@amacapital.net \
    --cc=andi@firstfloor.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    --subject='Re: [PATCH 2/2] x86_64, switch_to: Fix an incorrect comment' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).