Re: [PATCH 1/2] dt-bindings: usb: atmel: add USB PHY type property

[<Cristian.Birsan@microchip.com>]

Hi Sergei,

On 9/10/21 10:07 PM, Sergei Shtylyov wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> Hello!
> 
> On 9/10/21 7:38 PM, cristian.birsan@microchip.com wrote:
> 
>> From: Cristian Birsan <cristian.birsan@microchip.com>
>>
>> Add USB PHY type property for controllers with HSIC support.
>>
>> Signed-off-by: Cristian Birsan <cristian.birsan@microchip.com>
>> ---
>>  Documentation/devicetree/bindings/usb/atmel-usb.txt | 4 ++++
>>  1 file changed, 4 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/usb/atmel-usb.txt b/Documentation/devicetree/bindings/usb/atmel-usb.txt
>> index a4002624ba14..f512f0290728 100644
>> --- a/Documentation/devicetree/bindings/usb/atmel-usb.txt
>> +++ b/Documentation/devicetree/bindings/usb/atmel-usb.txt
>> @@ -39,6 +39,10 @@ Required properties:
>>               "ehci_clk" for the peripheral clock
>>               "usb_clk" for the UTMI clock
>>
>> +Optional properties:
>> + - phy_type : For multi port host USB controllers, should be one of
> 
>    Hyphens are preferred to underscores in the property names.
> 

Thank you for looking at my patch.

The property is used with underscore in several places, including Generic USB Controller Device Tree Bindings:

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/usb/usb.yaml?h=v5.15-rc1#n33

I preferred to used the same pattern and not add a slightly different property string for the same thing.

>> +   "utmi", or "hsic".
>> +
>>  usb1: ehci@800000 {
>>       compatible = "atmel,at91sam9g45-ehci", "usb-ehci";
>>       reg = <0x00800000 0x100000>;
> 
> MBR, Sergei
> 

Kind regards,
Cristian