LKML Archive on lore.kernel.org help / color / mirror / Atom feed
From: "Dan Williams" <dan.j.williams@intel.com> To: "Haavard Skinnemoen" <hskinnemoen@atmel.com> Cc: "Olof Johansson" <olof@lixom.net>, linux-kernel@vger.kernel.org, "Shannon Nelson" <shannon.nelson@intel.com>, "David Brownell" <david-b@pacbell.net>, kernel@avr32linux.org, "Francis Moreau" <francis.moro@gmail.com>, "Paul Mundt" <lethal@linux-sh.org>, "Vladimir A. Barinov" <vbarinov@ru.mvista.com>, "Pierre Ossman" <drzeus-list@drzeus.cx> Subject: Re: [RFC v3 5/7] dmaengine: Make DMA Engine menu visible for AVR32 users Date: Tue, 12 Feb 2008 15:27:29 -0700 [thread overview] Message-ID: <e9c3a7c20802121427v2f3aed68h68bfc12bbce19d19@mail.gmail.com> (raw) In-Reply-To: <20080212231330.79738c3a@siona> On Feb 12, 2008 3:13 PM, Haavard Skinnemoen <hskinnemoen@atmel.com> wrote: > On Tue, 12 Feb 2008 14:43:30 -0600 > Olof Johansson <olof@lixom.net> wrote: > > > > - depends on (PCI && X86) || ARCH_IOP32X || ARCH_IOP33X || ARCH_IOP13XX > > > + depends on (PCI && X86) || ARCH_IOP32X || ARCH_IOP33X || ARCH_IOP13XX || AVR32 > > > > This is a slippery slope. Things should be the other way around instead, > > create a HAVE_DMA_DEVICE, select it in the relevant platform code and > > make DMADEVICES depend on that. > > Agree. I'll cook up a patch tomorrow to make it use the new HAVE_* > scheme. > I suggested something similar here: http://marc.info/?l=linux-kernel&m=118670671806100&w=2 > > Or just let the subsystem always be available. > > It used to be always available, but then it was changed. Assuming there > was a reason for this change, I guess we don't want to change it back. > Adrian had concerns about users enabling NET_DMA when the hardware capability is relatively rare. So, +1 for HAVE_DMA_DEVICE > Haavard -- Dan
next prev parent reply other threads:[~2008-02-12 22:27 UTC|newest] Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top 2008-02-12 16:43 [RFC v3 1/7] dmaengine: Couple DMA channels to their physical DMA device Haavard Skinnemoen 2008-02-12 16:43 ` [RFC v3 2/7] dmaengine: Add dma_client parameter to device_alloc_chan_resources Haavard Skinnemoen 2008-02-12 16:43 ` [RFC v3 3/7] dmaengine: Add dma_chan_is_in_use() function Haavard Skinnemoen 2008-02-12 16:43 ` [RFC v3 4/7] dmaengine: Add slave DMA interface Haavard Skinnemoen 2008-02-12 16:43 ` [RFC v3 5/7] dmaengine: Make DMA Engine menu visible for AVR32 users Haavard Skinnemoen 2008-02-12 16:43 ` [RFC v3 6/7] dmaengine: Driver for the Synopsys DesignWare DMA controller Haavard Skinnemoen 2008-02-12 16:43 ` [RFC v3 7/7] Atmel MCI: Driver for Atmel on-chip MMC controllers Haavard Skinnemoen 2008-02-12 20:43 ` [RFC v3 5/7] dmaengine: Make DMA Engine menu visible for AVR32 users Olof Johansson 2008-02-12 22:13 ` Haavard Skinnemoen 2008-02-12 22:27 ` Dan Williams [this message] 2008-02-13 8:44 ` Haavard Skinnemoen 2008-02-13 7:21 ` [RFC v3 4/7] dmaengine: Add slave DMA interface Dan Williams 2008-02-13 8:03 ` Haavard Skinnemoen 2008-02-13 19:07 ` Dan Williams 2008-02-13 19:24 ` Haavard Skinnemoen 2008-02-15 9:53 ` Haavard Skinnemoen 2008-02-15 17:12 ` Nelson, Shannon 2008-02-18 13:29 ` Haavard Skinnemoen 2008-02-19 18:46 ` Nelson, Shannon 2008-02-16 20:06 ` Dan Williams 2008-02-18 13:22 ` Haavard Skinnemoen 2008-02-18 22:42 ` Dan Williams
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=e9c3a7c20802121427v2f3aed68h68bfc12bbce19d19@mail.gmail.com \ --to=dan.j.williams@intel.com \ --cc=david-b@pacbell.net \ --cc=drzeus-list@drzeus.cx \ --cc=francis.moro@gmail.com \ --cc=hskinnemoen@atmel.com \ --cc=kernel@avr32linux.org \ --cc=lethal@linux-sh.org \ --cc=linux-kernel@vger.kernel.org \ --cc=olof@lixom.net \ --cc=shannon.nelson@intel.com \ --cc=vbarinov@ru.mvista.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).