LKML Archive on
help / color / mirror / Atom feed
From: "Duane Griffin" <>
To: "Christoph Hellwig" <>
Cc: "Andreas Dilger" <>,,,
	"Theodore Tso" <>,,
Subject: Re: [PATCH 2/3] jbd2: replace potentially false assertion with if block
Date: Sat, 8 Mar 2008 18:37:08 +0000	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On 08/03/2008, Christoph Hellwig <> wrote:
> That text above was in reply to Andreas comment about checking it in
>  journal_load.  Your fix obviously does make sense althrough doing it
>  differently as in my reply to your first series would be even better.

Sorry if I'm missing something here, but I think the caches do need to
be checked. If jbd/ext3 are not modular then even if initialisation
fails the journal code may still be called later. I noticed this when
testing the failure modes after making my original fix.

I have some patches ready to go to address this, which I'll send after
this. It turns out journal_load is actually too late to check, though:
journal_init_common is called prior to that and will also blow up if
the caches are uninitialised. I've taken Andreas' suggestion and
attempted to initialise the caches again at that point before failing.

I've modified my changes to match the way you suggested doing things
in your earlier reply (and thanks for the review, BTW). If you would
prefer I'll rework my changes as a separate patch on top. Just let me


"I never could learn to drink that blood and call it wine" - Bob Dylan

  reply	other threads:[~2008-03-08 18:37 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <>
2008-03-07  1:31 ` [PATCH 1/3] jbd2: eliminate duplicated code in revocation table init/destroy functions Duane Griffin
     [not found]   ` <>
2008-03-07  1:31     ` [PATCH 2/3] jbd2: replace potentially false assertion with if block Duane Griffin
2008-03-07 21:23       ` Andreas Dilger
2008-03-08 13:33         ` Duane Griffin
2008-03-08 15:02         ` Christoph Hellwig
2008-03-08 16:40           ` Duane Griffin
2008-03-08 16:42             ` Christoph Hellwig
2008-03-08 18:37               ` Duane Griffin [this message]
2008-03-08 18:45                 ` Christoph Hellwig
     [not found]   ` <>
2008-03-07  1:31     ` [PATCH 3/3] jbd2: only create debugfs and stats entries if cache initialisation is successful Duane Griffin
2008-03-07 21:24       ` Andreas Dilger
2008-03-07 21:52   ` [PATCH 1/3] jbd2: eliminate duplicated code in revocation table init/destroy functions Andreas Dilger
2008-03-08  0:05     ` Mingming Cao
2008-03-08 13:26       ` Duane Griffin
2008-03-08 13:20     ` Duane Griffin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH 2/3] jbd2: replace potentially false assertion with if block' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).