LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] soc: ti: QMSS: Fix usage of irq_set_affinity_hint
@ 2018-10-30 11:11 Marc Zyngier
  2018-10-30 17:02 ` Florian Fainelli
                   ` (3 more replies)
  0 siblings, 4 replies; 8+ messages in thread
From: Marc Zyngier @ 2018-10-30 11:11 UTC (permalink / raw)
  To: Santosh Shilimkar; +Cc: linux-kernel, linux-arm-kernel

The Keystone QMSS driver is pretty damaged, in the sense that it
does things like this:

	irq_set_affinity_hint(irq, to_cpumask(&cpu_map));

where cpu_map is a local variable. As we leave the function, this
will point to nowhere-land, and things will end-up badly.

Instead, let's use a proper cpumask that gets allocated, giving
the driver a chance to actually work with things like irqbalance
as well as have a hypothetical 64bit future.

Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
---
I found this one by inspection after finding a similar bug in an
unrelated driver. It is only compile-tested. It would probably
a Cc stable, but that's Santosh's decision.

 drivers/soc/ti/knav_qmss.h       |  4 ++--
 drivers/soc/ti/knav_qmss_acc.c   | 10 +++++-----
 drivers/soc/ti/knav_qmss_queue.c | 22 +++++++++++++++-------
 3 files changed, 22 insertions(+), 14 deletions(-)

diff --git a/drivers/soc/ti/knav_qmss.h b/drivers/soc/ti/knav_qmss.h
index 3efc47e82973..bd040c29c4bf 100644
--- a/drivers/soc/ti/knav_qmss.h
+++ b/drivers/soc/ti/knav_qmss.h
@@ -329,8 +329,8 @@ struct knav_range_ops {
 };
 
 struct knav_irq_info {
-	int	irq;
-	u32	cpu_map;
+	int		irq;
+	struct cpumask	*cpu_mask;
 };
 
 struct knav_range_info {
diff --git a/drivers/soc/ti/knav_qmss_acc.c b/drivers/soc/ti/knav_qmss_acc.c
index 316e82e46f6c..2f7fb2dcc1d6 100644
--- a/drivers/soc/ti/knav_qmss_acc.c
+++ b/drivers/soc/ti/knav_qmss_acc.c
@@ -205,18 +205,18 @@ static int knav_range_setup_acc_irq(struct knav_range_info *range,
 {
 	struct knav_device *kdev = range->kdev;
 	struct knav_acc_channel *acc;
-	unsigned long cpu_map;
+	struct cpumask *cpu_mask;
 	int ret = 0, irq;
 	u32 old, new;
 
 	if (range->flags & RANGE_MULTI_QUEUE) {
 		acc = range->acc;
 		irq = range->irqs[0].irq;
-		cpu_map = range->irqs[0].cpu_map;
+		cpu_mask = range->irqs[0].cpu_mask;
 	} else {
 		acc = range->acc + queue;
 		irq = range->irqs[queue].irq;
-		cpu_map = range->irqs[queue].cpu_map;
+		cpu_mask = range->irqs[queue].cpu_mask;
 	}
 
 	old = acc->open_mask;
@@ -239,8 +239,8 @@ static int knav_range_setup_acc_irq(struct knav_range_info *range,
 			acc->name, acc->name);
 		ret = request_irq(irq, knav_acc_int_handler, 0, acc->name,
 				  range);
-		if (!ret && cpu_map) {
-			ret = irq_set_affinity_hint(irq, to_cpumask(&cpu_map));
+		if (!ret && cpu_mask) {
+			ret = irq_set_affinity_hint(irq, cpu_mask);
 			if (ret) {
 				dev_warn(range->kdev->dev,
 					 "Failed to set IRQ affinity\n");
diff --git a/drivers/soc/ti/knav_qmss_queue.c b/drivers/soc/ti/knav_qmss_queue.c
index b5d5673c255c..8b418379272d 100644
--- a/drivers/soc/ti/knav_qmss_queue.c
+++ b/drivers/soc/ti/knav_qmss_queue.c
@@ -118,19 +118,17 @@ static int knav_queue_setup_irq(struct knav_range_info *range,
 			  struct knav_queue_inst *inst)
 {
 	unsigned queue = inst->id - range->queue_base;
-	unsigned long cpu_map;
 	int ret = 0, irq;
 
 	if (range->flags & RANGE_HAS_IRQ) {
 		irq = range->irqs[queue].irq;
-		cpu_map = range->irqs[queue].cpu_map;
 		ret = request_irq(irq, knav_queue_int_handler, 0,
 					inst->irq_name, inst);
 		if (ret)
 			return ret;
 		disable_irq(irq);
-		if (cpu_map) {
-			ret = irq_set_affinity_hint(irq, to_cpumask(&cpu_map));
+		if (range->irqs[queue].cpu_mask) {
+			ret = irq_set_affinity_hint(irq, range->irqs[queue].cpu_mask);
 			if (ret) {
 				dev_warn(range->kdev->dev,
 					 "Failed to set IRQ affinity\n");
@@ -1262,9 +1260,19 @@ static int knav_setup_queue_range(struct knav_device *kdev,
 
 		range->num_irqs++;
 
-		if (IS_ENABLED(CONFIG_SMP) && oirq.args_count == 3)
-			range->irqs[i].cpu_map =
-				(oirq.args[2] & 0x0000ff00) >> 8;
+		if (IS_ENABLED(CONFIG_SMP) && oirq.args_count == 3) {
+			unsigned long mask;
+			int bit;
+
+			range->irqs[i].cpu_mask = devm_kzalloc(dev,
+							       cpumask_size(), GFP_KERNEL);
+			if (!range->irqs[i].cpu_mask)
+				return -ENOMEM;
+
+			mask = (oirq.args[2] & 0x0000ff00) >> 8;
+			for_each_set_bit(bit, &mask, BITS_PER_LONG)
+				cpumask_set_cpu(bit, range->irqs[i].cpu_mask);
+		}
 	}
 
 	range->num_irqs = min(range->num_irqs, range->num_queues);
-- 
2.19.1


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] soc: ti: QMSS: Fix usage of irq_set_affinity_hint
  2018-10-30 11:11 [PATCH] soc: ti: QMSS: Fix usage of irq_set_affinity_hint Marc Zyngier
@ 2018-10-30 17:02 ` Florian Fainelli
  2018-10-30 18:29   ` Marc Zyngier
  2018-10-30 17:09 ` Santosh Shilimkar
                   ` (2 subsequent siblings)
  3 siblings, 1 reply; 8+ messages in thread
From: Florian Fainelli @ 2018-10-30 17:02 UTC (permalink / raw)
  To: Marc Zyngier, Santosh Shilimkar; +Cc: linux-kernel, linux-arm-kernel

On 10/30/18 4:11 AM, Marc Zyngier wrote:
> The Keystone QMSS driver is pretty damaged, in the sense that it
> does things like this:
> 
> 	irq_set_affinity_hint(irq, to_cpumask(&cpu_map));
> 
> where cpu_map is a local variable. As we leave the function, this
> will point to nowhere-land, and things will end-up badly.
> 
> Instead, let's use a proper cpumask that gets allocated, giving
> the driver a chance to actually work with things like irqbalance
> as well as have a hypothetical 64bit future.

Since this is at least the second patch from you that I can see in this
area, would it make sense to sprinkle object_is_on_stack() checks
throughout irq_set_affinity_hint() to help catch offenders?

> 
> Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
> ---
> I found this one by inspection after finding a similar bug in an
> unrelated driver. It is only compile-tested. It would probably
> a Cc stable, but that's Santosh's decision.
> 
>  drivers/soc/ti/knav_qmss.h       |  4 ++--
>  drivers/soc/ti/knav_qmss_acc.c   | 10 +++++-----
>  drivers/soc/ti/knav_qmss_queue.c | 22 +++++++++++++++-------
>  3 files changed, 22 insertions(+), 14 deletions(-)
> 
> diff --git a/drivers/soc/ti/knav_qmss.h b/drivers/soc/ti/knav_qmss.h
> index 3efc47e82973..bd040c29c4bf 100644
> --- a/drivers/soc/ti/knav_qmss.h
> +++ b/drivers/soc/ti/knav_qmss.h
> @@ -329,8 +329,8 @@ struct knav_range_ops {
>  };
>  
>  struct knav_irq_info {
> -	int	irq;
> -	u32	cpu_map;
> +	int		irq;
> +	struct cpumask	*cpu_mask;
>  };
>  
>  struct knav_range_info {
> diff --git a/drivers/soc/ti/knav_qmss_acc.c b/drivers/soc/ti/knav_qmss_acc.c
> index 316e82e46f6c..2f7fb2dcc1d6 100644
> --- a/drivers/soc/ti/knav_qmss_acc.c
> +++ b/drivers/soc/ti/knav_qmss_acc.c
> @@ -205,18 +205,18 @@ static int knav_range_setup_acc_irq(struct knav_range_info *range,
>  {
>  	struct knav_device *kdev = range->kdev;
>  	struct knav_acc_channel *acc;
> -	unsigned long cpu_map;
> +	struct cpumask *cpu_mask;
>  	int ret = 0, irq;
>  	u32 old, new;
>  
>  	if (range->flags & RANGE_MULTI_QUEUE) {
>  		acc = range->acc;
>  		irq = range->irqs[0].irq;
> -		cpu_map = range->irqs[0].cpu_map;
> +		cpu_mask = range->irqs[0].cpu_mask;
>  	} else {
>  		acc = range->acc + queue;
>  		irq = range->irqs[queue].irq;
> -		cpu_map = range->irqs[queue].cpu_map;
> +		cpu_mask = range->irqs[queue].cpu_mask;
>  	}
>  
>  	old = acc->open_mask;
> @@ -239,8 +239,8 @@ static int knav_range_setup_acc_irq(struct knav_range_info *range,
>  			acc->name, acc->name);
>  		ret = request_irq(irq, knav_acc_int_handler, 0, acc->name,
>  				  range);
> -		if (!ret && cpu_map) {
> -			ret = irq_set_affinity_hint(irq, to_cpumask(&cpu_map));
> +		if (!ret && cpu_mask) {
> +			ret = irq_set_affinity_hint(irq, cpu_mask);
>  			if (ret) {
>  				dev_warn(range->kdev->dev,
>  					 "Failed to set IRQ affinity\n");
> diff --git a/drivers/soc/ti/knav_qmss_queue.c b/drivers/soc/ti/knav_qmss_queue.c
> index b5d5673c255c..8b418379272d 100644
> --- a/drivers/soc/ti/knav_qmss_queue.c
> +++ b/drivers/soc/ti/knav_qmss_queue.c
> @@ -118,19 +118,17 @@ static int knav_queue_setup_irq(struct knav_range_info *range,
>  			  struct knav_queue_inst *inst)
>  {
>  	unsigned queue = inst->id - range->queue_base;
> -	unsigned long cpu_map;
>  	int ret = 0, irq;
>  
>  	if (range->flags & RANGE_HAS_IRQ) {
>  		irq = range->irqs[queue].irq;
> -		cpu_map = range->irqs[queue].cpu_map;
>  		ret = request_irq(irq, knav_queue_int_handler, 0,
>  					inst->irq_name, inst);
>  		if (ret)
>  			return ret;
>  		disable_irq(irq);
> -		if (cpu_map) {
> -			ret = irq_set_affinity_hint(irq, to_cpumask(&cpu_map));
> +		if (range->irqs[queue].cpu_mask) {
> +			ret = irq_set_affinity_hint(irq, range->irqs[queue].cpu_mask);
>  			if (ret) {
>  				dev_warn(range->kdev->dev,
>  					 "Failed to set IRQ affinity\n");
> @@ -1262,9 +1260,19 @@ static int knav_setup_queue_range(struct knav_device *kdev,
>  
>  		range->num_irqs++;
>  
> -		if (IS_ENABLED(CONFIG_SMP) && oirq.args_count == 3)
> -			range->irqs[i].cpu_map =
> -				(oirq.args[2] & 0x0000ff00) >> 8;
> +		if (IS_ENABLED(CONFIG_SMP) && oirq.args_count == 3) {
> +			unsigned long mask;
> +			int bit;
> +
> +			range->irqs[i].cpu_mask = devm_kzalloc(dev,
> +							       cpumask_size(), GFP_KERNEL);
> +			if (!range->irqs[i].cpu_mask)
> +				return -ENOMEM;
> +
> +			mask = (oirq.args[2] & 0x0000ff00) >> 8;
> +			for_each_set_bit(bit, &mask, BITS_PER_LONG)
> +				cpumask_set_cpu(bit, range->irqs[i].cpu_mask);
> +		}
>  	}
>  
>  	range->num_irqs = min(range->num_irqs, range->num_queues);
> 


-- 
Florian

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] soc: ti: QMSS: Fix usage of irq_set_affinity_hint
  2018-10-30 11:11 [PATCH] soc: ti: QMSS: Fix usage of irq_set_affinity_hint Marc Zyngier
  2018-10-30 17:02 ` Florian Fainelli
@ 2018-10-30 17:09 ` Santosh Shilimkar
  2018-10-30 17:15 ` Santosh Shilimkar
  2018-10-30 17:18 ` Santosh Shilimkar
  3 siblings, 0 replies; 8+ messages in thread
From: Santosh Shilimkar @ 2018-10-30 17:09 UTC (permalink / raw)
  To: Marc Zyngier, Santosh Shilimkar; +Cc: linux-kernel, linux-arm-kernel

10/30/2018 4:11 AM, Marc Zyngier wrote:
> The Keystone QMSS driver is pretty damaged, in the sense that it
> does things like this:
> 
> 	irq_set_affinity_hint(irq, to_cpumask(&cpu_map));
> 
> where cpu_map is a local variable. As we leave the function, this
> will point to nowhere-land, and things will end-up badly.
> 
> Instead, let's use a proper cpumask that gets allocated, giving
> the driver a chance to actually work with things like irqbalance
> as well as have a hypothetical 64bit future.
> 
> Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
> ---
Thanks Marc for the fix. Will send note to arm-soc folks
to pick this up for fixes and also stable.

Regards,
Santosh

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] soc: ti: QMSS: Fix usage of irq_set_affinity_hint
  2018-10-30 11:11 [PATCH] soc: ti: QMSS: Fix usage of irq_set_affinity_hint Marc Zyngier
  2018-10-30 17:02 ` Florian Fainelli
  2018-10-30 17:09 ` Santosh Shilimkar
@ 2018-10-30 17:15 ` Santosh Shilimkar
  2018-10-30 17:18 ` Santosh Shilimkar
  3 siblings, 0 replies; 8+ messages in thread
From: Santosh Shilimkar @ 2018-10-30 17:15 UTC (permalink / raw)
  Cc: Marc Zyngier, Santosh Shilimkar, linux-kernel, linux-arm-kernel,
	arm, Arnd Bergmann, Olof Johansson, stable

Hi Arnd, Olof,

On 10/30/2018 4:11 AM, Marc Zyngier wrote:
> The Keystone QMSS driver is pretty damaged, in the sense that it
> does things like this:
> 
> 	irq_set_affinity_hint(irq, to_cpumask(&cpu_map));
> 
> where cpu_map is a local variable. As we leave the function, this
> will point to nowhere-land, and things will end-up badly.
> 
> Instead, let's use a proper cpumask that gets allocated, giving
> the driver a chance to actually work with things like irqbalance
> as well as have a hypothetical 64bit future.
> 
> Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
> ---
Could you please add this patch to your fixes branch ?

FWIW,
Acked-by: Santosh Shilimkar <ssantosh@kernel.org>


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] soc: ti: QMSS: Fix usage of irq_set_affinity_hint
  2018-10-30 11:11 [PATCH] soc: ti: QMSS: Fix usage of irq_set_affinity_hint Marc Zyngier
                   ` (2 preceding siblings ...)
  2018-10-30 17:15 ` Santosh Shilimkar
@ 2018-10-30 17:18 ` Santosh Shilimkar
  2018-10-30 19:00   ` Greg Kroah-Hartman
  3 siblings, 1 reply; 8+ messages in thread
From: Santosh Shilimkar @ 2018-10-30 17:18 UTC (permalink / raw)
  To: Greg Kroah-Hartman
  Cc: Marc Zyngier, Santosh Shilimkar, linux-kernel, linux-arm-kernel, stable

Hi Greg,

On 10/30/2018 4:11 AM, Marc Zyngier wrote:
> The Keystone QMSS driver is pretty damaged, in the sense that it
> does things like this:
> 
> 	irq_set_affinity_hint(irq, to_cpumask(&cpu_map));
> 
> where cpu_map is a local variable. As we leave the function, this
> will point to nowhere-land, and things will end-up badly.
> 
> Instead, let's use a proper cpumask that gets allocated, giving
> the driver a chance to actually work with things like irqbalance
> as well as have a hypothetical 64bit future.
> 
> Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
> ---
> I found this one by inspection after finding a similar bug in an
> unrelated driver. It is only compile-tested. It would probably
> a Cc stable, but that's Santosh's decision.

Would be able to apply this fix from Marc for stable or it needs
to be re-posted with CC to stable ?

> 
>   drivers/soc/ti/knav_qmss.h       |  4 ++--
>   drivers/soc/ti/knav_qmss_acc.c   | 10 +++++-----
>   drivers/soc/ti/knav_qmss_queue.c | 22 +++++++++++++++-------
>   3 files changed, 22 insertions(+), 14 deletions(-)
> 
> diff --git a/drivers/soc/ti/knav_qmss.h b/drivers/soc/ti/knav_qmss.h
> index 3efc47e82973..bd040c29c4bf 100644
> --- a/drivers/soc/ti/knav_qmss.h
> +++ b/drivers/soc/ti/knav_qmss.h
> @@ -329,8 +329,8 @@ struct knav_range_ops {
>   };
>   
>   struct knav_irq_info {
> -	int	irq;
> -	u32	cpu_map;
> +	int		irq;
> +	struct cpumask	*cpu_mask;
>   };
>   
>   struct knav_range_info {
> diff --git a/drivers/soc/ti/knav_qmss_acc.c b/drivers/soc/ti/knav_qmss_acc.c
> index 316e82e46f6c..2f7fb2dcc1d6 100644
> --- a/drivers/soc/ti/knav_qmss_acc.c
> +++ b/drivers/soc/ti/knav_qmss_acc.c
> @@ -205,18 +205,18 @@ static int knav_range_setup_acc_irq(struct knav_range_info *range,
>   {
>   	struct knav_device *kdev = range->kdev;
>   	struct knav_acc_channel *acc;
> -	unsigned long cpu_map;
> +	struct cpumask *cpu_mask;
>   	int ret = 0, irq;
>   	u32 old, new;
>   
>   	if (range->flags & RANGE_MULTI_QUEUE) {
>   		acc = range->acc;
>   		irq = range->irqs[0].irq;
> -		cpu_map = range->irqs[0].cpu_map;
> +		cpu_mask = range->irqs[0].cpu_mask;
>   	} else {
>   		acc = range->acc + queue;
>   		irq = range->irqs[queue].irq;
> -		cpu_map = range->irqs[queue].cpu_map;
> +		cpu_mask = range->irqs[queue].cpu_mask;
>   	}
>   
>   	old = acc->open_mask;
> @@ -239,8 +239,8 @@ static int knav_range_setup_acc_irq(struct knav_range_info *range,
>   			acc->name, acc->name);
>   		ret = request_irq(irq, knav_acc_int_handler, 0, acc->name,
>   				  range);
> -		if (!ret && cpu_map) {
> -			ret = irq_set_affinity_hint(irq, to_cpumask(&cpu_map));
> +		if (!ret && cpu_mask) {
> +			ret = irq_set_affinity_hint(irq, cpu_mask);
>   			if (ret) {
>   				dev_warn(range->kdev->dev,
>   					 "Failed to set IRQ affinity\n");
> diff --git a/drivers/soc/ti/knav_qmss_queue.c b/drivers/soc/ti/knav_qmss_queue.c
> index b5d5673c255c..8b418379272d 100644
> --- a/drivers/soc/ti/knav_qmss_queue.c
> +++ b/drivers/soc/ti/knav_qmss_queue.c
> @@ -118,19 +118,17 @@ static int knav_queue_setup_irq(struct knav_range_info *range,
>   			  struct knav_queue_inst *inst)
>   {
>   	unsigned queue = inst->id - range->queue_base;
> -	unsigned long cpu_map;
>   	int ret = 0, irq;
>   
>   	if (range->flags & RANGE_HAS_IRQ) {
>   		irq = range->irqs[queue].irq;
> -		cpu_map = range->irqs[queue].cpu_map;
>   		ret = request_irq(irq, knav_queue_int_handler, 0,
>   					inst->irq_name, inst);
>   		if (ret)
>   			return ret;
>   		disable_irq(irq);
> -		if (cpu_map) {
> -			ret = irq_set_affinity_hint(irq, to_cpumask(&cpu_map));
> +		if (range->irqs[queue].cpu_mask) {
> +			ret = irq_set_affinity_hint(irq, range->irqs[queue].cpu_mask);
>   			if (ret) {
>   				dev_warn(range->kdev->dev,
>   					 "Failed to set IRQ affinity\n");
> @@ -1262,9 +1260,19 @@ static int knav_setup_queue_range(struct knav_device *kdev,
>   
>   		range->num_irqs++;
>   
> -		if (IS_ENABLED(CONFIG_SMP) && oirq.args_count == 3)
> -			range->irqs[i].cpu_map =
> -				(oirq.args[2] & 0x0000ff00) >> 8;
> +		if (IS_ENABLED(CONFIG_SMP) && oirq.args_count == 3) {
> +			unsigned long mask;
> +			int bit;
> +
> +			range->irqs[i].cpu_mask = devm_kzalloc(dev,
> +							       cpumask_size(), GFP_KERNEL);
> +			if (!range->irqs[i].cpu_mask)
> +				return -ENOMEM;
> +
> +			mask = (oirq.args[2] & 0x0000ff00) >> 8;
> +			for_each_set_bit(bit, &mask, BITS_PER_LONG)
> +				cpumask_set_cpu(bit, range->irqs[i].cpu_mask);
> +		}
>   	}
>   
>   	range->num_irqs = min(range->num_irqs, range->num_queues);
> 

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] soc: ti: QMSS: Fix usage of irq_set_affinity_hint
  2018-10-30 17:02 ` Florian Fainelli
@ 2018-10-30 18:29   ` Marc Zyngier
  0 siblings, 0 replies; 8+ messages in thread
From: Marc Zyngier @ 2018-10-30 18:29 UTC (permalink / raw)
  To: Florian Fainelli, Santosh Shilimkar; +Cc: linux-kernel, linux-arm-kernel

On 30/10/18 17:02, Florian Fainelli wrote:
> On 10/30/18 4:11 AM, Marc Zyngier wrote:
>> The Keystone QMSS driver is pretty damaged, in the sense that it
>> does things like this:
>>
>> 	irq_set_affinity_hint(irq, to_cpumask(&cpu_map));
>>
>> where cpu_map is a local variable. As we leave the function, this
>> will point to nowhere-land, and things will end-up badly.
>>
>> Instead, let's use a proper cpumask that gets allocated, giving
>> the driver a chance to actually work with things like irqbalance
>> as well as have a hypothetical 64bit future.
> 
> Since this is at least the second patch from you that I can see in this
> area, would it make sense to sprinkle object_is_on_stack() checks
> throughout irq_set_affinity_hint() to help catch offenders?

I think I nuked the only two offenders in the tree. And to be honest,
I'm far more worried about the use of to_cpumask() itself, because this
can be wrong in quite a number of ways.

As much as I dislike checkpatch, I wonder if having a rule checking for
the usage of to_cpumask() would be a good idea...

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny...

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] soc: ti: QMSS: Fix usage of irq_set_affinity_hint
  2018-10-30 17:18 ` Santosh Shilimkar
@ 2018-10-30 19:00   ` Greg Kroah-Hartman
  2018-10-30 19:05     ` santosh.shilimkar
  0 siblings, 1 reply; 8+ messages in thread
From: Greg Kroah-Hartman @ 2018-10-30 19:00 UTC (permalink / raw)
  To: Santosh Shilimkar
  Cc: Marc Zyngier, Santosh Shilimkar, linux-kernel, linux-arm-kernel, stable

On Tue, Oct 30, 2018 at 10:18:08AM -0700, Santosh Shilimkar wrote:
> Hi Greg,
> 
> On 10/30/2018 4:11 AM, Marc Zyngier wrote:
> > The Keystone QMSS driver is pretty damaged, in the sense that it
> > does things like this:
> > 
> > 	irq_set_affinity_hint(irq, to_cpumask(&cpu_map));
> > 
> > where cpu_map is a local variable. As we leave the function, this
> > will point to nowhere-land, and things will end-up badly.
> > 
> > Instead, let's use a proper cpumask that gets allocated, giving
> > the driver a chance to actually work with things like irqbalance
> > as well as have a hypothetical 64bit future.
> > 
> > Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
> > ---
> > I found this one by inspection after finding a similar bug in an
> > unrelated driver. It is only compile-tested. It would probably
> > a Cc stable, but that's Santosh's decision.
> 
> Would be able to apply this fix from Marc for stable or it needs
> to be re-posted with CC to stable ?

<formletter>

This is not the correct way to submit patches for inclusion in the
stable kernel tree.  Please read:
    https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.

</formletter>

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] soc: ti: QMSS: Fix usage of irq_set_affinity_hint
  2018-10-30 19:00   ` Greg Kroah-Hartman
@ 2018-10-30 19:05     ` santosh.shilimkar
  0 siblings, 0 replies; 8+ messages in thread
From: santosh.shilimkar @ 2018-10-30 19:05 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Marc Zyngier
  Cc: Santosh Shilimkar, linux-kernel, linux-arm-kernel, stable

On 10/30/18 12:00 PM, Greg Kroah-Hartman wrote:
> On Tue, Oct 30, 2018 at 10:18:08AM -0700, Santosh Shilimkar wrote:
>> Hi Greg,

[...]

>> Would be able to apply this fix from Marc for stable or it needs
>> to be re-posted with CC to stable ?
> 
> <formletter>
> 
> This is not the correct way to submit patches for inclusion in the
> stable kernel tree.  Please read:
>      https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
> for how to do this properly.
> 
Thanks Greg !!

Hi Marc,
Could you please resend the patch to the stable ?

Regards,
Santosh



^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2018-10-30 19:05 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-30 11:11 [PATCH] soc: ti: QMSS: Fix usage of irq_set_affinity_hint Marc Zyngier
2018-10-30 17:02 ` Florian Fainelli
2018-10-30 18:29   ` Marc Zyngier
2018-10-30 17:09 ` Santosh Shilimkar
2018-10-30 17:15 ` Santosh Shilimkar
2018-10-30 17:18 ` Santosh Shilimkar
2018-10-30 19:00   ` Greg Kroah-Hartman
2018-10-30 19:05     ` santosh.shilimkar

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).