LKML Archive on lore.kernel.org help / color / mirror / Atom feed
From: email@example.com To: Keith Busch <firstname.lastname@example.org> Cc: Sinan Kaya <email@example.com>, Bjorn Helgaas <firstname.lastname@example.org>, Bjorn Helgaas <email@example.com>, Philippe Ombredanne <firstname.lastname@example.org>, Thomas Gleixner <email@example.com>, Greg Kroah-Hartman <firstname.lastname@example.org>, Kate Stewart <email@example.com>, firstname.lastname@example.org, email@example.com, Dongdong Liu <firstname.lastname@example.org>, Wei Zhang <email@example.com>, Timur Tabi <firstname.lastname@example.org>, email@example.com Subject: Re: [PATCH v12 0/6] Address error and recovery for AER and DPC Date: Mon, 12 Mar 2018 21:04:47 +0530 [thread overview] Message-ID: <firstname.lastname@example.org> (raw) In-Reply-To: <20180312145823.GC18494@localhost.localdomain> On 2018-03-12 20:28, Keith Busch wrote: > On Mon, Mar 12, 2018 at 08:16:38PM +0530, email@example.com wrote: >> On 2018-03-12 19:55, Keith Busch wrote: >> > On Sun, Mar 11, 2018 at 11:03:58PM -0400, Sinan Kaya wrote: >> > > On 3/11/2018 6:03 PM, Bjorn Helgaas wrote: >> > > > On Wed, Feb 28, 2018 at 10:34:11PM +0530, Oza Pawandeep wrote: >> > > >> > > > That difference has been there since the beginning of DPC, so it has >> > > > nothing to do with *this* series EXCEPT for the fact that it really >> > > > complicates the logic you're adding to reset_link() and >> > > > broadcast_error_message(). >> > > > >> > > > We ought to be able to simplify that somehow because the only real >> > > > difference between AER and DPC should be that DPC automatically >> > > > disables the link and AER does it in software. >> > > >> > > I agree this should be possible. Code execution path should be almost >> > > identical to fatal error case. >> > > >> > > Is there any reason why you went to stop driver path, Keith? >> > >> > The fact is the link is truly down during a DPC event. When the link >> > is enabled again, you don't know at that point if the device(s) on the >> > other side have changed. Calling a driver's error handler for the wrong >> > device in an unknown state may have undefined results. Enumerating the >> > slot from scratch should be safe, and will assign resources, tune bus >> > settings, and bind to the matching driver. >> > >> > Per spec, DPC is the recommended way for handling surprise removal >> > events and even recommends DPC capable slots *not* set 'Surprise' >> > in Slot Capabilities so that removals are always handled by DPC. This >> > service driver was developed with that use in mind. >> >> Now it begs the question, that >> >> after DPC trigger >> >> should we enumerate the devices, ? >> or >> error handling callbacks, followed by stop devices followed by >> enumeration ? >> or >> error handling callbacks, followed by enumeration ? (no stop devices) > > I'm not sure I understand. The link is disabled while DPC is triggered, > so if anything, you'd want to un-enumerate everything below the > contained > port (that's what it does today). > > After releasing a slot from DPC, the link is allowed to retrain. If > there > is a working device on the other side, a link up event occurs. That > event is handled by the pciehp driver, and that schedules enumeration > no matter what you do to the DPC driver. yes, that is what i current, but this patch-set makes DPC aware of error handling driver callbacks. besides, in absence of pciehp there is nobody to do enumeration. And, I was talking about pci_stop_and_remove_bus_device() in dpc. if DPC calls driver's error callbacks, is it required to stop the devices ?
next prev parent reply other threads:[~2018-03-12 15:34 UTC|newest] Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-02-28 17:04 [PATCH v12 0/6] Address error and recovery for AER and DPC Oza Pawandeep 2018-02-28 17:04 ` [PATCH v12 1/6] PCI/AER: Rename error recovery to generic PCI naming Oza Pawandeep 2018-02-28 17:04 ` [PATCH v12 2/6] PCI/AER: Factor out error reporting from AER Oza Pawandeep 2018-02-28 17:04 ` [PATCH v12 3/6] PCI/PORTDRV: Implement generic find service Oza Pawandeep 2018-03-06 14:02 ` Sinan Kaya 2018-03-08 7:56 ` poza 2018-02-28 17:04 ` [PATCH v12 4/6] PCI/DPC: Unify and plumb error handling into DPC Oza Pawandeep 2018-02-28 17:04 ` [PATCH v12 5/6] PCI: Unify wait for link active into generic PCI Oza Pawandeep 2018-02-28 17:04 ` [PATCH v12 6/6] PCI/DPC: Enumerate the devices after DPC trigger event Oza Pawandeep 2018-03-11 22:03 ` [PATCH v12 0/6] Address error and recovery for AER and DPC Bjorn Helgaas 2018-03-12 3:03 ` Sinan Kaya 2018-03-12 14:25 ` Keith Busch 2018-03-12 14:46 ` poza 2018-03-12 14:58 ` Keith Busch 2018-03-12 15:34 ` poza [this message] 2018-03-12 17:33 ` Keith Busch 2018-03-12 17:41 ` Sinan Kaya 2018-03-12 17:56 ` Keith Busch 2018-03-12 19:47 ` Bjorn Helgaas 2018-03-12 23:26 ` Keith Busch 2018-03-13 3:47 ` Sinan Kaya 2018-03-14 20:50 ` Keith Busch 2018-03-14 21:00 ` Sinan Kaya 2018-05-08 19:25 ` Bjorn Helgaas 2018-03-12 14:01 ` poza
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).