LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] [IPV6] Minor clenup: remove two unused definitions in net/ip6_route.h
@ 2008-02-07 15:58 Rami Rosen
  2008-02-08  2:11 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Rami Rosen @ 2008-02-07 15:58 UTC (permalink / raw)
  To: David Miller, netdev; +Cc: linux-kernel

[-- Attachment #1: Type: text/plain, Size: 193 bytes --]

Hi,
Remove IP6_RT_PRIO_FW and IP6_RT_FLOW_MASK definitions in
include/net/ip6_route.h, as they are not used in the kernel.

Regards,
Rami Rosen


Signed-off-by: Rami Rosen <ramirose@gmail.com>

[-- Attachment #2: patch.txt --]
[-- Type: text/plain, Size: 418 bytes --]

diff --git a/include/net/ip6_route.h b/include/net/ip6_route.h
index faac0ee..f99e4f0 100644
--- a/include/net/ip6_route.h
+++ b/include/net/ip6_route.h
@@ -1,11 +1,9 @@
 #ifndef _NET_IP6_ROUTE_H
 #define _NET_IP6_ROUTE_H
 
-#define IP6_RT_PRIO_FW		16
 #define IP6_RT_PRIO_USER	1024
 #define IP6_RT_PRIO_ADDRCONF	256
 #define IP6_RT_PRIO_KERN	512
-#define IP6_RT_FLOW_MASK	0x00ff
 
 struct route_info {
 	__u8			type;

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] [IPV6] Minor clenup: remove two unused definitions in net/ip6_route.h
  2008-02-07 15:58 [PATCH] [IPV6] Minor clenup: remove two unused definitions in net/ip6_route.h Rami Rosen
@ 2008-02-08  2:11 ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2008-02-08  2:11 UTC (permalink / raw)
  To: ramirose; +Cc: netdev, linux-kernel

From: "Rami Rosen" <ramirose@gmail.com>
Date: Thu, 7 Feb 2008 17:58:07 +0200

> Remove IP6_RT_PRIO_FW and IP6_RT_FLOW_MASK definitions in
> include/net/ip6_route.h, as they are not used in the kernel.
> 
> Signed-off-by: Rami Rosen <ramirose@gmail.com>

Applied.

If you grep for "fc_metric" in the tree you'll see some
explicit uses of the magic constant "1024" which probably
should be replaced with IP6_RT_PRIO_USER.  If you could
verify that and cook up a patch if correct, I'd appreciate
it.

Thanks.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-02-08  2:10 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-02-07 15:58 [PATCH] [IPV6] Minor clenup: remove two unused definitions in net/ip6_route.h Rami Rosen
2008-02-08  2:11 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).